<p>pespin has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/osmo-bsc/+/22794">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">Introduce VTY cmd to configure Alpha in SI13<br><br>Related: SYS#5358<br>Change-Id: I8b97ea11bad5fe05f2f634945b5703ee9abde81d<br>---<br>M include/osmocom/bsc/bts.h<br>M src/osmo-bsc/bsc_vty.c<br>M src/osmo-bsc/system_information.c<br>3 files changed, 23 insertions(+), 0 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/94/22794/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/include/osmocom/bsc/bts.h b/include/osmocom/bsc/bts.h</span><br><span>index 6797d1c..9a226f5 100644</span><br><span>--- a/include/osmocom/bsc/bts.h</span><br><span>+++ b/include/osmocom/bsc/bts.h</span><br><span>@@ -391,6 +391,9 @@</span><br><span> bool active; /* CCN_ACTIVE */</span><br><span> bool forced_vty; /* set by VTY ? */</span><br><span> } ccn; /* TS 44.060 sec 8.8.2 */</span><br><span style="color: hsl(120, 100%, 40%);">+ struct {</span><br><span style="color: hsl(120, 100%, 40%);">+ uint8_t alpha; /* ALPHA*10, units of 0.1, range <0-10> */</span><br><span style="color: hsl(120, 100%, 40%);">+ } pwr_ctrl; /* TS 44.060 Table 12.9.1 */</span><br><span> } gprs;</span><br><span> </span><br><span> /* threshold (in percent) when BTS shall send CCCH LOAD IND */</span><br><span>diff --git a/src/osmo-bsc/bsc_vty.c b/src/osmo-bsc/bsc_vty.c</span><br><span>index 9005aab..0388e8e 100644</span><br><span>--- a/src/osmo-bsc/bsc_vty.c</span><br><span>+++ b/src/osmo-bsc/bsc_vty.c</span><br><span>@@ -761,6 +761,8 @@</span><br><span> if (bts->gprs.ccn.forced_vty)</span><br><span> vty_out(vty, " gprs ccn-active %d%s",</span><br><span> bts->gprs.ccn.active ? 1 : 0, VTY_NEWLINE);</span><br><span style="color: hsl(120, 100%, 40%);">+ vty_out(vty, " gprs power-control alpha %u%s",</span><br><span style="color: hsl(120, 100%, 40%);">+ bts->gprs.pwr_ctrl.alpha, VTY_NEWLINE);</span><br><span> vty_out(vty, " gprs cell bvci %u%s", bts->gprs.cell.bvci,</span><br><span> VTY_NEWLINE);</span><br><span> for (i = 0; i < ARRAY_SIZE(bts->gprs.cell.timer); i++)</span><br><span>@@ -3509,6 +3511,22 @@</span><br><span> return CMD_SUCCESS;</span><br><span> }</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+DEFUN_USRATTR(cfg_bts_gprs_pwr_ctrl_alpha,</span><br><span style="color: hsl(120, 100%, 40%);">+ cfg_bts_gprs_pwr_ctrl_alpha_cmd,</span><br><span style="color: hsl(120, 100%, 40%);">+ X(BSC_VTY_ATTR_RESTART_ABIS_RSL_LINK),</span><br><span style="color: hsl(120, 100%, 40%);">+ "gprs power-control alpha <0-10>",</span><br><span style="color: hsl(120, 100%, 40%);">+ GPRS_TEXT</span><br><span style="color: hsl(120, 100%, 40%);">+ "GPRS Global Power Control Parameters IE (SI13)\n"</span><br><span style="color: hsl(120, 100%, 40%);">+ "Set alpha\n"</span><br><span style="color: hsl(120, 100%, 40%);">+ "alpha for MS output power control in units of 0.1 (defaults to 0)\n")</span><br><span style="color: hsl(120, 100%, 40%);">+{</span><br><span style="color: hsl(120, 100%, 40%);">+ struct gsm_bts *bts = vty->index;</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ bts->gprs.pwr_ctrl.alpha = atoi(argv[0]);</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ return CMD_SUCCESS;</span><br><span style="color: hsl(120, 100%, 40%);">+}</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span> DEFUN_USRATTR(cfg_no_bts_gprs_ctrl_ack,</span><br><span> cfg_no_bts_gprs_ctrl_ack_cmd,</span><br><span> X(BSC_VTY_ATTR_RESTART_ABIS_RSL_LINK),</span><br><span>@@ -7682,6 +7700,7 @@</span><br><span> install_element(BTS_NODE, &cfg_bts_gprs_net_ctrl_ord_cmd);</span><br><span> install_element(BTS_NODE, &cfg_bts_gprs_ctrl_ack_cmd);</span><br><span> install_element(BTS_NODE, &cfg_bts_gprs_ccn_active_cmd);</span><br><span style="color: hsl(120, 100%, 40%);">+ install_element(BTS_NODE, &cfg_bts_gprs_pwr_ctrl_alpha_cmd);</span><br><span> install_element(BTS_NODE, &cfg_no_bts_gprs_ctrl_ack_cmd);</span><br><span> install_element(BTS_NODE, &cfg_bts_gprs_bvci_cmd);</span><br><span> install_element(BTS_NODE, &cfg_bts_gprs_cell_timer_cmd);</span><br><span>diff --git a/src/osmo-bsc/system_information.c b/src/osmo-bsc/system_information.c</span><br><span>index d018ec3..094c35e 100644</span><br><span>--- a/src/osmo-bsc/system_information.c</span><br><span>+++ b/src/osmo-bsc/system_information.c</span><br><span>@@ -1260,6 +1260,7 @@</span><br><span> bts->gprs.ccn.active :</span><br><span> osmo_bts_has_feature(&bts->model->features,</span><br><span> BTS_FEAT_CCN);</span><br><span style="color: hsl(120, 100%, 40%);">+ si13_default.pwr_ctrl_pars.alpha = bts->gprs.pwr_ctrl.alpha;</span><br><span> </span><br><span> ret = osmo_gsm48_rest_octets_si13_encode(si13->rest_octets, &si13_default);</span><br><span> if (ret < 0)</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-bsc/+/22794">change 22794</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-bsc/+/22794"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: osmo-bsc </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I8b97ea11bad5fe05f2f634945b5703ee9abde81d </div>
<div style="display:none"> Gerrit-Change-Number: 22794 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>