<p>pespin <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/osmo-gsm-tester/+/22043">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  Jenkins Builder: Verified
  pespin: Looks good to me, approved

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">4g: add checks for received PRACHs for ping tests<br><br>the tests already check for sent PRACHs, this will<br>also check for received PRACHs on the eNB to make<br>sure we don't detect any fake PRACHs during the tests.<br><br>Change-Id: Ib23056b1ad4b18a7dde6cd0c997f5114ac2acb61<br>---<br>M sysmocom/suites/4g/rrc_idle_mo_ping.py<br>M sysmocom/suites/4g/rrc_idle_mt_ping.py<br>2 files changed, 19 insertions(+), 5 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/sysmocom/suites/4g/rrc_idle_mo_ping.py b/sysmocom/suites/4g/rrc_idle_mo_ping.py</span><br><span>index ced798d..389e5a2 100755</span><br><span>--- a/sysmocom/suites/4g/rrc_idle_mo_ping.py</span><br><span>+++ b/sysmocom/suites/4g/rrc_idle_mo_ping.py</span><br><span>@@ -31,9 +31,16 @@</span><br><span> output = proc.get_stdout()</span><br><span> </span><br><span> # Check PRACH transmissions</span><br><span style="color: hsl(120, 100%, 40%);">+num_prachs = 2</span><br><span> num_prach_sent = ue.get_counter('prach_sent')</span><br><span style="color: hsl(0, 100%, 40%);">-if num_prach_sent != 2:</span><br><span style="color: hsl(0, 100%, 40%);">-    raise Exception("Expected to have sent exactly 2 PRACHs, but in fact sent {}".format(num_prach_sent))</span><br><span style="color: hsl(120, 100%, 40%);">+if num_prach_sent != num_prachs:</span><br><span style="color: hsl(120, 100%, 40%);">+    raise Exception("Expected to have sent exactly {} PRACHs, but in fact sent {}".format(num_prachs, num_prach_sent))</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+# Check PRACH receptions</span><br><span style="color: hsl(120, 100%, 40%);">+num_prach_received = enb.get_counter('prach_received')</span><br><span style="color: hsl(120, 100%, 40%);">+if num_prach_sent != num_prachs:</span><br><span style="color: hsl(120, 100%, 40%);">+    raise Exception("Expected to have received exactly {} PRACHs, but in fact received {}".format(num_prachs, num_prach_received))</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+output += "\nnum_prach_sent={}\nnum_prach_received={}\n".format(num_prach_sent, num_prach_received)</span><br><span> print(output)</span><br><span> test.set_report_stdout(output)</span><br><span>diff --git a/sysmocom/suites/4g/rrc_idle_mt_ping.py b/sysmocom/suites/4g/rrc_idle_mt_ping.py</span><br><span>index dcabe21..bdebb26 100755</span><br><span>--- a/sysmocom/suites/4g/rrc_idle_mt_ping.py</span><br><span>+++ b/sysmocom/suites/4g/rrc_idle_mt_ping.py</span><br><span>@@ -26,7 +26,7 @@</span><br><span> # Wait a bit</span><br><span> sleep(5)</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-# Generate MO traffic, send single ping</span><br><span style="color: hsl(120, 100%, 40%);">+# Generate MT traffic, send single ping</span><br><span> proc = epc.prepare_process('ping', ('ping', '-c', '1', ue.get_assigned_addr()))</span><br><span> proc.launch_sync()</span><br><span> output = proc.get_stdout()</span><br><span>@@ -37,9 +37,16 @@</span><br><span>     raise Exception("Expected to receive exactly 1 paging message, but in fact received {}".format(num_paging_received))</span><br><span> </span><br><span> # Check PRACH transmissions</span><br><span style="color: hsl(120, 100%, 40%);">+num_prachs = 2</span><br><span> num_prach_sent = ue.get_counter('prach_sent')</span><br><span style="color: hsl(0, 100%, 40%);">-if num_prach_sent != 2:</span><br><span style="color: hsl(0, 100%, 40%);">-    raise Exception("Expected to have sent exactly 2 PRACHs, but in fact sent {}".format(num_prach_sent))</span><br><span style="color: hsl(120, 100%, 40%);">+if num_prach_sent != num_prachs:</span><br><span style="color: hsl(120, 100%, 40%);">+    raise Exception("Expected to have sent exactly {} PRACHs, but in fact sent {}".format(num_prachs, num_prach_sent))</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+# Check PRACH receptions</span><br><span style="color: hsl(120, 100%, 40%);">+num_prach_received = enb.get_counter('prach_received')</span><br><span style="color: hsl(120, 100%, 40%);">+if num_prach_sent != num_prachs:</span><br><span style="color: hsl(120, 100%, 40%);">+    raise Exception("Expected to have received exactly {} PRACHs, but in fact received {}".format(num_prachs, num_prach_received))</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+output += "\nnum_prach_sent={}\nnum_prach_received={}\n".format(num_prach_sent, num_prach_received)</span><br><span> print(output)</span><br><span> test.set_report_stdout(output)</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-gsm-tester/+/22043">change 22043</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-gsm-tester/+/22043"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-gsm-tester </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Ib23056b1ad4b18a7dde6cd0c997f5114ac2acb61 </div>
<div style="display:none"> Gerrit-Change-Number: 22043 </div>
<div style="display:none"> Gerrit-PatchSet: 6 </div>
<div style="display:none"> Gerrit-Owner: srs_andre <andre@softwareradiosystems.com> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>