<p>laforge <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/22738">View Change</a></p><div style="white-space:pre-wrap">Approvals:
Jenkins Builder: Verified
laforge: Looks good to me, approved
</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">Osmocom_Gb_Types: Fix warning: control reaches end of non-void function<br><br>Change-Id: Ic2b8d0215c378ec2fd1a44775dc4e43616ca9f3c<br>---<br>M library/Osmocom_Gb_Types.ttcn<br>1 file changed, 8 insertions(+), 7 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/library/Osmocom_Gb_Types.ttcn b/library/Osmocom_Gb_Types.ttcn</span><br><span>index 4e1fb8c..82f2aca 100644</span><br><span>--- a/library/Osmocom_Gb_Types.ttcn</span><br><span>+++ b/library/Osmocom_Gb_Types.ttcn</span><br><span>@@ -5,6 +5,7 @@</span><br><span> </span><br><span> import from General_Types all;</span><br><span> import from Osmocom_Types all;</span><br><span style="color: hsl(120, 100%, 40%);">+ import from Misc_Helpers all;</span><br><span> import from GSM_Types all;</span><br><span> import from BSSGP_Types all</span><br><span> import from NS_Types all</span><br><span>@@ -3690,10 +3691,8 @@</span><br><span> case (PDU_BSSGP:{pDU_BSSGP_PAGING_CS:={?,?,?,{bVCI:=?},*,*,*,*,*}}) {</span><br><span> return pdu.pDU_BSSGP_PAGING_CS.paging_Field4.bVCI;</span><br><span> }</span><br><span style="color: hsl(0, 100%, 40%);">- case else {</span><br><span style="color: hsl(0, 100%, 40%);">- return omit;</span><br><span style="color: hsl(0, 100%, 40%);">- }</span><br><span> }</span><br><span style="color: hsl(120, 100%, 40%);">+ return omit;</span><br><span> }</span><br><span> </span><br><span> /* extract the BVCI IE of given PDU + convert it to integer value */</span><br><span>@@ -3734,8 +3733,9 @@</span><br><span> } else if (substr(tllib, 0, 4) == '0001'B) {</span><br><span> return TLLI_RAND_G_RNTI;</span><br><span> } else {</span><br><span style="color: hsl(0, 100%, 40%);">- setverdict(fail, "Unknonw TLLI Type ", tllib);</span><br><span style="color: hsl(0, 100%, 40%);">- mtc.stop;</span><br><span style="color: hsl(120, 100%, 40%);">+ Misc_Helpers.f_shutdown(__BFILE__, __LINE__, fail,</span><br><span style="color: hsl(120, 100%, 40%);">+ log2str("Unknonw TLLI Type ", tllib));</span><br><span style="color: hsl(120, 100%, 40%);">+ return TLLI_LOCAL;</span><br><span> }</span><br><span> }</span><br><span> </span><br><span>@@ -3751,8 +3751,9 @@</span><br><span> case (TLLI_G_RNTI) { prefix := '0000'B }</span><br><span> case (TLLI_RAND_G_RNTI) { prefix := '0001'B }</span><br><span> case else {</span><br><span style="color: hsl(0, 100%, 40%);">- setverdict(fail, "Unknonw TLLI Type ", tlli_type);</span><br><span style="color: hsl(0, 100%, 40%);">- mtc.stop;</span><br><span style="color: hsl(120, 100%, 40%);">+ Misc_Helpers.f_shutdown(__BFILE__, __LINE__, fail,</span><br><span style="color: hsl(120, 100%, 40%);">+ log2str("Unknonw TLLI Type ", tlli_type));</span><br><span style="color: hsl(120, 100%, 40%);">+ return '00000000'O;</span><br><span> }</span><br><span> }</span><br><span> return bit2oct(prefix & substr(tmsi_bits, lengthof(prefix), 32-lengthof(prefix)));</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/22738">change 22738</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/22738"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: osmo-ttcn3-hacks </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Ic2b8d0215c378ec2fd1a44775dc4e43616ca9f3c </div>
<div style="display:none"> Gerrit-Change-Number: 22738 </div>
<div style="display:none"> Gerrit-PatchSet: 3 </div>
<div style="display:none"> Gerrit-Owner: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>