<p>laforge <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/22725">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  Jenkins Builder: Verified
  fixeria: Looks good to me, approved
  laforge: Looks good to me, approved

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">CTRL: Avoid using keyword 'now' as var<br><br>Fixes warning: Keyword 'now' is treated as an identifier. Activate<br>compiler option '-I' to use real-time testing features<br><br>Change-Id: I2b350bc93b33f36f72d35cb48d01f6c37ac1630f<br>---<br>M library/Osmocom_CTRL_Functions.ttcn<br>1 file changed, 4 insertions(+), 4 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/library/Osmocom_CTRL_Functions.ttcn b/library/Osmocom_CTRL_Functions.ttcn</span><br><span>index 294fe33..15cb26f 100644</span><br><span>--- a/library/Osmocom_CTRL_Functions.ttcn</span><br><span>+++ b/library/Osmocom_CTRL_Functions.ttcn</span><br><span>@@ -268,14 +268,14 @@</span><br><span>   * Set the test verdict accordingly. */</span><br><span>      function f_counter_name_vals_expect(IPA_CTRL_PT pt, charstring instance_name, integer instance_nr,</span><br><span>                                       CounterNameVals vals) {</span><br><span style="color: hsl(0, 100%, 40%);">-             var CounterNameVals now := f_counter_name_vals_get(pt, instance_name, instance_nr, vals);</span><br><span style="color: hsl(120, 100%, 40%);">+             var CounterNameVals last := f_counter_name_vals_get(pt, instance_name, instance_nr, vals);</span><br><span>           for (var integer i := 0; i < lengthof(vals); i := i + 1) {</span><br><span style="color: hsl(0, 100%, 40%);">-                   if (now[i].name != vals[i].name) {</span><br><span style="color: hsl(120, 100%, 40%);">+                    if (last[i].name != vals[i].name) {</span><br><span>                          setverdict(fail, "Internal error");</span><br><span>                        }</span><br><span style="color: hsl(0, 100%, 40%);">-                       if (now[i].val != vals[i].val) {</span><br><span style="color: hsl(120, 100%, 40%);">+                      if (last[i].val != vals[i].val) {</span><br><span>                            setverdict(fail, "Rate counter mismatch: ", instance_name, " ", instance_nr,</span><br><span style="color: hsl(0, 100%, 40%);">-                                           " ", vals[i].name, " is at ", now[i].val, " but expected ", vals[i].val);</span><br><span style="color: hsl(120, 100%, 40%);">+                                       " ", vals[i].name, " is at ", last[i].val, " but expected ", vals[i].val);</span><br><span>                  }</span><br><span>            }</span><br><span>            setverdict(pass);</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/22725">change 22725</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/22725"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-ttcn3-hacks </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I2b350bc93b33f36f72d35cb48d01f6c37ac1630f </div>
<div style="display:none"> Gerrit-Change-Number: 22725 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>