<p>laforge <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/osmo-bsc/+/22754">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  laforge: Looks good to me, approved
  pespin: Looks good to me, but someone else must approve
  Jenkins Builder: Verified

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">hide the "smscb-command" vty command; people should use osmo-cbc<br><br>Many years prior to the implementation of osmo-cbc, we introduced<br>a way how raw RSL SMSCB COMMANMD can be injected from the VTY.<br><br>These days, people should use the CBSP interface with osmo-cbc or any<br>other CBC.  We should not advertise the VTY command hack<br>as a standard feature anymore.<br><br>Change-Id: If5ddc3db989763a1f47d4cbc026e293e3134d8ef<br>Related: OS#4753<br>---<br>M src/osmo-bsc/bsc_vty.c<br>1 file changed, 4 insertions(+), 2 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/osmo-bsc/bsc_vty.c b/src/osmo-bsc/bsc_vty.c</span><br><span>index 26941e2..9005aab 100644</span><br><span>--- a/src/osmo-bsc/bsc_vty.c</span><br><span>+++ b/src/osmo-bsc/bsc_vty.c</span><br><span>@@ -5796,8 +5796,9 @@</span><br><span>   return CMD_SUCCESS;</span><br><span> }</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">-DEFUN(smscb_cmd, smscb_cmd_cmd,</span><br><span style="color: hsl(120, 100%, 40%);">+/* this command is now hidden, as it's a low-level debug hack, and people should</span><br><span style="color: hsl(120, 100%, 40%);">+ * instead use osmo-cbc these days */</span><br><span style="color: hsl(120, 100%, 40%);">+DEFUN_HIDDEN(smscb_cmd, smscb_cmd_cmd,</span><br><span>     "bts <0-255> smscb-command (normal|schedule|default) <1-4> HEXSTRING",</span><br><span>         "BTS related commands\n" BTS_NR_STR</span><br><span>        "SMS Cell Broadcast\n"</span><br><span>@@ -5861,6 +5862,7 @@</span><br><span>             return CMD_WARNING;</span><br><span>  }</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+ /* SDCCH4 might not be correct here if the CBCH is on a SDCCH8? */</span><br><span>   rsl_sms_cb_command(bts, RSL_CHAN_SDCCH4_ACCH, cb_cmd, false, buf, rc);</span><br><span> </span><br><span>   return CMD_SUCCESS;</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-bsc/+/22754">change 22754</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-bsc/+/22754"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-bsc </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: If5ddc3db989763a1f47d4cbc026e293e3134d8ef </div>
<div style="display:none"> Gerrit-Change-Number: 22754 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Reviewer: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>