<p>laforge <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/osmo-bsc/+/22768">View Change</a></p><div style="white-space:pre-wrap">Approvals:
laforge: Looks good to me, approved
Jenkins Builder: Verified
</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">power_control: enable Uplink DPC by default if format is known<br><br>So far osmo-bsc would enable Uplink DPC (Dynamic Power Control) only<br>for osmo-bts, and the 'static' mode for all other BTS models. This<br>decision dates back to the time when ip.access specific encoding for<br>dynamic power control parameters was not implemented, and the MS<br>Power Parameters IE was sent empty in the RSL messages.<br><br>Let's make a step forward by enabling Uplink DPC by default for<br>all BTS models which declare the API for vendor-specific encoding<br>of the power control parameters. Currently this includes osmo-bts<br>and nanoBTS, both supporting ip.access specific format.<br><br>Change-Id: If86d27d4332af3d82f862737340d061e42e34eba<br>Related: SYS#4918<br>---<br>M doc/manuals/chapters/power_control.adoc<br>M src/osmo-bsc/bts.c<br>2 files changed, 8 insertions(+), 5 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/doc/manuals/chapters/power_control.adoc b/doc/manuals/chapters/power_control.adoc</span><br><span>index 5de2b9c..dbe2d13 100644</span><br><span>--- a/doc/manuals/chapters/power_control.adoc</span><br><span>+++ b/doc/manuals/chapters/power_control.adoc</span><br><span>@@ -117,8 +117,10 @@</span><br><span> <2> Send both RSL MS/BS Power IE and vendor-specific MS/BS Power Parameters IE.</span><br><span> <3> Do not send any power control IEs in RSL CHANnel ACTIVation messages.</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-By default, `static` mode is used for BS power control, while `dyn-bts` is used</span><br><span style="color: hsl(0, 100%, 40%);">-for MS power control. Changing the mode at run-time would not affect already</span><br><span style="color: hsl(120, 100%, 40%);">+By default, `static` mode is used for BS power control, while `dyn-bts` mode is</span><br><span style="color: hsl(120, 100%, 40%);">+automatically enabled for MS power control if vendor-specific format of the power</span><br><span style="color: hsl(120, 100%, 40%);">+control parameters (see above) is implemented for particular BTS model. Otherwise</span><br><span style="color: hsl(120, 100%, 40%);">+`static` mode is used too. Changing the mode at run-time would not affect already</span><br><span> established connections, only the new ones (check flag `l`).</span><br><span> </span><br><span> For BS power control, there is an additional parameter:</span><br><span>diff --git a/src/osmo-bsc/bts.c b/src/osmo-bsc/bts.c</span><br><span>index ac0e2af..628d301 100644</span><br><span>--- a/src/osmo-bsc/bts.c</span><br><span>+++ b/src/osmo-bsc/bts.c</span><br><span>@@ -522,9 +522,6 @@</span><br><span> </span><br><span> switch (bts->type) {</span><br><span> case GSM_BTS_TYPE_OSMOBTS:</span><br><span style="color: hsl(0, 100%, 40%);">- /* Enable dynamic Uplink power control by default */</span><br><span style="color: hsl(0, 100%, 40%);">- bts->ms_power_ctrl.mode = GSM_PWR_CTRL_MODE_DYN_BTS;</span><br><span style="color: hsl(0, 100%, 40%);">- /* fall-through */</span><br><span> case GSM_BTS_TYPE_NANOBTS:</span><br><span> /* Set the default OML Stream ID to 0xff */</span><br><span> bts->oml_tei = 0xff;</span><br><span>@@ -543,6 +540,10 @@</span><br><span> break;</span><br><span> }</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+ /* Enable dynamic Uplink power control by default (if supported) */</span><br><span style="color: hsl(120, 100%, 40%);">+ if (model->power_ctrl_enc_rsl_params != NULL)</span><br><span style="color: hsl(120, 100%, 40%);">+ bts->ms_power_ctrl.mode = GSM_PWR_CTRL_MODE_DYN_BTS;</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span> return 0;</span><br><span> }</span><br><span> </span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-bsc/+/22768">change 22768</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-bsc/+/22768"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: osmo-bsc </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: If86d27d4332af3d82f862737340d061e42e34eba </div>
<div style="display:none"> Gerrit-Change-Number: 22768 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: fixeria <vyanitskiy@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>