<p>laforge <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/22722">View Change</a></p><div style="white-space:pre-wrap">Approvals:
Jenkins Builder: Verified
laforge: Looks good to me, approved
</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">BSSGP_Emulation: Fix warning: control reaches end of non-void function<br><br>Change-Id: I9a44afc81b5b6b35a32a12efcf2dd1cb15e73e12<br>---<br>M library/BSSGP_Emulation.ttcnpp<br>1 file changed, 16 insertions(+), 15 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/library/BSSGP_Emulation.ttcnpp b/library/BSSGP_Emulation.ttcnpp</span><br><span>index 4af5f82..04220ed 100644</span><br><span>--- a/library/BSSGP_Emulation.ttcnpp</span><br><span>+++ b/library/BSSGP_Emulation.ttcnpp</span><br><span>@@ -25,6 +25,7 @@</span><br><span> import from BSSGP_Types all;</span><br><span> import from Osmocom_Gb_Types all;</span><br><span> import from IPL4asp_Types all;</span><br><span style="color: hsl(120, 100%, 40%);">+import from Misc_Helpers all;</span><br><span> </span><br><span> #ifdef BSSGP_EM_L3</span><br><span> import from MobileL3_GMM_SM_Types all;</span><br><span>@@ -591,8 +592,8 @@</span><br><span> } else if (ischosen(l3_mo.msgs.sms)) {</span><br><span> return c_LLC_SAPI_LLSMS;</span><br><span> }</span><br><span style="color: hsl(0, 100%, 40%);">- setverdict(fail, "No LLC SAPI for ", l3_mo);</span><br><span style="color: hsl(0, 100%, 40%);">- mtc.stop;</span><br><span style="color: hsl(120, 100%, 40%);">+ Misc_Helpers.f_shutdown(__BFILE__, __LINE__, fail, log2str("No LLC SAPI for ", l3_mo));</span><br><span style="color: hsl(120, 100%, 40%);">+ return '0000'B;</span><br><span> }</span><br><span> </span><br><span> private function f_llc_sapi_by_l3_mt(PDU_L3_SGSN_MS l3_mt) return BIT4 {</span><br><span>@@ -603,8 +604,8 @@</span><br><span> } else if (ischosen(l3_mt.msgs.sms)) {</span><br><span> return c_LLC_SAPI_LLSMS;</span><br><span> }</span><br><span style="color: hsl(0, 100%, 40%);">- setverdict(fail, "No LLC SAPI for ", l3_mt);</span><br><span style="color: hsl(0, 100%, 40%);">- mtc.stop;</span><br><span style="color: hsl(120, 100%, 40%);">+ Misc_Helpers.f_shutdown(__BFILE__, __LINE__, fail, log2str("No LLC SAPI for ", l3_mt));</span><br><span style="color: hsl(120, 100%, 40%);">+ return '0000'B;</span><br><span> }</span><br><span> #endif</span><br><span> </span><br><span>@@ -830,8 +831,7 @@</span><br><span> </span><br><span> /* Default Create Callback function: Fail and terminate */</span><br><span> function DefaultCreateCallback(BssgpBvci bvci, BssgpCellId cell_id, OCT4 tlli, BssgpDecoded dec) runs on BSSGP_BVC_CT {</span><br><span style="color: hsl(0, 100%, 40%);">- setverdict(fail, "Couldn't find Component for TLLI ", tlli);</span><br><span style="color: hsl(0, 100%, 40%);">- mtc.stop;</span><br><span style="color: hsl(120, 100%, 40%);">+ Misc_Helpers.f_shutdown(__BFILE__, __LINE__, fail, log2str("Couldn't find Component for TLLI ", tlli));</span><br><span> }</span><br><span> </span><br><span> /*</span><br><span>@@ -874,9 +874,10 @@</span><br><span> for (i := 0; i < sizeof(ClientTable); i := i+1) {</span><br><span> if (isvalue(ClientTable[i].imsi) and ClientTable[i].imsi == imsi) {</span><br><span> if (ClientTable[i].comp_ref != vc_conn) {</span><br><span style="color: hsl(0, 100%, 40%);">- setverdict(fail, "Cannot unregister index=", i, " IMSI ", imsi, " registred to ",</span><br><span style="color: hsl(0, 100%, 40%);">- ClientTable[i].comp_ref, " from ", vc_conn);</span><br><span style="color: hsl(0, 100%, 40%);">- mtc.stop;</span><br><span style="color: hsl(120, 100%, 40%);">+ Misc_Helpers.f_shutdown(__BFILE__, __LINE__, fail,</span><br><span style="color: hsl(120, 100%, 40%);">+ log2str("Cannot unregister index=", i, " IMSI ",</span><br><span style="color: hsl(120, 100%, 40%);">+ imsi, " registred to ", ClientTable[i].comp_ref,</span><br><span style="color: hsl(120, 100%, 40%);">+ " from ", vc_conn));</span><br><span> }</span><br><span> log("Removing Client IMSI=", imsi, ", index=", i);</span><br><span> ClientTable[i] := {</span><br><span>@@ -919,8 +920,8 @@</span><br><span> return ClientTable[i].comp_ref;</span><br><span> }</span><br><span> }</span><br><span style="color: hsl(0, 100%, 40%);">- setverdict(fail, "Couldn't find Component for IMSI ", imsi);</span><br><span style="color: hsl(0, 100%, 40%);">- mtc.stop;</span><br><span style="color: hsl(120, 100%, 40%);">+ Misc_Helpers.f_shutdown(__BFILE__, __LINE__, fail, log2str("Couldn't find Component for IMSI ", imsi));</span><br><span style="color: hsl(120, 100%, 40%);">+ return ClientTable[0].comp_ref;</span><br><span> }</span><br><span> </span><br><span> private function f_tbl_comp_by_tlli(OCT4 tlli) runs on BSSGP_BVC_CT return BSSGP_Client_CT {</span><br><span>@@ -942,8 +943,8 @@</span><br><span> return i;</span><br><span> }</span><br><span> }</span><br><span style="color: hsl(0, 100%, 40%);">- setverdict(fail, "Couldn't find Client for Component ", comp_ref);</span><br><span style="color: hsl(0, 100%, 40%);">- mtc.stop;</span><br><span style="color: hsl(120, 100%, 40%);">+ Misc_Helpers.f_shutdown(__BFILE__, __LINE__, fail, log2str("Couldn't find Client for Component ", comp_ref));</span><br><span style="color: hsl(120, 100%, 40%);">+ return 1;</span><br><span> }</span><br><span> </span><br><span> private function f_tbl_tlli_by_comp(BSSGP_Client_CT comp_ref) runs on BSSGP_BVC_CT return OCT4 {</span><br><span>@@ -954,8 +955,8 @@</span><br><span> return ClientTable[i].tlli;</span><br><span> }</span><br><span> }</span><br><span style="color: hsl(0, 100%, 40%);">- setverdict(fail, "Couldn't find TLLI for Component ", comp_ref);</span><br><span style="color: hsl(0, 100%, 40%);">- mtc.stop;</span><br><span style="color: hsl(120, 100%, 40%);">+ Misc_Helpers.f_shutdown(__BFILE__, __LINE__, fail, log2str("Couldn't find TLLI for Component ", comp_ref));</span><br><span style="color: hsl(120, 100%, 40%);">+ return '00000000'O;</span><br><span> }</span><br><span> </span><br><span> /* PDU_BSSGP enhanced with LLC and possibly L3 decoded payloads */</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/22722">change 22722</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/22722"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: osmo-ttcn3-hacks </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I9a44afc81b5b6b35a32a12efcf2dd1cb15e73e12 </div>
<div style="display:none"> Gerrit-Change-Number: 22722 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>