<p>laforge <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/osmo-bsc/+/22767">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  Jenkins Builder: Verified
  laforge: Looks good to me, approved

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">power_control: check BTS model in cfg_power_ctrl_avg_osmo_ewma()<br><br>Change-Id: I1c454f447d37cbc4d44b242dc4b2c62297ee3f67<br>Related: SYS#4918<br>---<br>M src/osmo-bsc/bsc_vty.c<br>1 file changed, 7 insertions(+), 3 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/osmo-bsc/bsc_vty.c b/src/osmo-bsc/bsc_vty.c</span><br><span>index 03b87b4..567b168 100644</span><br><span>--- a/src/osmo-bsc/bsc_vty.c</span><br><span>+++ b/src/osmo-bsc/bsc_vty.c</span><br><span>@@ -5209,14 +5209,18 @@</span><br><span> {</span><br><span>     struct gsm_power_ctrl_params *params = vty->index;</span><br><span>        struct gsm_power_ctrl_meas_params *avg_params;</span><br><span style="color: hsl(120, 100%, 40%);">+        const struct gsm_bts *bts;</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-#if 0</span><br><span style="color: hsl(0, 100%, 40%);">-     if (trx->bts->type != GSM_BTS_TYPE_OSMOBTS) {</span><br><span style="color: hsl(120, 100%, 40%);">+   if (params->dir == GSM_PWR_CTRL_DIR_UL)</span><br><span style="color: hsl(120, 100%, 40%);">+            bts = container_of(params, struct gsm_bts, ms_power_ctrl);</span><br><span style="color: hsl(120, 100%, 40%);">+    else</span><br><span style="color: hsl(120, 100%, 40%);">+          bts = container_of(params, struct gsm_bts, bs_power_ctrl);</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+  if (bts->type != GSM_BTS_TYPE_OSMOBTS) {</span><br><span>          vty_out(vty, "%% EWMA is an OsmoBTS specific algorithm, "</span><br><span>                  "it's not usable for other BTS types%s", VTY_NEWLINE);</span><br><span>                 return CMD_WARNING;</span><br><span>  }</span><br><span style="color: hsl(0, 100%, 40%);">-#endif</span><br><span> </span><br><span>  avg_params = POWER_CONTROL_MEAS_AVG_PARAMS(params);</span><br><span>  avg_params->algo = GSM_PWR_CTRL_MEAS_AVG_ALGO_OSMO_EWMA;</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-bsc/+/22767">change 22767</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-bsc/+/22767"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-bsc </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I1c454f447d37cbc4d44b242dc4b2c62297ee3f67 </div>
<div style="display:none"> Gerrit-Change-Number: 22767 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: fixeria <vyanitskiy@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>