<p>fixeria <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/osmo-bts/+/22761">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  laforge: Looks good to me, but someone else must approve
  fixeria: Looks good to me, approved
  pespin: Looks good to me, but someone else must approve
  Jenkins Builder: Verified

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">oml: avoid redundant ntohl() / htonl() conversion<br><br>Change-Id: I2ae84dcd2987ff0cee5ca06ced06e65a30847a81<br>---<br>M src/common/oml.c<br>1 file changed, 4 insertions(+), 3 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/common/oml.c b/src/common/oml.c</span><br><span>index ce76064..b7b86e3 100644</span><br><span>--- a/src/common/oml.c</span><br><span>+++ b/src/common/oml.c</span><br><span>@@ -1384,7 +1384,6 @@</span><br><span> {</span><br><span>       struct e1inp_sign_link *oml_link = trx->bts->oml_link;</span><br><span>         uint16_t port = IPA_TCP_PORT_RSL;</span><br><span style="color: hsl(0, 100%, 40%);">-       uint32_t ip = get_signlink_remote_ip(oml_link);</span><br><span>      const char *trx_name = gsm_trx_name(trx);</span><br><span>    struct in_addr in;</span><br><span>   int rc;</span><br><span>@@ -1392,13 +1391,15 @@</span><br><span>    uint8_t stream_id = 0;</span><br><span> </span><br><span>   if (TLVP_PRES_LEN(tp, NM_ATT_IPACC_DST_IP, 4))</span><br><span style="color: hsl(0, 100%, 40%);">-          ip = ntohl(tlvp_val32_unal(tp, NM_ATT_IPACC_DST_IP));</span><br><span style="color: hsl(120, 100%, 40%);">+         in.s_addr = tlvp_val32_unal(tp, NM_ATT_IPACC_DST_IP);</span><br><span style="color: hsl(120, 100%, 40%);">+ else</span><br><span style="color: hsl(120, 100%, 40%);">+          in.s_addr = htonl(get_signlink_remote_ip(oml_link));</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span>       if (TLVP_PRES_LEN(tp, NM_ATT_IPACC_DST_IP_PORT, 2))</span><br><span>          port = ntohs(tlvp_val16_unal(tp, NM_ATT_IPACC_DST_IP_PORT));</span><br><span>         if (TLVP_PRES_LEN(tp, NM_ATT_IPACC_STREAM_ID, 1))</span><br><span>            stream_id = *TLVP_VAL(tp, NM_ATT_IPACC_STREAM_ID);</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-  in.s_addr = htonl(ip);</span><br><span>       LOGP(DOML, LOGL_INFO, "%s: Rx IPA RSL CONNECT IP=%s PORT=%u STREAM=0x%02x\n",</span><br><span>           trx_name, inet_ntoa(in), port, stream_id);</span><br><span> </span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-bts/+/22761">change 22761</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-bts/+/22761"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-bts </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I2ae84dcd2987ff0cee5ca06ced06e65a30847a81 </div>
<div style="display:none"> Gerrit-Change-Number: 22761 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: fixeria <vyanitskiy@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Reviewer: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>