<p>laforge has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/libosmo-abis/+/22755">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">osmo_ortp: Don't print ERROR message for every missing RTP frame<br><br>* it's inconsistent to print ERROR in a LOGL_INFO message<br>* loosing RTP packets is not that unusual, especially when the channel<br>  is just starting up<br><br>Change-Id: Ide0017987b4cea7fd24795941494f1da913ea673<br>Closes: OS#4464<br>---<br>M src/trau/osmo_ortp.c<br>1 file changed, 4 insertions(+), 2 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/libosmo-abis refs/changes/55/22755/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/trau/osmo_ortp.c b/src/trau/osmo_ortp.c</span><br><span>index 0cd4e9d..6e91f8d 100644</span><br><span>--- a/src/trau/osmo_ortp.c</span><br><span>+++ b/src/trau/osmo_ortp.c</span><br><span>@@ -202,8 +202,10 @@</span><br><span>   if (recv_with_cb(rs))</span><br><span>                return 1;</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-   LOGP(DLMIB, LOGL_INFO, "osmo_rtp_socket_poll(%u): ERROR!\n",</span><br><span style="color: hsl(0, 100%, 40%);">-       rs->rx_user_ts);</span><br><span style="color: hsl(120, 100%, 40%);">+      /* this happens every time we miss an incoming RTP frame, which is quite common</span><br><span style="color: hsl(120, 100%, 40%);">+        * when a voice channel is first activated, or also in case of packet loss.</span><br><span style="color: hsl(120, 100%, 40%);">+    * See also https://osmocom.org/issues/4464 */</span><br><span style="color: hsl(120, 100%, 40%);">+        LOGP(DLMIB, LOGL_DEBUG, "osmo_rtp_socket_poll(%u): No message received\n", rs->rx_user_ts);</span><br><span>     return 0;</span><br><span> }</span><br><span> </span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/libosmo-abis/+/22755">change 22755</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/libosmo-abis/+/22755"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: libosmo-abis </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Ide0017987b4cea7fd24795941494f1da913ea673 </div>
<div style="display:none"> Gerrit-Change-Number: 22755 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>