<p>pespin has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/22746">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">pcu: TC_rim_ran_info_req_single_rep: don't duplicate si_default locally<br><br>The same values are available for several tests as gloval consts.<br><br>Change-Id: I32b7d841bc1fa896f9866c5d7fba857e1ca65ab3<br>---<br>M pcu/PCU_Tests.ttcn<br>1 file changed, 4 insertions(+), 10 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/46/22746/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/pcu/PCU_Tests.ttcn b/pcu/PCU_Tests.ttcn</span><br><span>index 5f75992..0b887db 100644</span><br><span>--- a/pcu/PCU_Tests.ttcn</span><br><span>+++ b/pcu/PCU_Tests.ttcn</span><br><span>@@ -4124,9 +4124,6 @@</span><br><span> * PCUIF on startup. */</span><br><span> testcase TC_rim_ran_info_req_single_rep() runs on RAW_PCU_Test_CT {</span><br><span> const BssgpBvci bvci := mp_gb_cfg.bvc[0].bvci;</span><br><span style="color: hsl(0, 100%, 40%);">- var octetstring si1_expect := '198fb100000000000000000000000000007900002b'O;</span><br><span style="color: hsl(0, 100%, 40%);">- var octetstring si3_expect := '1b753000f110236ec9033c2747407900003c0b2b2b'O;</span><br><span style="color: hsl(0, 100%, 40%);">- var octetstring si13_expect := '009000185a6fc9e08410ab2b2b2b2b2b2b2b2b2b2b'O;</span><br><span> timer T := 2.0;</span><br><span> </span><br><span> /* Initialize NS/BSSGP side */</span><br><span>@@ -4139,11 +4136,11 @@</span><br><span> f_bssgp_establish();</span><br><span> </span><br><span> /* Send sysinfo to the PCU */</span><br><span style="color: hsl(0, 100%, 40%);">- var template PCUIF_Message si1_data_ind := ts_PCUIF_DATA_IND(0, 0, 0, 0, PCU_IF_SAPI_BCCH, '5506'O & si1_expect, 0, 0, 0, 0, 32767);</span><br><span style="color: hsl(120, 100%, 40%);">+ var template PCUIF_Message si1_data_ind := ts_PCUIF_DATA_IND(0, 0, 0, 0, PCU_IF_SAPI_BCCH, '5506'O & si1_default, 0, 0, 0, 0, 32767);</span><br><span> BTS.send(si1_data_ind);</span><br><span style="color: hsl(0, 100%, 40%);">- var template PCUIF_Message si3_data_ind := ts_PCUIF_DATA_IND(0, 0, 0, 0, PCU_IF_SAPI_BCCH, '4906'O & si3_expect, 0, 0, 0, 0, 32767);</span><br><span style="color: hsl(120, 100%, 40%);">+ var template PCUIF_Message si3_data_ind := ts_PCUIF_DATA_IND(0, 0, 0, 0, PCU_IF_SAPI_BCCH, '4906'O & si3_default, 0, 0, 0, 0, 32767);</span><br><span> BTS.send(si3_data_ind);</span><br><span style="color: hsl(0, 100%, 40%);">- var template PCUIF_Message si16_data_ind := ts_PCUIF_DATA_IND(0, 0, 0, 0, PCU_IF_SAPI_BCCH, '0106'O & si13_expect, 0, 0, 0, 0, 32767);</span><br><span style="color: hsl(120, 100%, 40%);">+ var template PCUIF_Message si16_data_ind := ts_PCUIF_DATA_IND(0, 0, 0, 0, PCU_IF_SAPI_BCCH, '0106'O & si13_default, 0, 0, 0, 0, 32767);</span><br><span> BTS.send(si16_data_ind);</span><br><span> f_sleep(1.0);</span><br><span> </span><br><span>@@ -4158,9 +4155,6 @@</span><br><span> src_addr := valueof(t_RIM_Routing_Address_cid(src_cid));</span><br><span> dst_addr := valueof(t_RIM_Routing_Address_cid(mp_gb_cfg.bvc[0].cell_id));</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">- var octetstring si_expect := si1_expect & si3_expect & si13_expect;</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span> req_cont := ts_RAN_Information_Request_RIM_Container(ts_RIM_Application_Identity(RIM_APP_ID_NACC),</span><br><span> ts_RIM_Sequence_Number(1),</span><br><span> ts_RIM_PDU_Indications(false, RIM_PDU_TYPE_SING_REP),</span><br><span>@@ -4175,7 +4169,7 @@</span><br><span> tr_RIM_Sequence_Number(1),</span><br><span> tr_RIM_PDU_Indications(false, RIM_PDU_TYPE_SING_REP),</span><br><span> tr_RIM_Protocol_Version_Number(1),</span><br><span style="color: hsl(0, 100%, 40%);">- tru_ApplContainer_or_ApplErrContainer_NACC(tru_ApplContainer_NACC(mp_gb_cfg.bvc[0].cell_id, false, 3, si_expect)),</span><br><span style="color: hsl(120, 100%, 40%);">+ tru_ApplContainer_or_ApplErrContainer_NACC(tru_ApplContainer_NACC(mp_gb_cfg.bvc[0].cell_id, false, 3, si_default)),</span><br><span> omit);</span><br><span> </span><br><span> bssgp_rim_pdu_expect := tr_PDU_BSSGP_RAN_INFORMATION(tr_RIM_Routing_Information(RIM_ADDR_GERAN_CELL_ID, src_addr),</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/22746">change 22746</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/22746"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: osmo-ttcn3-hacks </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I32b7d841bc1fa896f9866c5d7fba857e1ca65ab3 </div>
<div style="display:none"> Gerrit-Change-Number: 22746 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>