<p>fixeria has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/osmo-msc/+/22747">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">fix _gsm48_cc_trans_free(): send MNCC REL.ind on Clear Request<br><br>Change-Id: I3ad4a99757878de3796027325627c87d9a4e93f1<br>Related: SYS#5340<br>---<br>M src/libmsc/gsm_04_08_cc.c<br>1 file changed, 7 insertions(+), 5 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/47/22747/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/libmsc/gsm_04_08_cc.c b/src/libmsc/gsm_04_08_cc.c</span><br><span>index ed29e84..704e596 100644</span><br><span>--- a/src/libmsc/gsm_04_08_cc.c</span><br><span>+++ b/src/libmsc/gsm_04_08_cc.c</span><br><span>@@ -272,6 +272,13 @@</span><br><span> </span><br><span>  /* send release to L4, if callref still exists */</span><br><span>    if (trans->callref) {</span><br><span style="color: hsl(120, 100%, 40%);">+              /* Send MNCC REL.ind (cause='Resource unavailable') */</span><br><span style="color: hsl(120, 100%, 40%);">+                if (trans->cc.mncc_initiated) {</span><br><span style="color: hsl(120, 100%, 40%);">+                    mncc_release_ind(trans->net, trans, trans->callref,</span><br><span style="color: hsl(120, 100%, 40%);">+                                      GSM48_CAUSE_LOC_PRN_S_LU,</span><br><span style="color: hsl(120, 100%, 40%);">+                                     GSM48_CC_CAUSE_RESOURCE_UNAVAIL);</span><br><span style="color: hsl(120, 100%, 40%);">+            }</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span>          /* FIXME: currently, a CC trans that would not yet be in state GSM_CSTATE_RELEASE_REQ fails to send a</span><br><span>                 * CC Release to the MS if it gets freed here. Hack it to do so. */</span><br><span>          if (trans->cc.state != GSM_CSTATE_RELEASE_REQ) {</span><br><span>@@ -280,11 +287,6 @@</span><br><span>                   mncc_set_cause(&rel, GSM48_CAUSE_LOC_PRN_S_LU, GSM48_CC_CAUSE_RESOURCE_UNAVAIL);</span><br><span>                         gsm48_cc_tx_release(trans, &rel);</span><br><span>                }</span><br><span style="color: hsl(0, 100%, 40%);">-               /* Resource unavailable */</span><br><span style="color: hsl(0, 100%, 40%);">-              if (trans->cc.mncc_initiated)</span><br><span style="color: hsl(0, 100%, 40%);">-                        mncc_release_ind(trans->net, trans, trans->callref,</span><br><span style="color: hsl(0, 100%, 40%);">-                                        GSM48_CAUSE_LOC_PRN_S_LU,</span><br><span style="color: hsl(0, 100%, 40%);">-                                       GSM48_CC_CAUSE_RESOURCE_UNAVAIL);</span><br><span>           /* This is a final freeing of the transaction. The MNCC release may have triggered the</span><br><span>                * T308 release timer, but we don't have the luxury of graceful CC Release here. */</span><br><span>              gsm48_stop_cc_timer(trans);</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-msc/+/22747">change 22747</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-msc/+/22747"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-msc </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I3ad4a99757878de3796027325627c87d9a4e93f1 </div>
<div style="display:none"> Gerrit-Change-Number: 22747 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: fixeria <vyanitskiy@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>