<p>pespin <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/22706">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  laforge: Looks good to me, approved
  Jenkins Builder: Verified

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">RLCMAC: Fix decoding of dl data block with no llc block header byte<br><br>The value was marked as unbound while it should be marked as omitted:<br><br>"""<br>dl_block := { data := { cs := CS_1 (0), mac_hdr := { mac_hdr := { payload_type := MAC_PT_RLC_DATA (0), rrbp := RRBP_Nplus13_mod_2715648 (0), rrbp_valid := false, usf := 7 }, hdr_ext := { pr := PWR_RED_0_to_3dB (0), spare := '0'B, tfi := 0, fbi := false, bsn := 0, e := true } }, blocks := { { hdr := <unbound>, payload := '0D0C8653110FFEF072972C5A790C0317299753B5'O } } } } }<br>"""<br><br>Change-Id: If00338729ee1b2c8a4e100495e7cfa0599a4cb8b<br>---<br>M library/RLCMAC_EncDec.cc<br>1 file changed, 4 insertions(+), 0 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/library/RLCMAC_EncDec.cc b/library/RLCMAC_EncDec.cc</span><br><span>index ac60b37..ac22def 100644</span><br><span>--- a/library/RLCMAC_EncDec.cc</span><br><span>+++ b/library/RLCMAC_EncDec.cc</span><br><span>@@ -505,6 +505,7 @@</span><br><span>          /* LI not present: The Upper Layer PDU that starts with the current RLC data block either</span><br><span>             * fills the current RLC data block precisely or continues in the following in-sequence RLC</span><br><span>           * data block */</span><br><span style="color: hsl(120, 100%, 40%);">+              lb.hdr() = OMIT_VALUE;</span><br><span>               lb.payload() = OCTETSTRING(length, ttcn_buffer.get_read_data());</span><br><span>             ttcn_buffer.increase_pos(length);</span><br><span>            ret_val.blocks()[0] = lb;</span><br><span>@@ -663,6 +664,7 @@</span><br><span>              /* LI not present: The Upper Layer PDU that starts with the current RLC data block either</span><br><span>             * fills the current RLC data block precisely or continues in the following in-sequence RLC</span><br><span>           * data block */</span><br><span style="color: hsl(120, 100%, 40%);">+              lb.hdr() = OMIT_VALUE;</span><br><span>               lb.payload() = OCTETSTRING(length, ttcn_buffer.get_read_data());</span><br><span>             aligned_buffer.increase_pos(length);</span><br><span>                 ret_val.blocks()[0] = lb;</span><br><span>@@ -792,6 +794,7 @@</span><br><span>              /* LI not present: The Upper Layer PDU that starts with the current RLC data block either</span><br><span>             * fills the current RLC data block precisely or continues in the following in-sequence RLC</span><br><span>           * data block */</span><br><span style="color: hsl(120, 100%, 40%);">+              lb.hdr() = OMIT_VALUE;</span><br><span>               lb.payload() = OCTETSTRING(length, ttcn_buffer.get_read_data());</span><br><span>             ttcn_buffer.increase_pos(length);</span><br><span>            ret_val.blocks()[0] = lb;</span><br><span>@@ -945,6 +948,7 @@</span><br><span>              /* LI not present: The Upper Layer PDU that starts with the current RLC data block either</span><br><span>             * fills the current RLC data block precisely or continues in the following in-sequence RLC</span><br><span>           * data block */</span><br><span style="color: hsl(120, 100%, 40%);">+              lb.hdr() = OMIT_VALUE;</span><br><span>               lb.payload() = OCTETSTRING(length, aligned_buffer.get_read_data());</span><br><span>          aligned_buffer.increase_pos(length);</span><br><span>                 ret_val.blocks()[0] = lb;</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/22706">change 22706</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/22706"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-ttcn3-hacks </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: If00338729ee1b2c8a4e100495e7cfa0599a4cb8b </div>
<div style="display:none"> Gerrit-Change-Number: 22706 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Reviewer: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>