<p><a href="https://gerrit.osmocom.org/c/libosmocore/+/22742">View Change</a></p><p>4 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.osmocom.org/c/libosmocore/+/22742/3/src/gb/gprs_ns2_sns.c">File src/gb/gprs_ns2_sns.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/libosmocore/+/22742/3/src/gb/gprs_ns2_sns.c@233">Patch Set #3, Line 233:</a> <code style="font-family:monospace,monospace">/*! called when a nsvc is beeing freed or the nsvc is become dead */</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">is become -> became</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/libosmocore/+/22742/3/src/gb/gprs_ns2_sns.c@234">Patch Set #3, Line 234:</a> <code style="font-family:monospace,monospace">void ns2_sns_replace_nsvc(struct gprs_ns2_vc *nsvc)</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">the naming is not descriptive. What about "notify_dead()" instead? since you are adding notify_alive...</p><p style="white-space: pre-wrap; word-wrap: break-word;">btw, why isn't this handled internally I worry?</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/libosmocore/+/22742/3/src/gb/gprs_ns2_sns.c@893">Patch Set #3, Line 893:</a> <code style="font-family:monospace,monospace"> secs = nsi->timeout[NS_TOUT_TNS_ALIVE] * nsi->timeout[NS_TOUT_TNS_ALIVE_RETRIES] ;</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">whitespace " ;"</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/libosmocore/+/22742/3/src/gb/gprs_ns2_sns.c@894">Patch Set #3, Line 894:</a> <code style="font-family:monospace,monospace">        secs *= nsi->timeout[NS_TOUT_TNS_TEST];</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">It looks a bit strange multiplying in 2 steps.</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.osmocom.org/c/libosmocore/+/22742">change 22742</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/libosmocore/+/22742"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: libosmocore </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Ie72da9adeefe0c2850d49a9208b2d0a4556f9101 </div>
<div style="display:none"> Gerrit-Change-Number: 22742 </div>
<div style="display:none"> Gerrit-PatchSet: 3 </div>
<div style="display:none"> Gerrit-Owner: lynxis lazus <lynxis@fe80.eu> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: daniel <dwillmann@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-CC: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-Comment-Date: Fri, 05 Feb 2021 17:21:20 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-Has-Labels: No </div>
<div style="display:none"> Gerrit-MessageType: comment </div>