<p>fixeria <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/osmo-msc/+/22748">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  laforge: Looks good to me, approved
  Jenkins Builder: Verified

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">submit_to_sms(): fix the use of deprecated gsm_septets2octets()<br><br>Change-Id: I9985972f0b1d2b71bfd133c5004201a3a0ffcbd0<br>---<br>M TODO-RELEASE<br>M src/libmsc/smpp_openbsc.c<br>2 files changed, 2 insertions(+), 2 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/TODO-RELEASE b/TODO-RELEASE</span><br><span>index 9c358ae..036a9b9 100644</span><br><span>--- a/TODO-RELEASE</span><br><span>+++ b/TODO-RELEASE</span><br><span>@@ -11,3 +11,4 @@</span><br><span> osmo-msc       Mobile Identity Coding  OsmoMSC is stricter in rejecting invalid coding of Mobile Identity IEs</span><br><span> libmosmo-mgcp-client          needs osmo-mgw.git > 1.7.0 (8667d5169df8d06e10ee3f3104e4cd533d15ac57), ABI break due to struct size in mgcp_conn_peer and mgcp_response</span><br><span> osmo-msc                  update version dependency to version with osmo_fd_*_{disable,enable}</span><br><span style="color: hsl(120, 100%, 40%);">+osmo-msc  smpp            migrate to gsm_septet_pack(), available since Ib1aac538afeb0a5c76a1df472d555139a496e12e</span><br><span>diff --git a/src/libmsc/smpp_openbsc.c b/src/libmsc/smpp_openbsc.c</span><br><span>index a79b252..54cd75b 100644</span><br><span>--- a/src/libmsc/smpp_openbsc.c</span><br><span>+++ b/src/libmsc/smpp_openbsc.c</span><br><span>@@ -250,8 +250,7 @@</span><br><span>                       sms_msg_len -= ud_len;</span><br><span>                       padbits = 7 - (ud_len % 7);</span><br><span>          }</span><br><span style="color: hsl(0, 100%, 40%);">-               gsm_septets2octets(sms->user_data+ud_len, sms_msg,</span><br><span style="color: hsl(0, 100%, 40%);">-                              sms_msg_len, padbits);</span><br><span style="color: hsl(120, 100%, 40%);">+             gsm_septet_pack(sms->user_data+ud_len, sms_msg, sms_msg_len, padbits);</span><br><span>            sms->user_data_len = (ud_len*8 + padbits)/7 + sms_msg_len;/* SEPTETS */</span><br><span>           /* FIXME: sms->text */</span><br><span>    } else {</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-msc/+/22748">change 22748</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-msc/+/22748"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-msc </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I9985972f0b1d2b71bfd133c5004201a3a0ffcbd0 </div>
<div style="display:none"> Gerrit-Change-Number: 22748 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: fixeria <vyanitskiy@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>