<p>laforge <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/osmo-bsc/+/19492">View Change</a></p><div style="white-space:pre-wrap">Approvals:
laforge: Looks good to me, approved
fixeria: Looks good to me, but someone else must approve
pespin: Looks good to me, but someone else must approve
Jenkins Builder: Verified
</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">BS-11: Send proprietary MRPCI message after assignment + HO complete<br><br>This is a non-standard RSL message that must be sent after each traffic<br>channel has been established. Without it, any voice call will be<br>disconnected within seconds.<br><br>This is a hack; we need to store the subscribers classmark2 value and<br>use it here.<br><br>Change-Id: I6cb6d25e405aa888c4df4022d897330a6af9e946<br>Related: OS#2389<br>---<br>M src/osmo-bsc/assignment_fsm.c<br>M src/osmo-bsc/handover_fsm.c<br>2 files changed, 19 insertions(+), 0 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/osmo-bsc/assignment_fsm.c b/src/osmo-bsc/assignment_fsm.c</span><br><span>index 6dba214..e5ef1c5 100644</span><br><span>--- a/src/osmo-bsc/assignment_fsm.c</span><br><span>+++ b/src/osmo-bsc/assignment_fsm.c</span><br><span>@@ -32,6 +32,7 @@</span><br><span> #include <osmocom/bsc/osmo_bsc_lcls.h></span><br><span> #include <osmocom/bsc/bsc_msc_data.h></span><br><span> #include <osmocom/bsc/gsm_08_08.h></span><br><span style="color: hsl(120, 100%, 40%);">+#include <osmocom/bsc/gsm_04_08_rr.h></span><br><span> #include <osmocom/bsc/lchan_select.h></span><br><span> #include <osmocom/bsc/abis_rsl.h></span><br><span> #include <osmocom/bsc/bts.h></span><br><span>@@ -224,10 +225,19 @@</span><br><span> </span><br><span> static void assignment_success(struct gsm_subscriber_connection *conn)</span><br><span> {</span><br><span style="color: hsl(120, 100%, 40%);">+ struct gsm_bts *bts;</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span> /* Take on the new lchan */</span><br><span> gscon_change_primary_lchan(conn, conn->assignment.new_lchan);</span><br><span> conn->assignment.new_lchan = NULL;</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+ bts = conn_get_bts(conn);</span><br><span style="color: hsl(120, 100%, 40%);">+ if (is_siemens_bts(bts) && ts_is_tch(conn->lchan->ts)) {</span><br><span style="color: hsl(120, 100%, 40%);">+ /* HACK: store the actual Classmark 2 LV from the subscriber and use it here! */</span><br><span style="color: hsl(120, 100%, 40%);">+ uint8_t cm2_lv[] = { 0x02, 0x00, 0x00 };</span><br><span style="color: hsl(120, 100%, 40%);">+ send_siemens_mrpci(conn->lchan, cm2_lv);</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span> /* apply LCLS configuration (if any) */</span><br><span> lcls_apply_config(conn);</span><br><span> </span><br><span>diff --git a/src/osmo-bsc/handover_fsm.c b/src/osmo-bsc/handover_fsm.c</span><br><span>index 573f249..b9caf04 100644</span><br><span>--- a/src/osmo-bsc/handover_fsm.c</span><br><span>+++ b/src/osmo-bsc/handover_fsm.c</span><br><span>@@ -937,9 +937,18 @@</span><br><span> LOG_HO(conn, LOGL_INFO, "Result: %s\n", handover_result_name(result));</span><br><span> </span><br><span> if (ho->new_lchan && result == HO_RESULT_OK) {</span><br><span style="color: hsl(120, 100%, 40%);">+ struct gsm_bts *bts;</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span> gscon_change_primary_lchan(conn, conn->ho.new_lchan);</span><br><span> ho->new_lchan = NULL;</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+ bts = conn_get_bts(conn);</span><br><span style="color: hsl(120, 100%, 40%);">+ if (is_siemens_bts(bts) && ts_is_tch(conn->lchan->ts)) {</span><br><span style="color: hsl(120, 100%, 40%);">+ /* HACK: store the actual Classmark 2 LV from the subscriber and use it here! */</span><br><span style="color: hsl(120, 100%, 40%);">+ uint8_t cm2_lv[] = { 0x02, 0x00, 0x00 };</span><br><span style="color: hsl(120, 100%, 40%);">+ send_siemens_mrpci(conn->lchan, cm2_lv);</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span> /* If a Perform Location Request (LCS) is busy, inform the SMLC that there is a new lchan */</span><br><span> if (conn->lcs.loc_req)</span><br><span> osmo_fsm_inst_dispatch(conn->lcs.loc_req->fi, LCS_LOC_REQ_EV_HANDOVER_PERFORMED, NULL);</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-bsc/+/19492">change 19492</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-bsc/+/19492"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: osmo-bsc </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I6cb6d25e405aa888c4df4022d897330a6af9e946 </div>
<div style="display:none"> Gerrit-Change-Number: 19492 </div>
<div style="display:none"> Gerrit-PatchSet: 6 </div>
<div style="display:none"> Gerrit-Owner: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Reviewer: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>