<p>lynxis lazus has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/libosmocore/+/22626">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">gprs_ns2: add bind vty exclude-sns-configuration<br><br>Allow to exclude a udp bind from SNS configuration when<br>connecting to a SGSN.<br><br>Change-Id: Ifb294d449f084c1ea693c7b99f1a65e99f38ea37<br>---<br>M src/gb/gprs_ns2_internal.h<br>M src/gb/gprs_ns2_sns.c<br>M src/gb/gprs_ns2_vty.c<br>3 files changed, 55 insertions(+), 0 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/26/22626/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/gb/gprs_ns2_internal.h b/src/gb/gprs_ns2_internal.h</span><br><span>index 2584a03..fb91395 100644</span><br><span>--- a/src/gb/gprs_ns2_internal.h</span><br><span>+++ b/src/gb/gprs_ns2_internal.h</span><br><span>@@ -253,6 +253,8 @@</span><br><span> </span><br><span> bool accept_ipaccess;</span><br><span> bool accept_sns;</span><br><span style="color: hsl(120, 100%, 40%);">+ /*! if true, this bind will *not* be used when connecting to a SGSN with dynamic configurating IP-SNS */</span><br><span style="color: hsl(120, 100%, 40%);">+ bool exclude_ip_sns_configuration;</span><br><span> </span><br><span> /*! transfer capability in mbit */</span><br><span> int transfer_capability;</span><br><span>diff --git a/src/gb/gprs_ns2_sns.c b/src/gb/gprs_ns2_sns.c</span><br><span>index 427a153..2a934d7 100644</span><br><span>--- a/src/gb/gprs_ns2_sns.c</span><br><span>+++ b/src/gb/gprs_ns2_sns.c</span><br><span>@@ -279,6 +279,9 @@</span><br><span> llist_for_each_entry(bind, &nsi->binding, list) {</span><br><span> if (bind->ll != GPRS_NS2_LL_UDP)</span><br><span> continue;</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ if (!bind->exclude_ip_sns_configuration)</span><br><span style="color: hsl(120, 100%, 40%);">+ continue;</span><br><span> /* ignore failed connection */</span><br><span> nsvc = gprs_ns2_ip_connect_inactive(bind,</span><br><span> remote,</span><br><span>diff --git a/src/gb/gprs_ns2_vty.c b/src/gb/gprs_ns2_vty.c</span><br><span>index 5d0f5c0..af93f44 100644</span><br><span>--- a/src/gb/gprs_ns2_vty.c</span><br><span>+++ b/src/gb/gprs_ns2_vty.c</span><br><span>@@ -66,6 +66,7 @@</span><br><span> int dscp;</span><br><span> bool accept_ipaccess;</span><br><span> bool accept_sns;</span><br><span style="color: hsl(120, 100%, 40%);">+ bool exclude_ip_sns_configuration;</span><br><span> };</span><br><span> </span><br><span> /* TODO: this should into osmo timer */</span><br><span>@@ -325,6 +326,8 @@</span><br><span> }</span><br><span> if (vbind->accept_ipaccess)</span><br><span> vty_out(vty, " accept-ipaccess%s", VTY_NEWLINE);</span><br><span style="color: hsl(120, 100%, 40%);">+ if (vbind->exclude_ip_sns_configuration)</span><br><span style="color: hsl(120, 100%, 40%);">+ vty_out(vty, " exclude-sns-configuration%s", VTY_NEWLINE);</span><br><span> if (vbind->dscp)</span><br><span> vty_out(vty, " dscp %u%s", vbind->dscp, VTY_NEWLINE);</span><br><span> break;</span><br><span>@@ -587,6 +590,51 @@</span><br><span> return CMD_SUCCESS;</span><br><span> }</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+DEFUN(cfg_ns_bind_sns_configuration, cfg_ns_bind_sns_configuration_cmd,</span><br><span style="color: hsl(120, 100%, 40%);">+ "exclude-sns-configuration",</span><br><span style="color: hsl(120, 100%, 40%);">+ "Exclude this bind from SNS configuration when connecting to a SGSN\n"</span><br><span style="color: hsl(120, 100%, 40%);">+ )</span><br><span style="color: hsl(120, 100%, 40%);">+{</span><br><span style="color: hsl(120, 100%, 40%);">+ struct vty_bind *vbind = vty->index;</span><br><span style="color: hsl(120, 100%, 40%);">+ struct gprs_ns2_vc_bind *bind;</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ if (vbind->ll != GPRS_NS2_LL_UDP) {</span><br><span style="color: hsl(120, 100%, 40%);">+ vty_out(vty, "exclude-sns-configuration can be only used with UDP binds%s",</span><br><span style="color: hsl(120, 100%, 40%);">+ VTY_NEWLINE);</span><br><span style="color: hsl(120, 100%, 40%);">+ return CMD_WARNING;</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ vbind->exclude_ip_sns_configuration = true;</span><br><span style="color: hsl(120, 100%, 40%);">+ bind = gprs_ns2_bind_by_name(vty_nsi, vbind->name);</span><br><span style="color: hsl(120, 100%, 40%);">+ if (bind)</span><br><span style="color: hsl(120, 100%, 40%);">+ bind->exclude_ip_sns_configuration = true;</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ return CMD_SUCCESS;</span><br><span style="color: hsl(120, 100%, 40%);">+}</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+DEFUN(cfg_no_ns_bind_sns_configuration, cfg_no_ns_bind_sns_configuration_cmd,</span><br><span style="color: hsl(120, 100%, 40%);">+ "no exclude-sns-configuration",</span><br><span style="color: hsl(120, 100%, 40%);">+ NO_STR</span><br><span style="color: hsl(120, 100%, 40%);">+ "Include this bind from SNS configuration when connecting to a SGSN\n"</span><br><span style="color: hsl(120, 100%, 40%);">+ )</span><br><span style="color: hsl(120, 100%, 40%);">+{</span><br><span style="color: hsl(120, 100%, 40%);">+ struct vty_bind *vbind = vty->index;</span><br><span style="color: hsl(120, 100%, 40%);">+ struct gprs_ns2_vc_bind *bind;</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ if (vbind->ll != GPRS_NS2_LL_UDP) {</span><br><span style="color: hsl(120, 100%, 40%);">+ vty_out(vty, "exclude-sns-configuration can be only used with UDP binds%s",</span><br><span style="color: hsl(120, 100%, 40%);">+ VTY_NEWLINE);</span><br><span style="color: hsl(120, 100%, 40%);">+ return CMD_WARNING;</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ vbind->exclude_ip_sns_configuration = false;</span><br><span style="color: hsl(120, 100%, 40%);">+ bind = gprs_ns2_bind_by_name(vty_nsi, vbind->name);</span><br><span style="color: hsl(120, 100%, 40%);">+ if (bind)</span><br><span style="color: hsl(120, 100%, 40%);">+ bind->exclude_ip_sns_configuration = false;</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ return CMD_SUCCESS;</span><br><span style="color: hsl(120, 100%, 40%);">+}</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span> DEFUN(cfg_no_ns_bind_ipaccess, cfg_no_ns_bind_ipaccess_cmd,</span><br><span> "no accept-ipaccess",</span><br><span> NO_STR</span><br><span>@@ -1688,6 +1736,8 @@</span><br><span> install_lib_element(L_NS_BIND_NODE, &cfg_no_ns_bind_ipaccess_cmd);</span><br><span> install_lib_element(L_NS_BIND_NODE, &cfg_ns_bind_fr_cmd);</span><br><span> install_lib_element(L_NS_BIND_NODE, &cfg_no_ns_bind_fr_cmd);</span><br><span style="color: hsl(120, 100%, 40%);">+ install_lib_element(L_NS_BIND_NODE, &cfg_ns_bind_sns_configuration_cmd);</span><br><span style="color: hsl(120, 100%, 40%);">+ install_lib_element(L_NS_BIND_NODE, &cfg_no_ns_bind_sns_configuration_cmd);</span><br><span> /* TODO: accept-ip-sns when SGSN SNS has been implemented */</span><br><span> </span><br><span> install_node(&ns_nse_node, NULL);</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/libosmocore/+/22626">change 22626</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/libosmocore/+/22626"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: libosmocore </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Ifb294d449f084c1ea693c7b99f1a65e99f38ea37 </div>
<div style="display:none"> Gerrit-Change-Number: 22626 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: lynxis lazus <lynxis@fe80.eu> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>