<p>laforge <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/libosmocore/+/22625">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  laforge: Looks good to me, approved
  Jenkins Builder: Verified

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">gprs_ns2: prevent division by zero in load_sharing<br><br>Check if the NSE is alive before passing UNITDATA to the load sharing.<br><br>Change-Id: I0e2a59bec9b72f74eb64510a2e1ad60486694a55<br>Fixes: OS#4996<br>---<br>M src/gb/gprs_ns2.c<br>1 file changed, 8 insertions(+), 1 deletion(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/gb/gprs_ns2.c b/src/gb/gprs_ns2.c</span><br><span>index 1cf2335..de27fb4 100644</span><br><span>--- a/src/gb/gprs_ns2.c</span><br><span>+++ b/src/gb/gprs_ns2.c</span><br><span>@@ -365,9 +365,13 @@</span><br><span>              uint32_t load_selector)</span><br><span> {</span><br><span>         struct gprs_ns2_vc *tmp;</span><br><span style="color: hsl(0, 100%, 40%);">-        uint32_t mod = (bvci + load_selector) % nse->nsvc_count;</span><br><span style="color: hsl(120, 100%, 40%);">+   uint32_t mod;</span><br><span>        uint32_t i = 0;</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+   if (nse->nsvc_count == 0)</span><br><span style="color: hsl(120, 100%, 40%);">+          return NULL;</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+        mod = (bvci + load_selector) % nse->nsvc_count;</span><br><span>   llist_for_each_entry(tmp, &nse->nsvc, list) {</span><br><span>                 if (!ns2_vc_is_unblocked(tmp))</span><br><span>                       continue;</span><br><span>@@ -457,6 +461,9 @@</span><br><span>      if (!nse)</span><br><span>            return -EINVAL;</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+   if (!nse->alive)</span><br><span style="color: hsl(120, 100%, 40%);">+           return 0;</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span>  nsvc = ns2_load_sharing(nse, bvci, nsp->u.unitdata.link_selector);</span><br><span> </span><br><span>    /* TODO: send a status primitive back */</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/libosmocore/+/22625">change 22625</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/libosmocore/+/22625"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: libosmocore </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I0e2a59bec9b72f74eb64510a2e1ad60486694a55 </div>
<div style="display:none"> Gerrit-Change-Number: 22625 </div>
<div style="display:none"> Gerrit-PatchSet: 4 </div>
<div style="display:none"> Gerrit-Owner: lynxis lazus <lynxis@fe80.eu> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Reviewer: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>