<p>laforge <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/libosmocore/+/22580">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  daniel: Looks good to me, but someone else must approve
  lynxis lazus: Looks good to me, approved
  Jenkins Builder: Verified

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">ns2: Don't start sending NS-RESET until FR DLC is available<br><br>There's no point in sending NS-RESET (or any other) messages to the<br>underlying FR layer if the FR DLC has not been marked as<br>available/active yet.<br><br>Change-Id: Id4e7565ba166ca1d12f8800c643d9f2bc4d66873<br>Closes: OS#4999<br>---<br>M src/gb/gprs_ns2_fr.c<br>1 file changed, 12 insertions(+), 2 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/gb/gprs_ns2_fr.c b/src/gb/gprs_ns2_fr.c</span><br><span>index b5ddf7e..fc6a5c4 100644</span><br><span>--- a/src/gb/gprs_ns2_fr.c</span><br><span>+++ b/src/gb/gprs_ns2_fr.c</span><br><span>@@ -179,6 +179,17 @@</span><br><span>     talloc_free(priv);</span><br><span> }</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+static void fr_dlci_status_cb(struct osmo_fr_dlc *dlc, void *cb_data, bool active)</span><br><span style="color: hsl(120, 100%, 40%);">+{</span><br><span style="color: hsl(120, 100%, 40%);">+    struct gprs_ns2_vc *nsvc = cb_data;</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ if (active) {</span><br><span style="color: hsl(120, 100%, 40%);">+         ns2_vc_fsm_start(nsvc);</span><br><span style="color: hsl(120, 100%, 40%);">+       } else {</span><br><span style="color: hsl(120, 100%, 40%);">+              ns2_vc_force_unconfigured(nsvc);</span><br><span style="color: hsl(120, 100%, 40%);">+      }</span><br><span style="color: hsl(120, 100%, 40%);">+}</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span> static struct priv_vc *fr_alloc_vc(struct gprs_ns2_vc_bind *bind,</span><br><span>                             struct gprs_ns2_vc *nsvc,</span><br><span>                                    uint16_t dlci)</span><br><span>@@ -200,6 +211,7 @@</span><br><span> </span><br><span>  priv->dlc->cb_data = nsvc;</span><br><span>     priv->dlc->rx_cb = fr_dlci_rx_cb;</span><br><span style="color: hsl(120, 100%, 40%);">+       priv->dlc->status_cb = fr_dlci_status_cb;</span><br><span> </span><br><span>  return priv;</span><br><span> }</span><br><span>@@ -899,8 +911,6 @@</span><br><span>      nsvc->nsvci = nsvci;</span><br><span>      nsvc->nsvci_is_valid = true;</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-     ns2_vc_fsm_start(nsvc);</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span>      return nsvc;</span><br><span> </span><br><span> err:</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/libosmocore/+/22580">change 22580</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/libosmocore/+/22580"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: libosmocore </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Id4e7565ba166ca1d12f8800c643d9f2bc4d66873 </div>
<div style="display:none"> Gerrit-Change-Number: 22580 </div>
<div style="display:none"> Gerrit-PatchSet: 5 </div>
<div style="display:none"> Gerrit-Owner: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: daniel <dwillmann@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Reviewer: lynxis lazus <lynxis@fe80.eu> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>