<p>pespin has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/22627">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">WIP: pcu: ACK Pkt Cell Change Continue<br><br>Related: OS#4909<br>Change-Id: I73aaa80e73b2abb06fd0084433122337dc9c4e3f<br>---<br>M pcu/PCU_Tests.ttcn<br>1 file changed, 31 insertions(+), 8 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/27/22627/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/pcu/PCU_Tests.ttcn b/pcu/PCU_Tests.ttcn</span><br><span>index e44e204..1d4e129 100644</span><br><span>--- a/pcu/PCU_Tests.ttcn</span><br><span>+++ b/pcu/PCU_Tests.ttcn</span><br><span>@@ -3597,10 +3597,9 @@</span><br><span>        f_shutdown(__BFILE__, __LINE__, final := true);</span><br><span> }</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-private function f_skip_dummy(integer max_num_iter)</span><br><span style="color: hsl(120, 100%, 40%);">+private function f_skip_dummy(integer max_num_iter, out uint32_t sched_fn)</span><br><span> runs on RAW_PCU_Test_CT return RlcmacDlBlock {</span><br><span>    var RlcmacDlBlock dl_block;</span><br><span style="color: hsl(0, 100%, 40%);">-     var uint32_t sched_fn;</span><br><span>       var integer i := 0;</span><br><span>  while (true) {</span><br><span>               f_rx_rlcmac_dl_block(dl_block, sched_fn);</span><br><span>@@ -3628,7 +3627,7 @@</span><br><span>    var octetstring exp_si_chunk;</span><br><span>        var GlobalTfi gtfi := { is_dl_tfi := false, tfi := ms.ul_tbf.tfi };</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">- dl_block := f_skip_dummy(50);</span><br><span style="color: hsl(120, 100%, 40%);">+ dl_block := f_skip_dummy(50, sched_fn);</span><br><span> </span><br><span>  while (true) {</span><br><span>               var template RlcmacDlCtrlMsg exp_msg; exp_msg :=</span><br><span>@@ -3745,7 +3744,11 @@</span><br><span>            setverdict(fail, "Rx unexpected DL block: ", dl_block);</span><br><span>            f_shutdown(__BFILE__, __LINE__);</span><br><span>     }</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(120, 100%, 40%);">+     /* PKT CELL CHG CONTINUE ACK/NACK sets poll+rrbp requesting PACKET CONTROL ACK */</span><br><span style="color: hsl(120, 100%, 40%);">+     if (dl_block.ctrl.mac_hdr.rrbp_valid) {</span><br><span style="color: hsl(120, 100%, 40%);">+               sched_fn := f_rrbp_ack_fn(sched_fn, dl_block.ctrl.mac_hdr.rrbp);</span><br><span style="color: hsl(120, 100%, 40%);">+              f_ms_tx_ul_block(ms, ts_RLCMAC_CTRL_ACK(ms.tlli), sched_fn);</span><br><span style="color: hsl(120, 100%, 40%);">+  }</span><br><span> }</span><br><span> </span><br><span> /* Verify PCU handles outbound Network Assisted Cell Change Cell Change (NACC, TS 44.060 sec 8.8). */</span><br><span>@@ -3936,11 +3939,16 @@</span><br><span>        f_ms_tx_ul_block(ms, ts_RLC_UL_CTRL_ACK(cell_chf_notif), 0, nr := f_ms_tx_TsTrxBtsNum(ms));</span><br><span> </span><br><span>      /* Wait until we receive something non-dummy */</span><br><span style="color: hsl(0, 100%, 40%);">- dl_block := f_skip_dummy(0);</span><br><span style="color: hsl(120, 100%, 40%);">+  dl_block := f_skip_dummy(0, sched_fn);</span><br><span>       /* Make sure it is a Pkt Cell Chg Continue */</span><br><span>        if (not match(dl_block, tr_RLCMAC_DL_CTRL(?, tr_RlcMacDlCtrl_PKT_CELL_CHG_CONTINUE))) {</span><br><span>              setverdict(fail, "Rx unexpected DL block: ", dl_block);</span><br><span>    }</span><br><span style="color: hsl(120, 100%, 40%);">+     /* PKT CELL CHG CONTINUE ACK/NACK sets poll+rrbp requesting PACKET CONTROL ACK */</span><br><span style="color: hsl(120, 100%, 40%);">+     if (dl_block.ctrl.mac_hdr.rrbp_valid) {</span><br><span style="color: hsl(120, 100%, 40%);">+               sched_fn := f_rrbp_ack_fn(sched_fn, dl_block.ctrl.mac_hdr.rrbp);</span><br><span style="color: hsl(120, 100%, 40%);">+              f_ms_tx_ul_block(ms, ts_RLCMAC_CTRL_ACK(ms.tlli), sched_fn);</span><br><span style="color: hsl(120, 100%, 40%);">+  }</span><br><span> </span><br><span>        f_shutdown(__BFILE__, __LINE__, final := true);</span><br><span> }</span><br><span>@@ -4000,11 +4008,16 @@</span><br><span>       f_ctrl_exp_get(IPA_CTRL, ctrl_var, omit);</span><br><span> </span><br><span>        /* Wait until we receive something non-dummy */</span><br><span style="color: hsl(0, 100%, 40%);">- dl_block := f_skip_dummy(0);</span><br><span style="color: hsl(120, 100%, 40%);">+  dl_block := f_skip_dummy(0, sched_fn);</span><br><span>       /* Make sure it is a Pkt Cell Chg Continue */</span><br><span>        if (not match(dl_block, tr_RLCMAC_DL_CTRL(?, tr_RlcMacDlCtrl_PKT_CELL_CHG_CONTINUE))) {</span><br><span>              setverdict(fail, "Rx unexpected DL block: ", dl_block);</span><br><span>    }</span><br><span style="color: hsl(120, 100%, 40%);">+     /* PKT CELL CHG CONTINUE ACK/NACK sets poll+rrbp requesting PACKET CONTROL ACK */</span><br><span style="color: hsl(120, 100%, 40%);">+     if (dl_block.ctrl.mac_hdr.rrbp_valid) {</span><br><span style="color: hsl(120, 100%, 40%);">+               sched_fn := f_rrbp_ack_fn(sched_fn, dl_block.ctrl.mac_hdr.rrbp);</span><br><span style="color: hsl(120, 100%, 40%);">+              f_ms_tx_ul_block(ms, ts_RLCMAC_CTRL_ACK(ms.tlli), sched_fn);</span><br><span style="color: hsl(120, 100%, 40%);">+  }</span><br><span> </span><br><span>        f_shutdown(__BFILE__, __LINE__, final := true);</span><br><span> }</span><br><span>@@ -4064,11 +4077,16 @@</span><br><span>       f_ctrl_exp_get(IPA_CTRL, ctrl_var, "foobar-error");</span><br><span> </span><br><span>    /* Wait until we receive something non-dummy */</span><br><span style="color: hsl(0, 100%, 40%);">- dl_block := f_skip_dummy(0);</span><br><span style="color: hsl(120, 100%, 40%);">+  dl_block := f_skip_dummy(0, sched_fn);</span><br><span>       /* Make sure it is a Pkt Cell Chg Continue */</span><br><span>        if (not match(dl_block, tr_RLCMAC_DL_CTRL(?, tr_RlcMacDlCtrl_PKT_CELL_CHG_CONTINUE))) {</span><br><span>              setverdict(fail, "Rx unexpected DL block: ", dl_block);</span><br><span>    }</span><br><span style="color: hsl(120, 100%, 40%);">+     /* PKT CELL CHG CONTINUE ACK/NACK sets poll+rrbp requesting PACKET CONTROL ACK */</span><br><span style="color: hsl(120, 100%, 40%);">+     if (dl_block.ctrl.mac_hdr.rrbp_valid) {</span><br><span style="color: hsl(120, 100%, 40%);">+               sched_fn := f_rrbp_ack_fn(sched_fn, dl_block.ctrl.mac_hdr.rrbp);</span><br><span style="color: hsl(120, 100%, 40%);">+              f_ms_tx_ul_block(ms, ts_RLCMAC_CTRL_ACK(ms.tlli), sched_fn);</span><br><span style="color: hsl(120, 100%, 40%);">+  }</span><br><span> </span><br><span>        f_shutdown(__BFILE__, __LINE__, final := true);</span><br><span> }</span><br><span>@@ -4143,11 +4161,16 @@</span><br><span>       /* We never answer the RIM procude -> PCU timeouts and should send Pkt Cell Chg continue */</span><br><span> </span><br><span>   /* Wait until we receive something non-dummy */</span><br><span style="color: hsl(0, 100%, 40%);">- dl_block := f_skip_dummy(0);</span><br><span style="color: hsl(120, 100%, 40%);">+  dl_block := f_skip_dummy(0, sched_fn);</span><br><span>       /* Make sure it is a Pkt Cell Chg Continue */</span><br><span>        if (not match(dl_block, tr_RLCMAC_DL_CTRL(?, tr_RlcMacDlCtrl_PKT_CELL_CHG_CONTINUE))) {</span><br><span>              setverdict(fail, "Rx unexpected DL block: ", dl_block);</span><br><span>    }</span><br><span style="color: hsl(120, 100%, 40%);">+     /* PKT CELL CHG CONTINUE ACK/NACK sets poll+rrbp requesting PACKET CONTROL ACK */</span><br><span style="color: hsl(120, 100%, 40%);">+     if (dl_block.ctrl.mac_hdr.rrbp_valid) {</span><br><span style="color: hsl(120, 100%, 40%);">+               sched_fn := f_rrbp_ack_fn(sched_fn, dl_block.ctrl.mac_hdr.rrbp);</span><br><span style="color: hsl(120, 100%, 40%);">+              f_ms_tx_ul_block(ms, ts_RLCMAC_CTRL_ACK(ms.tlli), sched_fn);</span><br><span style="color: hsl(120, 100%, 40%);">+  }</span><br><span> </span><br><span>        f_shutdown(__BFILE__, __LINE__, final := true);</span><br><span> }</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/22627">change 22627</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/22627"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-ttcn3-hacks </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I73aaa80e73b2abb06fd0084433122337dc9c4e3f </div>
<div style="display:none"> Gerrit-Change-Number: 22627 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>