<p>laforge <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/libosmocore/+/22552">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  Jenkins Builder: Verified
  lynxis lazus: Looks good to me, approved

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">ns2: Log ERROR if we cannot transmit a packet due to ENOBUFS<br><br>Related: OS#4995<br>Change-Id: I2ba64e96c60e23d2e6c8ecdcab0b52b3833f092c<br>---<br>M src/gb/gprs_ns2_fr.c<br>1 file changed, 7 insertions(+), 3 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/gb/gprs_ns2_fr.c b/src/gb/gprs_ns2_fr.c</span><br><span>index f73033b..096e150 100644</span><br><span>--- a/src/gb/gprs_ns2_fr.c</span><br><span>+++ b/src/gb/gprs_ns2_fr.c</span><br><span>@@ -247,11 +247,15 @@</span><br><span> </span><br><span> static int handle_netif_write(struct osmo_fd *ofd, struct msgb *msg)</span><br><span> {</span><br><span style="color: hsl(0, 100%, 40%);">-     int rc = write(ofd->fd, msgb_data(msg), msgb_length(msg));</span><br><span style="color: hsl(120, 100%, 40%);">+ struct gprs_ns2_vc_bind *bind = ofd->data;</span><br><span style="color: hsl(120, 100%, 40%);">+ int rc;</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+     rc = write(ofd->fd, msgb_data(msg), msgb_length(msg));</span><br><span>    /* write_queue expects a "-errno" type return value in case of failure */</span><br><span style="color: hsl(0, 100%, 40%);">-     if (rc == -1)</span><br><span style="color: hsl(120, 100%, 40%);">+ if (rc == -1) {</span><br><span style="color: hsl(120, 100%, 40%);">+               LOGBIND(bind, LOGL_ERROR, "error during write to AF_PACKET: %s\n", strerror(errno));</span><br><span>               return -errno;</span><br><span style="color: hsl(0, 100%, 40%);">-  else</span><br><span style="color: hsl(120, 100%, 40%);">+  } else</span><br><span>               return rc;</span><br><span> }</span><br><span> </span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/libosmocore/+/22552">change 22552</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/libosmocore/+/22552"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: libosmocore </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I2ba64e96c60e23d2e6c8ecdcab0b52b3833f092c </div>
<div style="display:none"> Gerrit-Change-Number: 22552 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: daniel <dwillmann@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Reviewer: lynxis lazus <lynxis@fe80.eu> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>