<p>pespin has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/osmo-pcu/+/22605">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">encoding: Fix comment description of S/P field<br><br>Those fields were ment to be 0 (non-valid), just the comments were<br>copied over from somewhere else, and they are misleading.<br><br>Change-Id: Ic95853e115f60c65f7f11187d49d6e870d08c7bb<br>---<br>M src/encoding.cpp<br>1 file changed, 2 insertions(+), 2 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/05/22605/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/encoding.cpp b/src/encoding.cpp</span><br><span>index a5e7f8a..38bc175 100644</span><br><span>--- a/src/encoding.cpp</span><br><span>+++ b/src/encoding.cpp</span><br><span>@@ -1739,7 +1739,7 @@</span><br><span> </span><br><span>         block->PAYLOAD_TYPE = 0x1;  // RLC/MAC control block that does not include the optional octets of the RLC/MAC control header</span><br><span>      block->RRBP         = 0;  // 0: N+13</span><br><span style="color: hsl(0, 100%, 40%);">- block->SP           = 0; // RRBP field is valid</span><br><span style="color: hsl(120, 100%, 40%);">+    block->SP           = 0; // RRBP field is not valid</span><br><span>       block->USF          = 0x0;  // Uplink state flag</span><br><span> </span><br><span>      block->u.Packet_Neighbour_Cell_Data.MESSAGE_TYPE = MT_PACKET_NEIGHBOUR_CELL_DATA;</span><br><span>@@ -1764,7 +1764,7 @@</span><br><span> </span><br><span>     block->PAYLOAD_TYPE = 0x1;  // RLC/MAC control block that does not include the optional octets of the RLC/MAC control header</span><br><span>      block->RRBP         = 0;  // 0: N+13</span><br><span style="color: hsl(0, 100%, 40%);">- block->SP           = 0; // RRBP field is valid</span><br><span style="color: hsl(120, 100%, 40%);">+    block->SP           = 0; // RRBP field is not valid</span><br><span>       block->USF          = 0x0;  // Uplink state flag</span><br><span> </span><br><span>      block->u.Packet_Cell_Change_Continue.MESSAGE_TYPE = MT_PACKET_CELL_CHANGE_CONTINUE;</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-pcu/+/22605">change 22605</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-pcu/+/22605"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-pcu </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Ic95853e115f60c65f7f11187d49d6e870d08c7bb </div>
<div style="display:none"> Gerrit-Change-Number: 22605 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>