<p>laforge has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/libosmocore/+/22576">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">frame_relay: Discard received messages for DLC not yet active<br><br>If we receive messages for a DLC which has not yet reported as being<br>available by Q.933 LMI, drop the incoming message.  Otherwise we would<br>dispatch it to the user, and the user wants to respond - but then<br>we reject the transmission due to the inactive DLC.<br><br>Change-Id: Ia4a045fdf165b526f429f4617e0fdc76036480bd<br>Related: OS#4999<br>---<br>M src/gb/frame_relay.c<br>1 file changed, 10 insertions(+), 7 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/76/22576/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/gb/frame_relay.c b/src/gb/frame_relay.c</span><br><span>index da7d771..59b26c4 100644</span><br><span>--- a/src/gb/frame_relay.c</span><br><span>+++ b/src/gb/frame_relay.c</span><br><span>@@ -781,19 +781,22 @@</span><br><span>                 goto out;</span><br><span>    }</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-   llist_for_each_entry(dlc, &link->dlc_list, list) {</span><br><span style="color: hsl(0, 100%, 40%);">-               if (dlc->dlci == dlci) {</span><br><span style="color: hsl(120, 100%, 40%);">+   dlc = osmo_fr_dlc_by_dlci(link, dlci);</span><br><span style="color: hsl(120, 100%, 40%);">+        if (dlc) {</span><br><span style="color: hsl(120, 100%, 40%);">+            if (dlc->active) {</span><br><span>                        /* dispatch to handler of respective DLC */</span><br><span>                  msg->dst = dlc;</span><br><span>                   return dlc->rx_cb(dlc->cb_data, msg);</span><br><span style="color: hsl(120, 100%, 40%);">+           } else {</span><br><span style="color: hsl(120, 100%, 40%);">+                      LOGPFRL(link, LOGL_NOTICE, "DLCI %u not yet active, discarding\n", dlci);</span><br><span>          }</span><br><span style="color: hsl(120, 100%, 40%);">+     } else {</span><br><span style="color: hsl(120, 100%, 40%);">+              if (link->unknown_dlc_rx_cb)</span><br><span style="color: hsl(120, 100%, 40%);">+                       return link->unknown_dlc_rx_cb(link->unknown_dlc_rx_cb_data, msg);</span><br><span style="color: hsl(120, 100%, 40%);">+              else</span><br><span style="color: hsl(120, 100%, 40%);">+                  LOGPFRL(link, LOGL_NOTICE, "DLCI %u doesn't exist, discarding\n", dlci);</span><br><span>       }</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-   if (link->unknown_dlc_rx_cb)</span><br><span style="color: hsl(0, 100%, 40%);">-         return link->unknown_dlc_rx_cb(link->unknown_dlc_rx_cb_data, msg);</span><br><span style="color: hsl(0, 100%, 40%);">-        else</span><br><span style="color: hsl(0, 100%, 40%);">-            LOGPFRL(link, LOGL_NOTICE, "DLCI %u doesn't exist, discarding\n", dlci);</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span> out:</span><br><span>       msgb_free(msg);</span><br><span> </span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/libosmocore/+/22576">change 22576</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/libosmocore/+/22576"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: libosmocore </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Ia4a045fdf165b526f429f4617e0fdc76036480bd </div>
<div style="display:none"> Gerrit-Change-Number: 22576 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>