<p>laforge has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/libosmocore/+/22567">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">ns2: Memory allocation failures are ENOMEM, not ENOSPC<br><br>ENOSPC is used with non-volatile (disk) storage, while ENOMEM is<br>customarily used for RAM allocation failures.<br><br>Change-Id: Ia4c16d8278dc30c7cc69169b18428cda5272738d<br>---<br>M src/gb/gprs_ns2.c<br>M src/gb/gprs_ns2_fr.c<br>M src/gb/gprs_ns2_frgre.c<br>M src/gb/gprs_ns2_udp.c<br>4 files changed, 5 insertions(+), 5 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/67/22567/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/gb/gprs_ns2.c b/src/gb/gprs_ns2.c</span><br><span>index 7308e75..f0fa038 100644</span><br><span>--- a/src/gb/gprs_ns2.c</span><br><span>+++ b/src/gb/gprs_ns2.c</span><br><span>@@ -1365,12 +1365,12 @@</span><br><span> </span><br><span>    bind = talloc_zero(nsi, struct gprs_ns2_vc_bind);</span><br><span>    if (!bind)</span><br><span style="color: hsl(0, 100%, 40%);">-              return -ENOSPC;</span><br><span style="color: hsl(120, 100%, 40%);">+               return -ENOMEM;</span><br><span> </span><br><span>  bind->name = talloc_strdup(bind, name);</span><br><span>   if (!bind->name) {</span><br><span>                talloc_free(bind);</span><br><span style="color: hsl(0, 100%, 40%);">-              return -ENOSPC;</span><br><span style="color: hsl(120, 100%, 40%);">+               return -ENOMEM;</span><br><span>      }</span><br><span> </span><br><span>        bind->nsi = nsi;</span><br><span>diff --git a/src/gb/gprs_ns2_fr.c b/src/gb/gprs_ns2_fr.c</span><br><span>index 953f4ca..c32bce8 100644</span><br><span>--- a/src/gb/gprs_ns2_fr.c</span><br><span>+++ b/src/gb/gprs_ns2_fr.c</span><br><span>@@ -738,7 +738,7 @@</span><br><span>       bind->dump_vty = dump_vty;</span><br><span>        priv = bind->priv = talloc_zero(bind, struct priv_bind);</span><br><span>  if (!priv) {</span><br><span style="color: hsl(0, 100%, 40%);">-            rc = -ENOSPC;</span><br><span style="color: hsl(120, 100%, 40%);">+         rc = -ENOMEM;</span><br><span>                goto err_bind;</span><br><span>       }</span><br><span> </span><br><span>diff --git a/src/gb/gprs_ns2_frgre.c b/src/gb/gprs_ns2_frgre.c</span><br><span>index 863f8f2..88ef037 100644</span><br><span>--- a/src/gb/gprs_ns2_frgre.c</span><br><span>+++ b/src/gb/gprs_ns2_frgre.c</span><br><span>@@ -565,7 +565,7 @@</span><br><span>         priv = bind->priv = talloc_zero(bind, struct priv_bind);</span><br><span>  if (!priv) {</span><br><span>                 gprs_ns2_free_bind(bind);</span><br><span style="color: hsl(0, 100%, 40%);">-               return -ENOSPC;</span><br><span style="color: hsl(120, 100%, 40%);">+               return -ENOMEM;</span><br><span>      }</span><br><span>    priv->fd.cb = frgre_fd_cb;</span><br><span>        priv->fd.data = bind;</span><br><span>diff --git a/src/gb/gprs_ns2_udp.c b/src/gb/gprs_ns2_udp.c</span><br><span>index b4bcd01..9277f9a 100644</span><br><span>--- a/src/gb/gprs_ns2_udp.c</span><br><span>+++ b/src/gb/gprs_ns2_udp.c</span><br><span>@@ -341,7 +341,7 @@</span><br><span>      priv = bind->priv = talloc_zero(bind, struct priv_bind);</span><br><span>  if (!priv) {</span><br><span>                 gprs_ns2_free_bind(bind);</span><br><span style="color: hsl(0, 100%, 40%);">-               return -ENOSPC;</span><br><span style="color: hsl(120, 100%, 40%);">+               return -ENOMEM;</span><br><span>      }</span><br><span>    priv->fd.cb = nsip_fd_cb;</span><br><span>         priv->fd.data = bind;</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/libosmocore/+/22567">change 22567</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/libosmocore/+/22567"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: libosmocore </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Ia4c16d8278dc30c7cc69169b18428cda5272738d </div>
<div style="display:none"> Gerrit-Change-Number: 22567 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>