<p>laforge <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/osmo-bsc/+/22518">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  laforge: Looks good to me, approved
  pespin: Looks good to me, but someone else must approve
  Jenkins Builder: Verified

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">stats: Add granularity to chan:rf_fail stat.<br><br>Add additional counters to track TCH and SDCCH RF failures in separate subcategories.<br><br>Change-Id: I91fe6659fe9df33763f4070b4f505561b2005d38<br>---<br>M include/osmocom/bsc/bts.h<br>M src/osmo-bsc/abis_rsl.c<br>M src/osmo-bsc/bts.c<br>3 files changed, 19 insertions(+), 0 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/include/osmocom/bsc/bts.h b/include/osmocom/bsc/bts.h</span><br><span>index 8f3e05b..b81f45f 100644</span><br><span>--- a/include/osmocom/bsc/bts.h</span><br><span>+++ b/include/osmocom/bsc/bts.h</span><br><span>@@ -28,6 +28,8 @@</span><br><span>    BTS_CTR_CHREQ_SUCCESSFUL,</span><br><span>    BTS_CTR_CHREQ_NO_CHANNEL,</span><br><span>    BTS_CTR_CHAN_RF_FAIL,</span><br><span style="color: hsl(120, 100%, 40%);">+ BTS_CTR_CHAN_RF_FAIL_TCH,</span><br><span style="color: hsl(120, 100%, 40%);">+     BTS_CTR_CHAN_RF_FAIL_SDCCH,</span><br><span>  BTS_CTR_CHAN_RLL_ERR,</span><br><span>        BTS_CTR_BTS_OML_FAIL,</span><br><span>        BTS_CTR_BTS_RSL_FAIL,</span><br><span>diff --git a/src/osmo-bsc/abis_rsl.c b/src/osmo-bsc/abis_rsl.c</span><br><span>index 388e2fc..9e00fe7 100644</span><br><span>--- a/src/osmo-bsc/abis_rsl.c</span><br><span>+++ b/src/osmo-bsc/abis_rsl.c</span><br><span>@@ -982,6 +982,17 @@</span><br><span>        LOG_LCHAN(lchan, LOGL_ERROR, "CONNECTION FAIL%s\n", rsl_cause_name(&tp));</span><br><span> </span><br><span>  rate_ctr_inc(&lchan->ts->trx->bts->bts_ctrs->ctr[BTS_CTR_CHAN_RF_FAIL]);</span><br><span style="color: hsl(120, 100%, 40%);">+   switch (lchan->type) {</span><br><span style="color: hsl(120, 100%, 40%);">+     case GSM_LCHAN_SDCCH:</span><br><span style="color: hsl(120, 100%, 40%);">+         rate_ctr_inc(&lchan->ts->trx->bts->bts_ctrs->ctr[BTS_CTR_CHAN_RF_FAIL_SDCCH]);</span><br><span style="color: hsl(120, 100%, 40%);">+             break;</span><br><span style="color: hsl(120, 100%, 40%);">+        case GSM_LCHAN_TCH_H:</span><br><span style="color: hsl(120, 100%, 40%);">+ case GSM_LCHAN_TCH_F:</span><br><span style="color: hsl(120, 100%, 40%);">+         rate_ctr_inc(&lchan->ts->trx->bts->bts_ctrs->ctr[BTS_CTR_CHAN_RF_FAIL_TCH]);</span><br><span style="color: hsl(120, 100%, 40%);">+               break;</span><br><span style="color: hsl(120, 100%, 40%);">+        default:</span><br><span style="color: hsl(120, 100%, 40%);">+              break;</span><br><span style="color: hsl(120, 100%, 40%);">+        }</span><br><span> </span><br><span>        /* If the lchan is associated with a conn, we shall notify the MSC of the RSL Conn Failure, and</span><br><span>       * the connection will presumably be torn down and lead to an lchan release. During initial</span><br><span>diff --git a/src/osmo-bsc/bts.c b/src/osmo-bsc/bts.c</span><br><span>index 3fa4f24..ac0e2af 100644</span><br><span>--- a/src/osmo-bsc/bts.c</span><br><span>+++ b/src/osmo-bsc/bts.c</span><br><span>@@ -791,6 +791,12 @@</span><br><span>      [BTS_CTR_CHAN_RF_FAIL] = \</span><br><span>           { "chan:rf_fail",</span><br><span>            "Received a RF failure indication from BTS" },</span><br><span style="color: hsl(120, 100%, 40%);">+    [BTS_CTR_CHAN_RF_FAIL_TCH] = \</span><br><span style="color: hsl(120, 100%, 40%);">+                { "chan:rf_fail_tch",</span><br><span style="color: hsl(120, 100%, 40%);">+                 "Received a RF failure indication from BTS on a TCH channel" },</span><br><span style="color: hsl(120, 100%, 40%);">+   [BTS_CTR_CHAN_RF_FAIL_SDCCH] = \</span><br><span style="color: hsl(120, 100%, 40%);">+              { "chan:rf_fail_sdcch",</span><br><span style="color: hsl(120, 100%, 40%);">+               "Received a RF failure indication from BTS on an SDCCH channel" },</span><br><span>       [BTS_CTR_CHAN_RLL_ERR] = \</span><br><span>           { "chan:rll_err",</span><br><span>            "Received a RLL failure with T200 cause from BTS" },</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-bsc/+/22518">change 22518</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-bsc/+/22518"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-bsc </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I91fe6659fe9df33763f4070b4f505561b2005d38 </div>
<div style="display:none"> Gerrit-Change-Number: 22518 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: iedemam <michael@kapsulate.com> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Reviewer: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>