<p>laforge has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/libosmocore/+/22551">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">ns2: Use proper return value from write_queue callback function<br><br>write_queue expects a -errno value on error, not '-1'.<br><br>Change-Id: I93c858facfe7e1c533df8dccc4502a574686bc8a<br>Related: OS#4995<br>---<br>M src/gb/gprs_ns2_fr.c<br>1 file changed, 6 insertions(+), 1 deletion(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/51/22551/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/gb/gprs_ns2_fr.c b/src/gb/gprs_ns2_fr.c</span><br><span>index 1c88db6..f73033b 100644</span><br><span>--- a/src/gb/gprs_ns2_fr.c</span><br><span>+++ b/src/gb/gprs_ns2_fr.c</span><br><span>@@ -247,7 +247,12 @@</span><br><span> </span><br><span> static int handle_netif_write(struct osmo_fd *ofd, struct msgb *msg)</span><br><span> {</span><br><span style="color: hsl(0, 100%, 40%);">-  return write(ofd->fd, msgb_data(msg), msgb_length(msg));</span><br><span style="color: hsl(120, 100%, 40%);">+   int rc = write(ofd->fd, msgb_data(msg), msgb_length(msg));</span><br><span style="color: hsl(120, 100%, 40%);">+ /* write_queue expects a "-errno" type return value in case of failure */</span><br><span style="color: hsl(120, 100%, 40%);">+   if (rc == -1)</span><br><span style="color: hsl(120, 100%, 40%);">+         return -errno;</span><br><span style="color: hsl(120, 100%, 40%);">+        else</span><br><span style="color: hsl(120, 100%, 40%);">+          return rc;</span><br><span> }</span><br><span> </span><br><span> /*! determine if given bind is for FR-GRE encapsulation. */</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/libosmocore/+/22551">change 22551</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/libosmocore/+/22551"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: libosmocore </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I93c858facfe7e1c533df8dccc4502a574686bc8a </div>
<div style="display:none"> Gerrit-Change-Number: 22551 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>