<p>keith has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/osmo-hlr/+/22554">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">Fix Coverity Warnings.<br><br>Explicitly check filter_type is not NULL even though the current code<br>never passed NULL filter_type unless filter was also NULL<br><br>Remove unreachable code.<br><br>Change-Id: Ib2bd9b2d6e9e559e61a895a25235669dae05fdf6<br>Related: coverity CID#216865<br>Related: coverity CID#216867<br>---<br>M src/db_hlr.c<br>1 file changed, 3 insertions(+), 7 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-hlr refs/changes/54/22554/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/db_hlr.c b/src/db_hlr.c</span><br><span>index a181c0c..a4c467e 100644</span><br><span>--- a/src/db_hlr.c</span><br><span>+++ b/src/db_hlr.c</span><br><span>@@ -663,7 +663,7 @@</span><br><span>                 return -EIO;</span><br><span>         }</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-   if (filter && strcmp(filter_type, "last_lu_seen") != 0) {</span><br><span style="color: hsl(120, 100%, 40%);">+   if (filter_type && filter && strcmp(filter_type, "last_lu_seen") != 0) {</span><br><span>           if (strcmp(filter, "on") == 0) {</span><br><span>                   sprintf(search, "%s", "1");</span><br><span>              } else if (strcmp(filter, "off") == 0) {</span><br><span>@@ -704,15 +704,11 @@</span><br><span>   db_remove_reset(stmt);</span><br><span>       if (rc != SQLITE_DONE) {</span><br><span>             *err = sqlite3_errmsg(dbc->db);</span><br><span style="color: hsl(0, 100%, 40%);">-              return -EIO;</span><br><span style="color: hsl(0, 100%, 40%);">-    } else if (rc == SQLITE_DONE) {</span><br><span style="color: hsl(0, 100%, 40%);">-         *err = NULL;</span><br><span style="color: hsl(0, 100%, 40%);">-            return 0;</span><br><span style="color: hsl(0, 100%, 40%);">-       } else {</span><br><span style="color: hsl(0, 100%, 40%);">-                *err = sqlite3_errmsg(dbc->db);</span><br><span>           LOGP(DAUC, LOGL_ERROR, "Cannot read subscribers from db:: %s\n", *err);</span><br><span>            return rc;</span><br><span>   }</span><br><span style="color: hsl(120, 100%, 40%);">+     *err = NULL;</span><br><span style="color: hsl(120, 100%, 40%);">+  return 0;</span><br><span> }</span><br><span> </span><br><span> /*! Retrieve subscriber data from the HLR database.</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-hlr/+/22554">change 22554</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-hlr/+/22554"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-hlr </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Ib2bd9b2d6e9e559e61a895a25235669dae05fdf6 </div>
<div style="display:none"> Gerrit-Change-Number: 22554 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: keith <keith@rhizomatica.org> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>