<p>Patch set 2:<span style="border-radius: 3px; display: inline-block; margin: 0 2px; padding: 4px;background-color: #d4ffd4;">Code-Review +1</span></p><p><a href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/22525">View Change</a></p><p>1 comment:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/22525/2/library/Osmocom_Gb_Types.ttcn">File library/Osmocom_Gb_Types.ttcn:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/22525/2/library/Osmocom_Gb_Types.ttcn@2978">Patch Set #2, Line 2978:</a> <code style="font-family:monospace,monospace">          ret.lengthIndicator := { length1 := ? };</code></p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">Formatting is different here. […]</blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">for sure a function has different syntax than a template.  But insid the function you could still have</p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">... ret := {<br>  iEi := '56'O,<br>  ext := '1'B,<br>  lengthIndicator := {<br>    length1 := ?<br>  },<br>  nACC_cause := -,<br>  erroneousApplicationContainer := app_cont<br>}</pre><p style="white-space: pre-wrap; word-wrap: break-word;">and then the if clause that sets nACC_cause to a template or whatever.</p><p style="white-space: pre-wrap; word-wrap: break-word;">I don't really see much advantage either way.</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/22525">change 22525</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/22525"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-ttcn3-hacks </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Ie484f288aa0515ef4df4a3cf7f8a347a3f3cf587 </div>
<div style="display:none"> Gerrit-Change-Number: 22525 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: dexter <pmaier@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: daniel <dwillmann@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Comment-Date: Fri, 29 Jan 2021 08:54:55 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-Has-Labels: Yes </div>
<div style="display:none"> Comment-In-Reply-To: daniel <dwillmann@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: comment </div>