<p>lynxis lazus <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/libosmocore/+/22498">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  daniel: Looks good to me, approved
  pespin: Looks good to me, but someone else must approve
  Jenkins Builder: Verified

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">gprs_ns2: remove api call gprs_ns2_dynamic_create_nse<br><br>The call was only introduced as workaround for the first implementation<br>of vty. There is no need for this anymore. The configuration can<br>just add "accept-ipaccess" to the bind to allow creation of dynamic<br>ipaccess NSE.<br><br>Change-Id: Ie924ead6da17657f3da334068c8ada82c8845495<br>---<br>M include/osmocom/gprs/gprs_ns2.h<br>M src/gb/gprs_ns2.c<br>M src/gb/gprs_ns2_internal.h<br>M src/gb/libosmogb.map<br>M utils/osmo-ns-dummy.c<br>5 files changed, 1 insertion(+), 19 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/include/osmocom/gprs/gprs_ns2.h b/include/osmocom/gprs/gprs_ns2.h</span><br><span>index 24f45c9..042e19b 100644</span><br><span>--- a/include/osmocom/gprs/gprs_ns2.h</span><br><span>+++ b/include/osmocom/gprs/gprs_ns2.h</span><br><span>@@ -142,7 +142,6 @@</span><br><span> /* instance */</span><br><span> struct gprs_ns2_inst *gprs_ns2_instantiate(void *ctx, osmo_prim_cb cb, void *cb_data);</span><br><span> void gprs_ns2_free(struct gprs_ns2_inst *inst);</span><br><span style="color: hsl(0, 100%, 40%);">-int gprs_ns2_dynamic_create_nse(struct gprs_ns2_inst *nsi, bool create_nse);</span><br><span> </span><br><span> /* Entrypoint for primitives from the NS USER */</span><br><span> int gprs_ns2_recv_prim(struct gprs_ns2_inst *nsi, struct osmo_prim_hdr *oph);</span><br><span>diff --git a/src/gb/gprs_ns2.c b/src/gb/gprs_ns2.c</span><br><span>index 7e273fb..be35513 100644</span><br><span>--- a/src/gb/gprs_ns2.c</span><br><span>+++ b/src/gb/gprs_ns2.c</span><br><span>@@ -874,7 +874,7 @@</span><br><span>            if (bind->ll != GPRS_NS2_LL_UDP || dialect != GPRS_NS2_DIALECT_IPACCESS)</span><br><span>                  return NS2_CS_SKIPPED;</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-              if (!bind->nsi->create_nse || !bind->accept_ipaccess)</span><br><span style="color: hsl(120, 100%, 40%);">+                if (!bind->accept_ipaccess)</span><br><span>                       return NS2_CS_SKIPPED;</span><br><span> </span><br><span>           nse = gprs_ns2_create_nse(bind->nsi, nsei, bind->ll, dialect);</span><br><span>@@ -1208,18 +1208,6 @@</span><br><span>        talloc_free(nsi);</span><br><span> }</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-/*! Configure whether a NS Instance should dynamically create NSEs based on incoming traffic.</span><br><span style="color: hsl(0, 100%, 40%);">- *  \param nsi the instance to modify</span><br><span style="color: hsl(0, 100%, 40%);">- *  \param create_nse if NSE can be created on receiving package. SGSN set this.</span><br><span style="color: hsl(0, 100%, 40%);">- *  \return 0 on success; negative on error</span><br><span style="color: hsl(0, 100%, 40%);">- */</span><br><span style="color: hsl(0, 100%, 40%);">-int gprs_ns2_dynamic_create_nse(struct gprs_ns2_inst *nsi, bool create_nse)</span><br><span style="color: hsl(0, 100%, 40%);">-{</span><br><span style="color: hsl(0, 100%, 40%);">-  nsi->create_nse = create_nse;</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">-        return 0;</span><br><span style="color: hsl(0, 100%, 40%);">-}</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span> /*! Start the NS-ALIVE FSM in all NS-VCs of given NSE.</span><br><span>  *  \param[in] nse NS Entity in whihc to start NS-ALIVE FSMs */</span><br><span> void gprs_ns2_start_alive_all_nsvcs(struct gprs_ns2_nse *nse)</span><br><span>diff --git a/src/gb/gprs_ns2_internal.h b/src/gb/gprs_ns2_internal.h</span><br><span>index 027071d..0574cb2 100644</span><br><span>--- a/src/gb/gprs_ns2_internal.h</span><br><span>+++ b/src/gb/gprs_ns2_internal.h</span><br><span>@@ -108,9 +108,6 @@</span><br><span>  /*! linked lists of all NSVC in this instance */</span><br><span>     struct llist_head nse;</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-      /*! create dynamic NSE on receiving packages */</span><br><span style="color: hsl(0, 100%, 40%);">- bool create_nse;</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span>     uint16_t timeout[NS_TIMERS_COUNT];</span><br><span> </span><br><span>       /*! workaround for rate counter until rate counter accepts char str as index */</span><br><span>diff --git a/src/gb/libosmogb.map b/src/gb/libosmogb.map</span><br><span>index fa05b97..71be117 100644</span><br><span>--- a/src/gb/libosmogb.map</span><br><span>+++ b/src/gb/libosmogb.map</span><br><span>@@ -137,7 +137,6 @@</span><br><span> gprs_ns2_bind_by_name;</span><br><span> gprs_ns2_cause_strs;</span><br><span> gprs_ns2_create_nse;</span><br><span style="color: hsl(0, 100%, 40%);">-gprs_ns2_dynamic_create_nse;</span><br><span> gprs_ns2_find_vc_by_sockaddr;</span><br><span> gprs_ns2_free;</span><br><span> gprs_ns2_free_bind;</span><br><span>diff --git a/utils/osmo-ns-dummy.c b/utils/osmo-ns-dummy.c</span><br><span>index 33949d3..5625f75 100644</span><br><span>--- a/utils/osmo-ns-dummy.c</span><br><span>+++ b/utils/osmo-ns-dummy.c</span><br><span>@@ -229,7 +229,6 @@</span><br><span>            exit(1);</span><br><span>     }</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-   gprs_ns2_dynamic_create_nse(nsi, true);</span><br><span>      gprs_ns2_vty_init(nsi);</span><br><span>      rc = vty_read_config_file(config_file, NULL);</span><br><span>        if (rc < 0 && config_given) {</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/libosmocore/+/22498">change 22498</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/libosmocore/+/22498"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: libosmocore </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Ie924ead6da17657f3da334068c8ada82c8845495 </div>
<div style="display:none"> Gerrit-Change-Number: 22498 </div>
<div style="display:none"> Gerrit-PatchSet: 5 </div>
<div style="display:none"> Gerrit-Owner: lynxis lazus <lynxis@fe80.eu> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: daniel <dwillmann@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Reviewer: lynxis lazus <lynxis@fe80.eu> </div>
<div style="display:none"> Gerrit-Reviewer: osmith <osmith@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>