<p>pespin <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/libosmocore/+/22440">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  Jenkins Builder: Verified
  pespin: Looks good to me, approved

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">gprs_bssgp: log source and destination RIM routing information<br><br>Whenever a RIM PDU is received, log to which RIM routing information<br>(address) it is going to and where it is comming from.<br><br>Change-Id: Ia08d3b162a4f6257cccaa7f0764fa7ea498355ef<br>Related: SYS#5103<br>---<br>M src/gb/gprs_bssgp.c<br>M src/gb/gprs_bssgp_util.c<br>2 files changed, 12 insertions(+), 3 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/gb/gprs_bssgp.c b/src/gb/gprs_bssgp.c</span><br><span>index 6fdacce..4154c4b 100644</span><br><span>--- a/src/gb/gprs_bssgp.c</span><br><span>+++ b/src/gb/gprs_bssgp.c</span><br><span>@@ -653,8 +653,8 @@</span><br><span>         uint16_t nsei = msgb_nsei(msg);</span><br><span>      struct bssgp_normal_hdr *bgph = (struct bssgp_normal_hdr *)msgb_bssgph(msg);</span><br><span>         enum bssgp_prim prim;</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">-   DEBUGP(DLBSSGP, "BSSGP BVCI=%u Rx RIM-PDU:%s\n", bvci, bssgp_pdu_str(bgph->pdu_type));</span><br><span style="color: hsl(120, 100%, 40%);">+   char ri_src_str[64];</span><br><span style="color: hsl(120, 100%, 40%);">+  char ri_dest_str[64];</span><br><span> </span><br><span>    /* Specify PRIM type based on the RIM PDU */</span><br><span>         switch (bgph->pdu_type) {</span><br><span>@@ -677,6 +677,10 @@</span><br><span>  nmp.tp = tp;</span><br><span>         if (bssgp_parse_rim_pdu(&nmp.u.rim_pdu, msg) < 0)</span><br><span>             return bssgp_tx_status(BSSGP_CAUSE_MISSING_MAND_IE, NULL, msg);</span><br><span style="color: hsl(120, 100%, 40%);">+       DEBUGP(DLBSSGP, "BSSGP BVCI=%u Rx RIM-PDU:%s, src=%s, dest=%s\n",</span><br><span style="color: hsl(120, 100%, 40%);">+          bvci, bssgp_pdu_str(bgph->pdu_type),</span><br><span style="color: hsl(120, 100%, 40%);">+               bssgp_rim_ri_name_buf(ri_src_str, sizeof(ri_src_str), &nmp.u.rim_pdu.routing_info_src),</span><br><span style="color: hsl(120, 100%, 40%);">+           bssgp_rim_ri_name_buf(ri_dest_str, sizeof(ri_dest_str), &nmp.u.rim_pdu.routing_info_dest));</span><br><span>       osmo_prim_init(&nmp.oph, SAP_BSSGP_RIM, prim, PRIM_OP_INDICATION, msg);</span><br><span>  bssgp_prim_cb(&nmp.oph, NULL);</span><br><span> </span><br><span>diff --git a/src/gb/gprs_bssgp_util.c b/src/gb/gprs_bssgp_util.c</span><br><span>index d93c9df..e00aed9 100644</span><br><span>--- a/src/gb/gprs_bssgp_util.c</span><br><span>+++ b/src/gb/gprs_bssgp_util.c</span><br><span>@@ -594,6 +594,8 @@</span><br><span> {</span><br><span>       struct msgb *msg;</span><br><span>    struct bssgp_normal_hdr *bgph;</span><br><span style="color: hsl(120, 100%, 40%);">+        char ri_src_str[64];</span><br><span style="color: hsl(120, 100%, 40%);">+  char ri_dest_str[64];</span><br><span> </span><br><span>    /* Encode RIM PDU into mesage buffer */</span><br><span>      msg = bssgp_encode_rim_pdu(pdu);</span><br><span>@@ -607,7 +609,10 @@</span><br><span>      msgb_bvci(msg) = 0;     /* Signalling */</span><br><span> </span><br><span>         bgph = (struct bssgp_normal_hdr *)msgb_bssgph(msg);</span><br><span style="color: hsl(0, 100%, 40%);">-     DEBUGP(DLBSSGP, "BSSGP BVCI=0 Tx RIM-PDU:%s\n", bssgp_pdu_str(bgph->pdu_type));</span><br><span style="color: hsl(120, 100%, 40%);">+  DEBUGP(DLBSSGP, "BSSGP BVCI=0 Tx RIM-PDU:%s, src=%s, dest=%s\n",</span><br><span style="color: hsl(120, 100%, 40%);">+           bssgp_pdu_str(bgph->pdu_type),</span><br><span style="color: hsl(120, 100%, 40%);">+             bssgp_rim_ri_name_buf(ri_src_str, sizeof(ri_src_str), &pdu->routing_info_src),</span><br><span style="color: hsl(120, 100%, 40%);">+         bssgp_rim_ri_name_buf(ri_dest_str, sizeof(ri_dest_str), &pdu->routing_info_dest));</span><br><span> </span><br><span>         return bssgp_ns_send(bssgp_ns_send_data, msg);</span><br><span> }</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/libosmocore/+/22440">change 22440</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/libosmocore/+/22440"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: libosmocore </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Ia08d3b162a4f6257cccaa7f0764fa7ea498355ef </div>
<div style="display:none"> Gerrit-Change-Number: 22440 </div>
<div style="display:none"> Gerrit-PatchSet: 4 </div>
<div style="display:none"> Gerrit-Owner: dexter <pmaier@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Reviewer: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>