<p><a href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/22387">View Change</a></p><p>3 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/22387/3/library/GSM_Types.ttcn">File library/GSM_Types.ttcn:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/22387/3/library/GSM_Types.ttcn@425">Patch Set #3, Line 425:</a> <code style="font-family:monospace,monospace">         bcdmccmnc := str2hex(mcc_str[0]) & str2hex(mcc_str[1]) & str2hex(mnc_str[2]) &</code></p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">why not one "mncc_str_hex := str2hex(mncc_str)" above and then avoid calling that function 9 times - […]</blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">I'll try that. TBH I personally find this hexstrings a bit confusing to work with, specially how they get converted from other types, probably because I'm not used to them.</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/22387/3/pcu/PCU_Tests.ttcn">File pcu/PCU_Tests.ttcn:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/22387/3/pcu/PCU_Tests.ttcn@3588">Patch Set #3, Line 3588:</a> </p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;"><pre style="font-family: monospace,monospace; white-space: pre-wrap;">while (true) {<br>         f_rx_rlcmac_dl_block(dl_block, sched_fn);<br>             if (not match(dl_block, tr_RLCMAC_DUMMY_CTRL())) {<br>                    break;<br>                }<br>             if (i > 50) {<br>                      setverdict(fail, "Rx unexpected DL block: ", dl_block);<br>                     f_shutdown(__BFILE__, __LINE__);<br>                      return;<br>               }<br>             i := i + 1;<br>   }<br></pre></blockquote></p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">does it make sense to factor this out into a separate function? something in principle like "wait_fo […]</blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">Fine. These will be removed anyway once I continue with the work to move all this stuff to altsteps.</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/22387/3/pcu/PCU_Tests.ttcn@3609">Patch Set #3, Line 3609:</a> <code style="font-family:monospace,monospace">return</code></p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">I guess that's not needed anywhere after f_shutdown()?</blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">Ack</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/22387">change 22387</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/22387"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-ttcn3-hacks </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I951db4af731e5a7c207f0f407dd78d166e2d3d26 </div>
<div style="display:none"> Gerrit-Change-Number: 22387 </div>
<div style="display:none"> Gerrit-PatchSet: 3 </div>
<div style="display:none"> Gerrit-Owner: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Comment-Date: Wed, 27 Jan 2021 11:25:50 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-Has-Labels: No </div>
<div style="display:none"> Comment-In-Reply-To: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-MessageType: comment </div>