<p style="white-space: pre-wrap; word-wrap: break-word;">I would also add some logging.</p><ul><li>LOGL_DEBUG whenever RIM is received + transmitted?</li><li>LOGL_NOTICE whenever a destination cannot be found?</li></ul><p><a href="https://gerrit.osmocom.org/c/osmo-sgsn/+/22110">View Change</a></p><p>2 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.osmocom.org/c/osmo-sgsn/+/22110/4/src/sgsn/sgsn_rim.c">File src/sgsn/sgsn_rim.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/osmo-sgsn/+/22110/4/src/sgsn/sgsn_rim.c@49">Patch Set #4, Line 49:</a> <code style="font-family:monospace,monospace">            retu</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">shouldn't we return a RIM-ERROR or RIM-APPLICATION-ERROR here?  IMHO RIM is really one layer above/inside BSSGP, so a BSSGP STATUS doesn't look like the best response.</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/osmo-sgsn/+/22110/4/src/sgsn/sgsn_rim.c@54">Patch Set #4, Line 54:</a> <code style="font-family:monospace,monospace">            retu</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">likewise here. Isn't there some RIM specific error we can return indicationg that the destination doesn't exist?</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-sgsn/+/22110">change 22110</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-sgsn/+/22110"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-sgsn </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I6fde8ab8955660b48000ca1b650cfc7c7b2e24ba </div>
<div style="display:none"> Gerrit-Change-Number: 22110 </div>
<div style="display:none"> Gerrit-PatchSet: 4 </div>
<div style="display:none"> Gerrit-Owner: dexter <pmaier@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-CC: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Comment-Date: Fri, 22 Jan 2021 19:57:56 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-Has-Labels: No </div>
<div style="display:none"> Gerrit-MessageType: comment </div>