<p>laforge <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/libosmocore/+/22384">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  laforge: Looks good to me, approved
  pespin: Looks good to me, but someone else must approve
  Jenkins Builder: Verified

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">gprs_bssgp_rim: add value strings for enum bssgp_ran_inf_app_id<br><br>Change-Id: I581d1176f82d6657d6136c32daa9c76dffb802a6<br>Related: SYS#5103<br>---<br>M include/osmocom/gprs/gprs_bssgp_rim.h<br>M src/gb/gprs_bssgp_rim.c<br>M src/gb/libosmogb.map<br>3 files changed, 17 insertions(+), 0 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/include/osmocom/gprs/gprs_bssgp_rim.h b/include/osmocom/gprs/gprs_bssgp_rim.h</span><br><span>index 5e5966e..48bf047 100644</span><br><span>--- a/include/osmocom/gprs/gprs_bssgp_rim.h</span><br><span>+++ b/include/osmocom/gprs/gprs_bssgp_rim.h</span><br><span>@@ -123,6 +123,12 @@</span><br><span>      BSSGP_RAN_INF_APP_ID_UTRA_SI = 5,</span><br><span> };</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+extern const struct value_string bssgp_ran_inf_app_id_strs[];</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+/*! Obtain a human-readable string for RIM Application Identity code */</span><br><span style="color: hsl(120, 100%, 40%);">+static inline const char *bssgp_ran_inf_app_id_str(enum bssgp_ran_inf_app_id val)</span><br><span style="color: hsl(120, 100%, 40%);">+{ return get_value_string(bssgp_ran_inf_app_id_strs, val); }</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span> /* 3GPP TS 48.018, table 11.3.62a.1.b: RAN-INFORMATION-REQUEST RIM Container Contents */</span><br><span> struct bssgp_ran_inf_req_rim_cont {</span><br><span>  enum bssgp_ran_inf_app_id app_id;</span><br><span>diff --git a/src/gb/gprs_bssgp_rim.c b/src/gb/gprs_bssgp_rim.c</span><br><span>index 67e0116..5ef8375 100644</span><br><span>--- a/src/gb/gprs_bssgp_rim.c</span><br><span>+++ b/src/gb/gprs_bssgp_rim.c</span><br><span>@@ -385,6 +385,16 @@</span><br><span>    return buf_ptr;</span><br><span> }</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+/* 3GPP TS 48.018, table 11.3.61.b: RIM Application Identity coding */</span><br><span style="color: hsl(120, 100%, 40%);">+const struct value_string bssgp_ran_inf_app_id_strs[] = {</span><br><span style="color: hsl(120, 100%, 40%);">+   { BSSGP_RAN_INF_APP_ID_NACC,    "Network Assisted Cell Change (NACC)" },</span><br><span style="color: hsl(120, 100%, 40%);">+    { BSSGP_RAN_INF_APP_ID_SI3,     "System Information 3 (SI3)" },</span><br><span style="color: hsl(120, 100%, 40%);">+     { BSSGP_RAN_INF_APP_ID_MBMS,    "MBMS data channel" },</span><br><span style="color: hsl(120, 100%, 40%);">+      { BSSGP_RAN_INF_APP_ID_SON,     "SON Transfer" },</span><br><span style="color: hsl(120, 100%, 40%);">+   { BSSGP_RAN_INF_APP_ID_UTRA_SI, "UTRA System Information (UTRA SI)" },</span><br><span style="color: hsl(120, 100%, 40%);">+      { 0, NULL }</span><br><span style="color: hsl(120, 100%, 40%);">+};</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span> /*! Decode a RAN Information Request RIM Container (3GPP TS 48.018, table 11.3.62a.1.b).</span><br><span>  *  \param[out] user provided memory for decoded data struct.</span><br><span>  *  \param[in] buf user provided memory with the encoded value data of the IE.</span><br><span>diff --git a/src/gb/libosmogb.map b/src/gb/libosmogb.map</span><br><span>index dc9df3a..23d52a2 100644</span><br><span>--- a/src/gb/libosmogb.map</span><br><span>+++ b/src/gb/libosmogb.map</span><br><span>@@ -33,6 +33,7 @@</span><br><span> bssgp_parse_cell_id;</span><br><span> bssgp_parse_rim_pdu;</span><br><span> bssgp_parse_rim_ri;</span><br><span style="color: hsl(120, 100%, 40%);">+bssgp_ran_inf_app_id_strs;</span><br><span> bssgp_set_bssgp_callback;</span><br><span> bssgp_tx_bvc_block;</span><br><span> bssgp_tx_bvc_reset;</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/libosmocore/+/22384">change 22384</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/libosmocore/+/22384"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: libosmocore </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I581d1176f82d6657d6136c32daa9c76dffb802a6 </div>
<div style="display:none"> Gerrit-Change-Number: 22384 </div>
<div style="display:none"> Gerrit-PatchSet: 3 </div>
<div style="display:none"> Gerrit-Owner: dexter <pmaier@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Reviewer: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>