<p>laforge has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/libosmocore/+/22341">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">logging_vty: Fix saving of "logging print file .. last"<br><br>Back in 2018 in I393907b3c9e0cc1145e102328adad0a83ee13a9f Neels<br>introduced "last" as an optional flag to log the file/line number at the<br>end of the line, rather than at the end of the header.  It seems nobody<br>has been usingi this feature, or at least never tried to save a related<br>config file, as there was no code whatsoever that would ever save this<br>optional "last" flag.<br><br>Change-Id: I7b6245256aecc425722242aaabc154ac58ba27a0<br>---<br>M src/vty/logging_vty.c<br>1 file changed, 2 insertions(+), 1 deletion(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/41/22341/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/vty/logging_vty.c b/src/vty/logging_vty.c</span><br><span>index 0282350..6a7a8f4 100644</span><br><span>--- a/src/vty/logging_vty.c</span><br><span>+++ b/src/vty/logging_vty.c</span><br><span>@@ -1010,8 +1010,9 @@</span><br><span>                  tgt->print_timestamp ? 1 : 0, VTY_NEWLINE);</span><br><span>       if (tgt->print_level)</span><br><span>             vty_out(vty, " logging print level 1%s", VTY_NEWLINE);</span><br><span style="color: hsl(0, 100%, 40%);">-        vty_out(vty, " logging print file %s%s",</span><br><span style="color: hsl(120, 100%, 40%);">+    vty_out(vty, " logging print file %s%s%s",</span><br><span>                 get_value_string(logging_print_file_args, tgt->print_filename2),</span><br><span style="color: hsl(120, 100%, 40%);">+           tgt->print_filename_pos == LOG_FILENAME_POS_LINE_END ? " last" : "",</span><br><span>          VTY_NEWLINE);</span><br><span> </span><br><span>    if (tgt->loglevel) {</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/libosmocore/+/22341">change 22341</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/libosmocore/+/22341"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: libosmocore </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I7b6245256aecc425722242aaabc154ac58ba27a0 </div>
<div style="display:none"> Gerrit-Change-Number: 22341 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>