<p>fixeria has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/osmo-trx/+/22350">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">Transceiver: fix integer division in addRadioVector()<br><br>By default, C/C++ compiler does assume integer division.  The<br>lack of explicit cast to 'double' causes the transceiver to<br>ignore non-decimal attenuation values (x % 10 > 0):<br><br>  txFullScale * 10 ^ ( -3 / 10)<br>      == txFullScale * 10 ^ 0<br>       == txFullScale * 1.0<br><br>  txFullScale * 10 ^ ( -8 / 10)<br>       == txFullScale * 10 ^ 0<br>       == txFullScale * 1.0<br><br>  txFullScale * 10 ^ (-10 / 10)<br>       == txFullScale * 10 ^ -1<br>      == txFullScale * 0.1<br><br>  txFullScale * 10 ^ (-18 / 10)<br>       == txFullScale * 10 ^ -1<br>      == txFullScale * 0.1<br><br>Change-Id: I85b1063f57f630d90c6da32827bec4a05afc6514<br>Related: SYS#4918<br>---<br>M Transceiver52M/Transceiver.cpp<br>1 file changed, 1 insertion(+), 1 deletion(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-trx refs/changes/50/22350/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/Transceiver52M/Transceiver.cpp b/Transceiver52M/Transceiver.cpp</span><br><span>index 9c93e98..3188c70 100644</span><br><span>--- a/Transceiver52M/Transceiver.cpp</span><br><span>+++ b/Transceiver52M/Transceiver.cpp</span><br><span>@@ -396,7 +396,7 @@</span><br><span>   else</span><br><span>     burst = modulateBurst(bits, 8 + (wTime.TN() % 4 == 0), cfg->tx_sps);</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-  scaleVector(*burst, txFullScale * pow(10, -RSSI / 10));</span><br><span style="color: hsl(120, 100%, 40%);">+  scaleVector(*burst, txFullScale * pow(10, (double) -RSSI / 10));</span><br><span> </span><br><span>   radio_burst = new radioVector(wTime, burst);</span><br><span> </span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-trx/+/22350">change 22350</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-trx/+/22350"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-trx </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I85b1063f57f630d90c6da32827bec4a05afc6514 </div>
<div style="display:none"> Gerrit-Change-Number: 22350 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: fixeria <vyanitskiy@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>