<p>laforge <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/libosmocore/+/22319">View Change</a></p><div style="white-space:pre-wrap">Approvals:
laforge: Looks good to me, approved
pespin: Looks good to me, but someone else must approve
Jenkins Builder: Verified
</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">gprs_bssgp_rim: Return with EOPNOTSUPP on unsupported containers<br><br>The current version of libosmocore only supports NACC related RIM<br>application containers. If the parser detects a different application<br>container it returns with EINVAL. Unfortunately this means that the<br>caller can not distinguish if there is a lack of support or a real<br>parsing error.<br><br>Change-Id: Ib5ada3554c04259764352888cf95bc4460cb2a54<br>Related: SYS#5103<br>---<br>M src/gb/gprs_bssgp_rim.c<br>1 file changed, 8 insertions(+), 8 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/gb/gprs_bssgp_rim.c b/src/gb/gprs_bssgp_rim.c</span><br><span>index 7094f5f..2096977 100644</span><br><span>--- a/src/gb/gprs_bssgp_rim.c</span><br><span>+++ b/src/gb/gprs_bssgp_rim.c</span><br><span>@@ -405,7 +405,7 @@</span><br><span> case BSSGP_RAN_INF_APP_ID_SON:</span><br><span> case BSSGP_RAN_INF_APP_ID_UTRA_SI:</span><br><span> /* TODO: add parsers for Si3, MBMS, SON, UTRA-SI app containers */</span><br><span style="color: hsl(0, 100%, 40%);">- return -EINVAL;</span><br><span style="color: hsl(120, 100%, 40%);">+ return -EOPNOTSUPP;</span><br><span> default:</span><br><span> return -EINVAL;</span><br><span> }</span><br><span>@@ -475,7 +475,7 @@</span><br><span> case BSSGP_RAN_INF_APP_ID_SON:</span><br><span> case BSSGP_RAN_INF_APP_ID_UTRA_SI:</span><br><span> /* TODO: add encoders for Si3, MBMS, SON, UTRA-SI app containers */</span><br><span style="color: hsl(0, 100%, 40%);">- return -EINVAL;</span><br><span style="color: hsl(120, 100%, 40%);">+ return -EOPNOTSUPP;</span><br><span> default:</span><br><span> return -EINVAL;</span><br><span> }</span><br><span>@@ -528,7 +528,7 @@</span><br><span> case BSSGP_RAN_INF_APP_ID_SON:</span><br><span> case BSSGP_RAN_INF_APP_ID_UTRA_SI:</span><br><span> /* TODO: add parsers for Si3, MBMS, SON, UTRA-SI app containers */</span><br><span style="color: hsl(0, 100%, 40%);">- return -EINVAL;</span><br><span style="color: hsl(120, 100%, 40%);">+ return -EOPNOTSUPP;</span><br><span> default:</span><br><span> return -EINVAL;</span><br><span> }</span><br><span>@@ -547,7 +547,7 @@</span><br><span> case BSSGP_RAN_INF_APP_ID_SON:</span><br><span> case BSSGP_RAN_INF_APP_ID_UTRA_SI:</span><br><span> /* TODO: add parsers for Si3, MBMS, SON, UTRA-SI app containers */</span><br><span style="color: hsl(0, 100%, 40%);">- return -EINVAL;</span><br><span style="color: hsl(120, 100%, 40%);">+ return -EOPNOTSUPP;</span><br><span> default:</span><br><span> return -EINVAL;</span><br><span> }</span><br><span>@@ -594,7 +594,7 @@</span><br><span> case BSSGP_RAN_INF_APP_ID_SON:</span><br><span> case BSSGP_RAN_INF_APP_ID_UTRA_SI:</span><br><span> /* TODO: add encoders for Si3, MBMS, SON, UTRA-SI app containers */</span><br><span style="color: hsl(0, 100%, 40%);">- return -EINVAL;</span><br><span style="color: hsl(120, 100%, 40%);">+ return -EOPNOTSUPP;</span><br><span> default:</span><br><span> return -EINVAL;</span><br><span> }</span><br><span>@@ -613,7 +613,7 @@</span><br><span> case BSSGP_RAN_INF_APP_ID_SON:</span><br><span> case BSSGP_RAN_INF_APP_ID_UTRA_SI:</span><br><span> /* TODO: add encoders for Si3, MBMS, SON, UTRA-SI app containers */</span><br><span style="color: hsl(0, 100%, 40%);">- return -EINVAL;</span><br><span style="color: hsl(120, 100%, 40%);">+ return -EOPNOTSUPP;</span><br><span> default:</span><br><span> return -EINVAL;</span><br><span> }</span><br><span>@@ -810,7 +810,7 @@</span><br><span> case BSSGP_RAN_INF_APP_ID_SON:</span><br><span> case BSSGP_RAN_INF_APP_ID_UTRA_SI:</span><br><span> /* TODO: add parsers for Si3, MBMS, SON, UTRA-SI app containers */</span><br><span style="color: hsl(0, 100%, 40%);">- return -EINVAL;</span><br><span style="color: hsl(120, 100%, 40%);">+ return -EOPNOTSUPP;</span><br><span> default:</span><br><span> return -EINVAL;</span><br><span> }</span><br><span>@@ -849,7 +849,7 @@</span><br><span> case BSSGP_RAN_INF_APP_ID_SON:</span><br><span> case BSSGP_RAN_INF_APP_ID_UTRA_SI:</span><br><span> /* TODO: add encoders for Si3, MBMS, SON, UTRA-SI app containers */</span><br><span style="color: hsl(0, 100%, 40%);">- return -EINVAL;</span><br><span style="color: hsl(120, 100%, 40%);">+ return -EOPNOTSUPP;</span><br><span> default:</span><br><span> return -EINVAL;</span><br><span> }</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/libosmocore/+/22319">change 22319</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/libosmocore/+/22319"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: libosmocore </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Ib5ada3554c04259764352888cf95bc4460cb2a54 </div>
<div style="display:none"> Gerrit-Change-Number: 22319 </div>
<div style="display:none"> Gerrit-PatchSet: 3 </div>
<div style="display:none"> Gerrit-Owner: dexter <pmaier@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Reviewer: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>