<p>neels <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/osmo-bsc/+/22260">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  pespin: Looks good to me, but someone else must approve
  osmith: Looks good to me, approved
  Jenkins Builder: Verified

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">handover_tests.sh: update stdout/stderr only on capital -U arg<br><br>On -u, update the handover_tests.ok file that lists all tests that are<br>expected to run. This is necessary for the regression tests to succeed.<br><br>Update all the numerous test_*.ho_vty.{err,ok} files only when the<br>update arg is a captial -U, because those are usually not interesting,<br>except for manual comparison of test runs.<br><br>Change-Id: Id280a8d084fd84b0b7486a5c8022e5b7a26f6095<br>---<br>M tests/handover/handover_tests.sh<br>1 file changed, 3 insertions(+), 3 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/tests/handover/handover_tests.sh b/tests/handover/handover_tests.sh</span><br><span>index 240b789..4be0c10 100755</span><br><span>--- a/tests/handover/handover_tests.sh</span><br><span>+++ b/tests/handover/handover_tests.sh</span><br><span>@@ -6,7 +6,7 @@</span><br><span> test -d "$tests_dir"</span><br><span> test -d "$build_dir"</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-if [ -n "$update" -a "x$update" != "x-u" ]; then</span><br><span style="color: hsl(120, 100%, 40%);">+if [ -n "$update" -a "x$update" != "x-u" -a "x$update" != "x-U" ]; then</span><br><span>       echo "unknown argument: $update"</span><br><span>   exit 1</span><br><span> fi</span><br><span>@@ -21,7 +21,7 @@</span><br><span>     rc=$?</span><br><span>        expect_out="$test_path.ok"</span><br><span>         expect_err="$test_path.err"</span><br><span style="color: hsl(0, 100%, 40%);">-   if [ "x$rc" = "x0" -a  "x$update" = "x-u" ]; then</span><br><span style="color: hsl(120, 100%, 40%);">+     if [ "x$rc" = "x0" -a  "x$update" = "x-U" ]; then</span><br><span>            cp "$got_out" "$expect_out"</span><br><span>              cp "$got_err" "$expect_err"</span><br><span>      else</span><br><span>@@ -50,7 +50,7 @@</span><br><span> set +e</span><br><span> cat "$results"</span><br><span> failed="$(grep FAIL "$results")"</span><br><span style="color: hsl(0, 100%, 40%);">-if [ -z "$failed" -a "x$update" = "x-u" ]; then</span><br><span style="color: hsl(120, 100%, 40%);">+if [ -z "$failed" -a "x$update" != "x" ]; then</span><br><span>    cp "$results" "$tests_dir"/handover_tests.ok</span><br><span> fi</span><br><span> rm "$results"</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-bsc/+/22260">change 22260</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-bsc/+/22260"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-bsc </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Id280a8d084fd84b0b7486a5c8022e5b7a26f6095 </div>
<div style="display:none"> Gerrit-Change-Number: 22260 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: neels <nhofmeyr@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: neels <nhofmeyr@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: osmith <osmith@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>