<p>daniel has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/22299">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">gbproxy: Use g_parse.sgsn_idx for paging<br><br>The ConnHdlr test stores the sgsn_idx in g_pars. Use that in the paging<br>tests to the correct SGSN pages the MS.<br>This commit fixes what 4332044c missed and is required for the ptp paging<br>reject test to pass.<br><br>Change-Id: Id85ffa57af943ae98c0f022b261ec24d557c236d<br>Related: OS#4951<br>---<br>M gbproxy/GBProxy_Tests.ttcn<br>1 file changed, 11 insertions(+), 11 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/99/22299/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/gbproxy/GBProxy_Tests.ttcn b/gbproxy/GBProxy_Tests.ttcn</span><br><span>index f5248aa..81627f4 100644</span><br><span>--- a/gbproxy/GBProxy_Tests.ttcn</span><br><span>+++ b/gbproxy/GBProxy_Tests.ttcn</span><br><span>@@ -1384,7 +1384,7 @@</span><br><span> {</span><br><span> /* doesn't really make sense: Sending to a single BVCI means the message ends up</span><br><span> * at that BVC (cell) only, and paging all over the BSS area is not possible */</span><br><span style="color: hsl(0, 100%, 40%);">- f_send_paging_ps_exp_one_bss(ts_BssgpP4BssArea, 0, false, 0);</span><br><span style="color: hsl(120, 100%, 40%);">+ f_send_paging_ps_exp_one_bss(ts_BssgpP4BssArea, g_pars.sgsn_idx, false, 0);</span><br><span> }</span><br><span> testcase TC_paging_ps_ptp_bss() runs on test_CT {</span><br><span> f_init();</span><br><span>@@ -1398,7 +1398,7 @@</span><br><span> var template (present) PDU_BSSGP exp_rx;</span><br><span> /* doesn't really make sense: Sending to a single BVCI means the message ends up</span><br><span> * at that BVC (cell) only, and paging all over the BSS area is not possible */</span><br><span style="color: hsl(0, 100%, 40%);">- f_send_paging_ps_exp_one_bss(ts_BssgpP4LAC(pcu_bvc_cfg[0].cell_id.ra_id.lai), 0, false, 0);</span><br><span style="color: hsl(120, 100%, 40%);">+ f_send_paging_ps_exp_one_bss(ts_BssgpP4LAC(pcu_bvc_cfg[0].cell_id.ra_id.lai), g_pars.sgsn_idx, false, 0);</span><br><span> }</span><br><span> testcase TC_paging_ps_ptp_lac() runs on test_CT {</span><br><span> f_init();</span><br><span>@@ -1414,7 +1414,7 @@</span><br><span> lac := 33333</span><br><span> };</span><br><span> /* as it's sent on the PTP BVC, we expect it to pass even for unknown LAC */</span><br><span style="color: hsl(0, 100%, 40%);">- f_send_paging_ps_exp_one_bss(ts_BssgpP4LAC(unknown_la), 0, false, 0);</span><br><span style="color: hsl(120, 100%, 40%);">+ f_send_paging_ps_exp_one_bss(ts_BssgpP4LAC(unknown_la), g_pars.sgsn_idx, false, 0);</span><br><span> }</span><br><span> testcase TC_paging_ps_ptp_lac_unknown() runs on test_CT {</span><br><span> f_init();</span><br><span>@@ -1427,7 +1427,7 @@</span><br><span> {</span><br><span> /* doesn't really make sense: Sending to a single BVCI means the message ends up</span><br><span> * at that BVC (cell) only, and paging all over the BSS area is not possible */</span><br><span style="color: hsl(0, 100%, 40%);">- f_send_paging_ps_exp_one_bss(ts_BssgpP4RAC(pcu_bvc_cfg[0].cell_id.ra_id), 0, false, 0);</span><br><span style="color: hsl(120, 100%, 40%);">+ f_send_paging_ps_exp_one_bss(ts_BssgpP4RAC(pcu_bvc_cfg[0].cell_id.ra_id), g_pars.sgsn_idx, false, 0);</span><br><span> }</span><br><span> testcase TC_paging_ps_ptp_rac() runs on test_CT {</span><br><span> f_init();</span><br><span>@@ -1446,7 +1446,7 @@</span><br><span> rac := 254</span><br><span> };</span><br><span> /* as it's sent on the PTP BVC, we expect it to pass even for unknown RAC */</span><br><span style="color: hsl(0, 100%, 40%);">- f_send_paging_ps_exp_one_bss(ts_BssgpP4RAC(unknown_ra), 0, false, 0);</span><br><span style="color: hsl(120, 100%, 40%);">+ f_send_paging_ps_exp_one_bss(ts_BssgpP4RAC(unknown_ra), g_pars.sgsn_idx, false, 0);</span><br><span> }</span><br><span> testcase TC_paging_ps_ptp_rac_unknown() runs on test_CT {</span><br><span> f_init();</span><br><span>@@ -1458,7 +1458,7 @@</span><br><span> private function f_TC_paging_ps_ptp_bvci(charstring id) runs on BSSGP_ConnHdlr</span><br><span> {</span><br><span> /* this should be the normal case for MS in READY MM state after a lower layer failure */</span><br><span style="color: hsl(0, 100%, 40%);">- f_send_paging_ps_exp_one_bss(ts_BssgpP4Bvci(pcu_bvc_cfg[0].bvci), 0, false, 0);</span><br><span style="color: hsl(120, 100%, 40%);">+ f_send_paging_ps_exp_one_bss(ts_BssgpP4Bvci(pcu_bvc_cfg[0].bvci), g_pars.sgsn_idx, false, 0);</span><br><span> }</span><br><span> testcase TC_paging_ps_ptp_bvci() runs on test_CT {</span><br><span> f_init();</span><br><span>@@ -1485,7 +1485,7 @@</span><br><span> private function f_TC_paging_ps_reject_ptp_bvci(charstring id) runs on BSSGP_ConnHdlr</span><br><span> {</span><br><span> /* first send the PS-PAGING from SGSN -> PCU */</span><br><span style="color: hsl(0, 100%, 40%);">- f_send_paging_ps_exp_one_bss(ts_BssgpP4Bvci(pcu_bvc_cfg[0].bvci), 0, false, 0);</span><br><span style="color: hsl(120, 100%, 40%);">+ f_send_paging_ps_exp_one_bss(ts_BssgpP4Bvci(pcu_bvc_cfg[0].bvci), g_pars.sgsn_idx, false, 0);</span><br><span> /* then simulate the PS-PAGING-REJECT from the PCU */</span><br><span> f_send_paging_ps_rej(use_sig:=false);</span><br><span> }</span><br><span>@@ -1499,7 +1499,7 @@</span><br><span> private function f_TC_paging_ps_ptp_bvci_unknown(charstring id) runs on BSSGP_ConnHdlr</span><br><span> {</span><br><span> /* as it's sent on the PTP BVC, we expect it to pass even for unknown BVCI */</span><br><span style="color: hsl(0, 100%, 40%);">- f_send_paging_ps_exp_one_bss(ts_BssgpP4Bvci(33333), 0, false, 0);</span><br><span style="color: hsl(120, 100%, 40%);">+ f_send_paging_ps_exp_one_bss(ts_BssgpP4Bvci(33333), g_pars.sgsn_idx, false, 0);</span><br><span> }</span><br><span> testcase TC_paging_ps_ptp_bvci_unknown() runs on test_CT {</span><br><span> f_init();</span><br><span>@@ -1659,7 +1659,7 @@</span><br><span> mcc_mnc := '567F99'H,</span><br><span> lac := 33333</span><br><span> };</span><br><span style="color: hsl(0, 100%, 40%);">- f_send_paging_ps_exp_no_bss(ts_BssgpP4LAC(unknown_la), 0, true);</span><br><span style="color: hsl(120, 100%, 40%);">+ f_send_paging_ps_exp_no_bss(ts_BssgpP4LAC(unknown_la), g_pars.sgsn_idx, true);</span><br><span> }</span><br><span> testcase TC_paging_ps_sig_lac_unknown() runs on test_CT {</span><br><span> f_init();</span><br><span>@@ -1696,7 +1696,7 @@</span><br><span> },</span><br><span> rac := 254</span><br><span> };</span><br><span style="color: hsl(0, 100%, 40%);">- f_send_paging_ps_exp_no_bss(ts_BssgpP4RAC(unknown_ra), 0, true);</span><br><span style="color: hsl(120, 100%, 40%);">+ f_send_paging_ps_exp_no_bss(ts_BssgpP4RAC(unknown_ra), g_pars.sgsn_idx, true);</span><br><span> }</span><br><span> testcase TC_paging_ps_sig_rac_unknown() runs on test_CT {</span><br><span> f_init();</span><br><span>@@ -1747,7 +1747,7 @@</span><br><span> /* PS-PAGING on SIG-BVC for unknown BVCI */</span><br><span> private function f_TC_paging_ps_sig_bvci_unknown(charstring id) runs on BSSGP_ConnHdlr</span><br><span> {</span><br><span style="color: hsl(0, 100%, 40%);">- f_send_paging_ps_exp_no_bss(ts_BssgpP4Bvci(33333), 0, true);</span><br><span style="color: hsl(120, 100%, 40%);">+ f_send_paging_ps_exp_no_bss(ts_BssgpP4Bvci(33333), g_pars.sgsn_idx, true);</span><br><span> }</span><br><span> testcase TC_paging_ps_sig_bvci_unknown() runs on test_CT {</span><br><span> f_init();</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/22299">change 22299</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/22299"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: osmo-ttcn3-hacks </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Id85ffa57af943ae98c0f022b261ec24d557c236d </div>
<div style="display:none"> Gerrit-Change-Number: 22299 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: daniel <dwillmann@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>