<p>pespin <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/osmo-pcu/+/22189">View Change</a></p><div style="white-space:pre-wrap">Approvals:
Jenkins Builder: Verified
lynxis lazus: Looks good to me, approved
laforge: Looks good to me, but someone else must approve
</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">tests/tbf: Allocate PCU per test instead of globally<br><br>Otherwise some state may be left from one test to another.<br><br>Change-Id: I18e2fe7dd1cc5940570252a2a6a106de49d8a7dd<br>---<br>M tests/tbf/TbfTest.cpp<br>1 file changed, 58 insertions(+), 33 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/tests/tbf/TbfTest.cpp b/tests/tbf/TbfTest.cpp</span><br><span>index 75b51bf..66e344e 100644</span><br><span>--- a/tests/tbf/TbfTest.cpp</span><br><span>+++ b/tests/tbf/TbfTest.cpp</span><br><span>@@ -91,6 +91,7 @@</span><br><span> </span><br><span> static void test_tbf_tlli_update()</span><br><span> {</span><br><span style="color: hsl(120, 100%, 40%);">+ the_pcu = gprs_pcu_alloc(tall_pcu_ctx);</span><br><span> the_pcu->bts = bts_alloc(the_pcu);</span><br><span> BTS *the_bts = the_pcu->bts;</span><br><span> GprsMs *ms, *ms_new;</span><br><span>@@ -155,7 +156,7 @@</span><br><span> OSMO_ASSERT(dl_tbf->ta() == 6);</span><br><span> </span><br><span> fprintf(stderr, "=== end %s ===\n", __func__);</span><br><span style="color: hsl(0, 100%, 40%);">- TALLOC_FREE(the_pcu->bts);</span><br><span style="color: hsl(120, 100%, 40%);">+ TALLOC_FREE(the_pcu);</span><br><span> }</span><br><span> </span><br><span> static uint8_t llc_data[200];</span><br><span>@@ -253,6 +254,7 @@</span><br><span> </span><br><span> static void test_tbf_final_ack(enum test_tbf_final_ack_mode test_mode)</span><br><span> {</span><br><span style="color: hsl(120, 100%, 40%);">+ the_pcu = gprs_pcu_alloc(tall_pcu_ctx);</span><br><span> the_pcu->bts = bts_alloc(the_pcu);</span><br><span> BTS *the_bts = the_pcu->bts;</span><br><span> uint8_t ts_no = 4;</span><br><span>@@ -324,7 +326,7 @@</span><br><span> ms_unref(ms);</span><br><span> }</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">- TALLOC_FREE(the_pcu->bts);</span><br><span style="color: hsl(120, 100%, 40%);">+ TALLOC_FREE(the_pcu);</span><br><span> fprintf(stderr, "=== end %s ===\n", __func__);</span><br><span> }</span><br><span> </span><br><span>@@ -338,6 +340,7 @@</span><br><span> </span><br><span> static void test_tbf_delayed_release()</span><br><span> {</span><br><span style="color: hsl(120, 100%, 40%);">+ the_pcu = gprs_pcu_alloc(tall_pcu_ctx);</span><br><span> the_pcu->bts = bts_alloc(the_pcu);</span><br><span> BTS *the_bts = the_pcu->bts;</span><br><span> uint8_t ts_no = 4;</span><br><span>@@ -402,12 +405,13 @@</span><br><span> TBF_SET_ASS_STATE_DL(dl_tbf, GPRS_RLCMAC_DL_ASS_NONE);</span><br><span> check_tbf(dl_tbf);</span><br><span> tbf_free(dl_tbf);</span><br><span style="color: hsl(0, 100%, 40%);">- TALLOC_FREE(the_pcu->bts);</span><br><span style="color: hsl(120, 100%, 40%);">+ TALLOC_FREE(the_pcu);</span><br><span> fprintf(stderr, "=== end %s ===\n", __func__);</span><br><span> }</span><br><span> </span><br><span> static void test_tbf_imsi()</span><br><span> {</span><br><span style="color: hsl(120, 100%, 40%);">+ the_pcu = gprs_pcu_alloc(tall_pcu_ctx);</span><br><span> the_pcu->bts = bts_alloc(the_pcu);</span><br><span> BTS *the_bts = the_pcu->bts;</span><br><span> uint8_t ts_no = 4;</span><br><span>@@ -463,12 +467,13 @@</span><br><span> ms1 = the_bts->ms_store().get_ms(0, 0, "001001000000002");</span><br><span> OSMO_ASSERT(ms1 == NULL);</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">- TALLOC_FREE(the_pcu->bts);</span><br><span style="color: hsl(120, 100%, 40%);">+ TALLOC_FREE(the_pcu);</span><br><span> fprintf(stderr, "=== end %s ===\n", __func__);</span><br><span> }</span><br><span> </span><br><span> static void test_tbf_exhaustion()</span><br><span> {</span><br><span style="color: hsl(120, 100%, 40%);">+ the_pcu = gprs_pcu_alloc(tall_pcu_ctx);</span><br><span> the_pcu->bts = bts_alloc(the_pcu);</span><br><span> BTS *the_bts = the_pcu->bts;</span><br><span> gprs_rlcmac_bts *bts;</span><br><span>@@ -509,11 +514,12 @@</span><br><span> fprintf(stderr, "=== end %s ===\n", __func__);</span><br><span> </span><br><span> gprs_bssgp_destroy(bts);</span><br><span style="color: hsl(0, 100%, 40%);">- TALLOC_FREE(the_pcu->bts);</span><br><span style="color: hsl(120, 100%, 40%);">+ TALLOC_FREE(the_pcu);</span><br><span> }</span><br><span> </span><br><span> static void test_tbf_dl_llc_loss()</span><br><span> {</span><br><span style="color: hsl(120, 100%, 40%);">+ the_pcu = gprs_pcu_alloc(tall_pcu_ctx);</span><br><span> the_pcu->bts = bts_alloc(the_pcu);</span><br><span> BTS *the_bts = the_pcu->bts;</span><br><span> gprs_rlcmac_bts *bts;</span><br><span>@@ -596,7 +602,7 @@</span><br><span> fprintf(stderr, "=== end %s ===\n", __func__);</span><br><span> </span><br><span> gprs_bssgp_destroy(bts);</span><br><span style="color: hsl(0, 100%, 40%);">- TALLOC_FREE(the_pcu->bts);</span><br><span style="color: hsl(120, 100%, 40%);">+ TALLOC_FREE(the_pcu);</span><br><span> }</span><br><span> </span><br><span> static gprs_rlcmac_ul_tbf *establish_ul_tbf_single_phase(BTS *the_bts,</span><br><span>@@ -1709,6 +1715,7 @@</span><br><span> </span><br><span> static void test_tbf_single_phase()</span><br><span> {</span><br><span style="color: hsl(120, 100%, 40%);">+ the_pcu = gprs_pcu_alloc(tall_pcu_ctx);</span><br><span> the_pcu->bts = bts_alloc(the_pcu);</span><br><span> BTS *the_bts = the_pcu->bts;</span><br><span> int ts_no = 7;</span><br><span>@@ -1728,11 +1735,12 @@</span><br><span> send_dl_data(the_bts, tlli, imsi, (const uint8_t *)"TEST", 4);</span><br><span> </span><br><span> fprintf(stderr, "=== end %s ===\n", __func__);</span><br><span style="color: hsl(0, 100%, 40%);">- TALLOC_FREE(the_pcu->bts);</span><br><span style="color: hsl(120, 100%, 40%);">+ TALLOC_FREE(the_pcu);</span><br><span> }</span><br><span> </span><br><span> static void test_tbf_egprs_two_phase_puan(void)</span><br><span> {</span><br><span style="color: hsl(120, 100%, 40%);">+ the_pcu = gprs_pcu_alloc(tall_pcu_ctx);</span><br><span> the_pcu->bts = bts_alloc(the_pcu);</span><br><span> BTS *the_bts = the_pcu->bts;</span><br><span> int ts_no = 7;</span><br><span>@@ -1782,7 +1790,7 @@</span><br><span> print_ta_tlli(ul_tbf, true);</span><br><span> send_dl_data(the_bts, tlli, imsi, test_data, sizeof(test_data));</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">- TALLOC_FREE(the_pcu->bts);</span><br><span style="color: hsl(120, 100%, 40%);">+ TALLOC_FREE(the_pcu);</span><br><span> fprintf(stderr, "=== end %s ===\n", __func__);</span><br><span> }</span><br><span> /*</span><br><span>@@ -1790,6 +1798,7 @@</span><br><span> */</span><br><span> static void test_immediate_assign_rej_single_block()</span><br><span> {</span><br><span style="color: hsl(120, 100%, 40%);">+ the_pcu = gprs_pcu_alloc(tall_pcu_ctx);</span><br><span> the_pcu->bts = bts_alloc(the_pcu);</span><br><span> BTS *the_bts = the_pcu->bts;</span><br><span> uint32_t fn = 2654218;</span><br><span>@@ -1814,7 +1823,7 @@</span><br><span> </span><br><span> OSMO_ASSERT(rc == -EINVAL);</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">- TALLOC_FREE(the_pcu->bts);</span><br><span style="color: hsl(120, 100%, 40%);">+ TALLOC_FREE(the_pcu);</span><br><span> fprintf(stderr, "=== end %s ===\n", __func__);</span><br><span> }</span><br><span> </span><br><span>@@ -1823,6 +1832,7 @@</span><br><span> */</span><br><span> static void test_immediate_assign_rej_multi_block()</span><br><span> {</span><br><span style="color: hsl(120, 100%, 40%);">+ the_pcu = gprs_pcu_alloc(tall_pcu_ctx);</span><br><span> the_pcu->bts = bts_alloc(the_pcu);</span><br><span> BTS *the_bts = the_pcu->bts;</span><br><span> uint32_t fn = 2654218;</span><br><span>@@ -1852,7 +1862,7 @@</span><br><span> </span><br><span> OSMO_ASSERT(rc == -EBUSY);</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">- TALLOC_FREE(the_pcu->bts);</span><br><span style="color: hsl(120, 100%, 40%);">+ TALLOC_FREE(the_pcu);</span><br><span> fprintf(stderr, "=== end %s ===\n", __func__);</span><br><span> }</span><br><span> </span><br><span>@@ -1864,6 +1874,7 @@</span><br><span> </span><br><span> static void test_tbf_two_phase()</span><br><span> {</span><br><span style="color: hsl(120, 100%, 40%);">+ the_pcu = gprs_pcu_alloc(tall_pcu_ctx);</span><br><span> the_pcu->bts = bts_alloc(the_pcu);</span><br><span> BTS *the_bts = the_pcu->bts;</span><br><span> int ts_no = 7;</span><br><span>@@ -1884,7 +1895,7 @@</span><br><span> print_ta_tlli(ul_tbf, true);</span><br><span> send_dl_data(the_bts, tlli, imsi, (const uint8_t *)"TEST", 4);</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">- TALLOC_FREE(the_pcu->bts);</span><br><span style="color: hsl(120, 100%, 40%);">+ TALLOC_FREE(the_pcu);</span><br><span> fprintf(stderr, "=== end %s ===\n", __func__);</span><br><span> }</span><br><span> </span><br><span>@@ -1896,6 +1907,7 @@</span><br><span> </span><br><span> static void test_tbf_ra_update_rach()</span><br><span> {</span><br><span style="color: hsl(120, 100%, 40%);">+ the_pcu = gprs_pcu_alloc(tall_pcu_ctx);</span><br><span> the_pcu->bts = bts_alloc(the_pcu);</span><br><span> BTS *the_bts = the_pcu->bts;</span><br><span> int ts_no = 7;</span><br><span>@@ -1956,12 +1968,13 @@</span><br><span> ms = the_bts->ms_by_tlli(tlli2);</span><br><span> OSMO_ASSERT(ms == ms2);</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">- TALLOC_FREE(the_pcu->bts);</span><br><span style="color: hsl(120, 100%, 40%);">+ TALLOC_FREE(the_pcu);</span><br><span> fprintf(stderr, "=== end %s ===\n", __func__);</span><br><span> }</span><br><span> </span><br><span> static void test_tbf_dl_flow_and_rach_two_phase()</span><br><span> {</span><br><span style="color: hsl(120, 100%, 40%);">+ the_pcu = gprs_pcu_alloc(tall_pcu_ctx);</span><br><span> the_pcu->bts = bts_alloc(the_pcu);</span><br><span> BTS *the_bts = the_pcu->bts;</span><br><span> int ts_no = 7;</span><br><span>@@ -2016,13 +2029,14 @@</span><br><span> /* No queued packets should be lost */</span><br><span> OSMO_ASSERT(llc_queue_size(ms_llc_queue(ms)) == 2);</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">- TALLOC_FREE(the_pcu->bts);</span><br><span style="color: hsl(120, 100%, 40%);">+ TALLOC_FREE(the_pcu);</span><br><span> fprintf(stderr, "=== end %s ===\n", __func__);</span><br><span> }</span><br><span> </span><br><span> </span><br><span> static void test_tbf_dl_flow_and_rach_single_phase()</span><br><span> {</span><br><span style="color: hsl(120, 100%, 40%);">+ the_pcu = gprs_pcu_alloc(tall_pcu_ctx);</span><br><span> the_pcu->bts = bts_alloc(the_pcu);</span><br><span> BTS *the_bts = the_pcu->bts;</span><br><span> int ts_no = 7;</span><br><span>@@ -2077,12 +2091,13 @@</span><br><span> /* No queued packets should be lost */</span><br><span> OSMO_ASSERT(llc_queue_size(ms_llc_queue(ms)) == 2);</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">- TALLOC_FREE(the_pcu->bts);</span><br><span style="color: hsl(120, 100%, 40%);">+ TALLOC_FREE(the_pcu);</span><br><span> fprintf(stderr, "=== end %s ===\n", __func__);</span><br><span> }</span><br><span> </span><br><span> static void test_tbf_dl_reuse()</span><br><span> {</span><br><span style="color: hsl(120, 100%, 40%);">+ the_pcu = gprs_pcu_alloc(tall_pcu_ctx);</span><br><span> the_pcu->bts = bts_alloc(the_pcu);</span><br><span> BTS *the_bts = the_pcu->bts;</span><br><span> int ts_no = 7;</span><br><span>@@ -2177,12 +2192,13 @@</span><br><span> OSMO_ASSERT(ms_dl_tbf(ms2));</span><br><span> OSMO_ASSERT(ms_dl_tbf(ms2)->state_is(GPRS_RLCMAC_FINISHED));</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">- TALLOC_FREE(the_pcu->bts);</span><br><span style="color: hsl(120, 100%, 40%);">+ TALLOC_FREE(the_pcu);</span><br><span> fprintf(stderr, "=== end %s ===\n", __func__);</span><br><span> }</span><br><span> </span><br><span> static void test_tbf_gprs_egprs()</span><br><span> {</span><br><span style="color: hsl(120, 100%, 40%);">+ the_pcu = gprs_pcu_alloc(tall_pcu_ctx);</span><br><span> the_pcu->bts = bts_alloc(the_pcu);</span><br><span> BTS *the_bts = the_pcu->bts;</span><br><span> gprs_rlcmac_bts *bts;</span><br><span>@@ -2218,7 +2234,7 @@</span><br><span> fprintf(stderr, "=== end %s ===\n", __func__);</span><br><span> </span><br><span> gprs_bssgp_destroy(bts);</span><br><span style="color: hsl(0, 100%, 40%);">- TALLOC_FREE(the_pcu->bts);</span><br><span style="color: hsl(120, 100%, 40%);">+ TALLOC_FREE(the_pcu);</span><br><span> }</span><br><span> </span><br><span> static inline void ws_check(gprs_rlcmac_dl_tbf *dl_tbf, const char *test, uint8_t exp_slots, uint16_t exp_ws,</span><br><span>@@ -2252,6 +2268,7 @@</span><br><span> </span><br><span> static void test_tbf_ws()</span><br><span> {</span><br><span style="color: hsl(120, 100%, 40%);">+ the_pcu = gprs_pcu_alloc(tall_pcu_ctx);</span><br><span> the_pcu->bts = bts_alloc(the_pcu);</span><br><span> BTS *the_bts = the_pcu->bts;</span><br><span> gprs_rlcmac_bts *bts;</span><br><span>@@ -2294,11 +2311,12 @@</span><br><span> dl_tbf = tbf_alloc_dl_tbf(bts, ms, 0, false);</span><br><span> </span><br><span> ws_check(dl_tbf, __func__, 4, 128 + 4 * 64, true, true);</span><br><span style="color: hsl(0, 100%, 40%);">- TALLOC_FREE(the_pcu->bts);</span><br><span style="color: hsl(120, 100%, 40%);">+ TALLOC_FREE(the_pcu);</span><br><span> }</span><br><span> </span><br><span> static void test_tbf_update_ws(void)</span><br><span> {</span><br><span style="color: hsl(120, 100%, 40%);">+ the_pcu = gprs_pcu_alloc(tall_pcu_ctx);</span><br><span> the_pcu->bts = bts_alloc(the_pcu);</span><br><span> BTS *the_bts = the_pcu->bts;</span><br><span> gprs_rlcmac_bts *bts;</span><br><span>@@ -2340,11 +2358,12 @@</span><br><span> </span><br><span> /* window size should be 384 */</span><br><span> ws_check(dl_tbf, __func__, 4, 128 + 4 * 64, true, true);</span><br><span style="color: hsl(0, 100%, 40%);">- TALLOC_FREE(the_pcu->bts);</span><br><span style="color: hsl(120, 100%, 40%);">+ TALLOC_FREE(the_pcu);</span><br><span> }</span><br><span> </span><br><span> static void test_tbf_puan_urbb_len(void)</span><br><span> {</span><br><span style="color: hsl(120, 100%, 40%);">+ the_pcu = gprs_pcu_alloc(tall_pcu_ctx);</span><br><span> the_pcu->bts = bts_alloc(the_pcu);</span><br><span> BTS *the_bts = the_pcu->bts;</span><br><span> int ts_no = 7;</span><br><span>@@ -2370,7 +2389,7 @@</span><br><span> print_ta_tlli(ul_tbf, true);</span><br><span> send_dl_data(the_bts, tlli, imsi, test_data, sizeof(test_data));</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">- TALLOC_FREE(the_pcu->bts);</span><br><span style="color: hsl(120, 100%, 40%);">+ TALLOC_FREE(the_pcu);</span><br><span> fprintf(stderr, "=== end %s ===\n", __func__);</span><br><span> }</span><br><span> </span><br><span>@@ -2487,6 +2506,7 @@</span><br><span> </span><br><span> static void test_tbf_li_decoding(void)</span><br><span> {</span><br><span style="color: hsl(120, 100%, 40%);">+ the_pcu = gprs_pcu_alloc(tall_pcu_ctx);</span><br><span> the_pcu->bts = bts_alloc(the_pcu);</span><br><span> BTS *the_bts = the_pcu->bts;</span><br><span> int ts_no = 7;</span><br><span>@@ -2512,7 +2532,7 @@</span><br><span> print_ta_tlli(ul_tbf, true);</span><br><span> send_dl_data(the_bts, tlli, imsi, test_data, sizeof(test_data));</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">- TALLOC_FREE(the_pcu->bts);</span><br><span style="color: hsl(120, 100%, 40%);">+ TALLOC_FREE(the_pcu);</span><br><span> fprintf(stderr, "=== end %s ===\n", __func__);</span><br><span> }</span><br><span> </span><br><span>@@ -2523,6 +2543,7 @@</span><br><span> */</span><br><span> static void test_tbf_epdan_out_of_rx_window(void)</span><br><span> {</span><br><span style="color: hsl(120, 100%, 40%);">+ the_pcu = gprs_pcu_alloc(tall_pcu_ctx);</span><br><span> the_pcu->bts = bts_alloc(the_pcu);</span><br><span> BTS *the_bts = the_pcu->bts;</span><br><span> uint8_t ms_class = 11;</span><br><span>@@ -2608,12 +2629,13 @@</span><br><span> </span><br><span> bitvec_free(block);</span><br><span> tbf_free(dl_tbf);</span><br><span style="color: hsl(0, 100%, 40%);">- TALLOC_FREE(the_pcu->bts);</span><br><span style="color: hsl(120, 100%, 40%);">+ TALLOC_FREE(the_pcu);</span><br><span> fprintf(stderr, "=== end %s ===\n", __func__);</span><br><span> }</span><br><span> </span><br><span> static void test_tbf_egprs_two_phase_spb(void)</span><br><span> {</span><br><span style="color: hsl(120, 100%, 40%);">+ the_pcu = gprs_pcu_alloc(tall_pcu_ctx);</span><br><span> the_pcu->bts = bts_alloc(the_pcu);</span><br><span> BTS *the_bts = the_pcu->bts;</span><br><span> int ts_no = 7;</span><br><span>@@ -2639,12 +2661,13 @@</span><br><span> print_ta_tlli(ul_tbf, true);</span><br><span> send_dl_data(the_bts, tlli, imsi, test_data, sizeof(test_data));</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">- TALLOC_FREE(the_pcu->bts);</span><br><span style="color: hsl(120, 100%, 40%);">+ TALLOC_FREE(the_pcu);</span><br><span> fprintf(stderr, "=== end %s ===\n", __func__);</span><br><span> }</span><br><span> </span><br><span> static void test_tbf_egprs_two_phase()</span><br><span> {</span><br><span style="color: hsl(120, 100%, 40%);">+ the_pcu = gprs_pcu_alloc(tall_pcu_ctx);</span><br><span> the_pcu->bts = bts_alloc(the_pcu);</span><br><span> BTS *the_bts = the_pcu->bts;</span><br><span> int ts_no = 7;</span><br><span>@@ -2670,7 +2693,7 @@</span><br><span> print_ta_tlli(ul_tbf, true);</span><br><span> send_dl_data(the_bts, tlli, imsi, test_data, sizeof(test_data));</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">- TALLOC_FREE(the_pcu->bts);</span><br><span style="color: hsl(120, 100%, 40%);">+ TALLOC_FREE(the_pcu);</span><br><span> fprintf(stderr, "=== end %s ===\n", __func__);</span><br><span> }</span><br><span> </span><br><span>@@ -3068,6 +3091,7 @@</span><br><span> </span><br><span> static void test_tbf_egprs_retx_dl(void)</span><br><span> {</span><br><span style="color: hsl(120, 100%, 40%);">+ the_pcu = gprs_pcu_alloc(tall_pcu_ctx);</span><br><span> the_pcu->bts = bts_alloc(the_pcu);</span><br><span> BTS *the_bts = the_pcu->bts;</span><br><span> uint8_t ts_no = 4;</span><br><span>@@ -3090,12 +3114,13 @@</span><br><span> establish_and_use_egprs_dl_tbf_for_retx(the_bts, 7, 5);</span><br><span> establish_and_use_egprs_dl_tbf_for_retx(the_bts, 9, 6);</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">- TALLOC_FREE(the_pcu->bts);</span><br><span style="color: hsl(120, 100%, 40%);">+ TALLOC_FREE(the_pcu);</span><br><span> fprintf(stderr, "=== end %s ===\n", __func__);</span><br><span> }</span><br><span> </span><br><span> static void test_tbf_egprs_spb_dl(void)</span><br><span> {</span><br><span style="color: hsl(120, 100%, 40%);">+ the_pcu = gprs_pcu_alloc(tall_pcu_ctx);</span><br><span> the_pcu->bts = bts_alloc(the_pcu);</span><br><span> BTS *the_bts = the_pcu->bts;</span><br><span> uint8_t ts_no = 4;</span><br><span>@@ -3120,12 +3145,13 @@</span><br><span> /* check MCS6->(MCS3+MCS3)->MCS6 case */</span><br><span> egprs_spb_to_normal_validation(the_bts, 6, 3);</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">- TALLOC_FREE(the_pcu->bts);</span><br><span style="color: hsl(120, 100%, 40%);">+ TALLOC_FREE(the_pcu);</span><br><span> fprintf(stderr, "=== end %s ===\n", __func__);</span><br><span> }</span><br><span> </span><br><span> static void test_tbf_egprs_dl()</span><br><span> {</span><br><span style="color: hsl(120, 100%, 40%);">+ the_pcu = gprs_pcu_alloc(tall_pcu_ctx);</span><br><span> the_pcu->bts = bts_alloc(the_pcu);</span><br><span> BTS *the_bts = the_pcu->bts;</span><br><span> uint8_t ts_no = 4;</span><br><span>@@ -3141,7 +3167,7 @@</span><br><span> for (i = 1; i <= 9; i++)</span><br><span> establish_and_use_egprs_dl_tbf(the_bts, i);</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">- TALLOC_FREE(the_pcu->bts);</span><br><span style="color: hsl(120, 100%, 40%);">+ TALLOC_FREE(the_pcu);</span><br><span> fprintf(stderr, "=== end %s ===\n", __func__);</span><br><span> }</span><br><span> </span><br><span>@@ -3149,6 +3175,7 @@</span><br><span> </span><br><span> static void test_packet_access_rej_prr_no_other_tbfs()</span><br><span> {</span><br><span style="color: hsl(120, 100%, 40%);">+ the_pcu = gprs_pcu_alloc(tall_pcu_ctx);</span><br><span> the_pcu->bts = bts_alloc(the_pcu);</span><br><span> BTS *the_bts = the_pcu->bts;</span><br><span> uint32_t fn = 2654218;</span><br><span>@@ -3178,12 +3205,13 @@</span><br><span> </span><br><span> ul_tbf->handle_timeout();</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">- TALLOC_FREE(the_pcu->bts);</span><br><span style="color: hsl(120, 100%, 40%);">+ TALLOC_FREE(the_pcu);</span><br><span> fprintf(stderr, "=== end %s ===\n", __func__);</span><br><span> }</span><br><span> </span><br><span> static void test_packet_access_rej_prr()</span><br><span> {</span><br><span style="color: hsl(120, 100%, 40%);">+ the_pcu = gprs_pcu_alloc(tall_pcu_ctx);</span><br><span> the_pcu->bts = bts_alloc(the_pcu);</span><br><span> BTS *the_bts = the_pcu->bts;</span><br><span> uint32_t fn = 2654218;</span><br><span>@@ -3248,12 +3276,13 @@</span><br><span> </span><br><span> OSMO_ASSERT(rc == 0);</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">- TALLOC_FREE(the_pcu->bts);</span><br><span style="color: hsl(120, 100%, 40%);">+ TALLOC_FREE(the_pcu);</span><br><span> fprintf(stderr, "=== end %s ===\n", __func__);</span><br><span> }</span><br><span> </span><br><span> void test_packet_access_rej_epdan()</span><br><span> {</span><br><span style="color: hsl(120, 100%, 40%);">+ the_pcu = gprs_pcu_alloc(tall_pcu_ctx);</span><br><span> the_pcu->bts = bts_alloc(the_pcu);</span><br><span> BTS *the_bts = the_pcu->bts;</span><br><span> uint32_t tlli = 0xffeeddcc;</span><br><span>@@ -3276,7 +3305,7 @@</span><br><span> if (!msgb_eq_data_print(msg, exp, GSM_MACBLOCK_LEN))</span><br><span> fprintf(stderr, "%s test failed!\n", __func__);</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">- TALLOC_FREE(the_pcu->bts);</span><br><span style="color: hsl(120, 100%, 40%);">+ TALLOC_FREE(the_pcu);</span><br><span> fprintf(stderr, "=== end %s ===\n", __func__);</span><br><span> }</span><br><span> </span><br><span>@@ -3296,8 +3325,6 @@</span><br><span> log_parse_category_mask(osmo_stderr_target, "DRLCMAC,1:DRLCMACDATA,3:DRLCMACDL,3:DRLCMACUL,3:"</span><br><span> "DRLCMACSCHED,1:DRLCMACMEAS,3:DNS,3:DLBSSGP,3:DPCU,5:"</span><br><span> "DL1IF,6:DTBF,1:DTBFUL,1:DTBFDL,1:DLGLOBAL,2:");</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">- the_pcu = gprs_pcu_alloc(tall_pcu_ctx);</span><br><span> vty_init(&pcu_vty_info);</span><br><span> pcu_vty_init();</span><br><span> </span><br><span>@@ -3336,8 +3363,6 @@</span><br><span> test_packet_access_rej_prr();</span><br><span> test_packet_access_rej_prr_no_other_tbfs();</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">- talloc_free(the_pcu);</span><br><span> if (getenv("TALLOC_REPORT_FULL"))</span><br><span> talloc_report_full(tall_pcu_ctx, stderr);</span><br><span> return EXIT_SUCCESS;</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-pcu/+/22189">change 22189</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-pcu/+/22189"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: osmo-pcu </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I18e2fe7dd1cc5940570252a2a6a106de49d8a7dd </div>
<div style="display:none"> Gerrit-Change-Number: 22189 </div>
<div style="display:none"> Gerrit-PatchSet: 4 </div>
<div style="display:none"> Gerrit-Owner: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Reviewer: lynxis lazus <lynxis@fe80.eu> </div>
<div style="display:none"> Gerrit-Reviewer: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>