<p>daniel has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/osmo-sgsn/+/22284">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">gbproxy: Use C-style comments<br><br>Change-Id: Ia3d27ef79a3370147395e7441149fd1231a760d5<br>---<br>M src/gbproxy/gb_proxy.c<br>M src/gbproxy/gb_proxy_peer.c<br>2 files changed, 7 insertions(+), 7 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-sgsn refs/changes/84/22284/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/gbproxy/gb_proxy.c b/src/gbproxy/gb_proxy.c</span><br><span>index 44a9008..da232e2 100644</span><br><span>--- a/src/gbproxy/gb_proxy.c</span><br><span>+++ b/src/gbproxy/gb_proxy.c</span><br><span>@@ -417,9 +417,9 @@</span><br><span>                         tlli = osmo_load32be(TLVP_VAL(&tp, BSSGP_IE_TMSI));</span><br><span>                      rc = gbprox_bss2sgsn_tlli(bss_bvc->cell, msg, &tlli, false);</span><br><span>          } else if (TLVP_PRESENT(&tp, BSSGP_IE_IMSI)) {</span><br><span style="color: hsl(0, 100%, 40%);">-                      // FIXME: Use the IMSI as selector?</span><br><span style="color: hsl(120, 100%, 40%);">+                   /* FIXME: Use the IMSI as selector? */</span><br><span>                       rc = gbprox_bss2sgsn_tlli(bss_bvc->cell, msg, NULL, false);</span><br><span style="color: hsl(0, 100%, 40%);">-                  //rc = gbprox_bss2sgsn_hashed(bss_bvc->cell, msg, NULL);</span><br><span style="color: hsl(120, 100%, 40%);">+                   /* rc = gbprox_bss2sgsn_hashed(bss_bvc->cell, msg, NULL); */</span><br><span>              } else</span><br><span>                       LOGPBVC(bss_bvc, LOGL_ERROR, "Rx RADIO-STATUS without any of the conditional IEs\n");</span><br><span>              break;</span><br><span>diff --git a/src/gbproxy/gb_proxy_peer.c b/src/gbproxy/gb_proxy_peer.c</span><br><span>index 1d9352d..7e94331 100644</span><br><span>--- a/src/gbproxy/gb_proxy_peer.c</span><br><span>+++ b/src/gbproxy/gb_proxy_peer.c</span><br><span>@@ -609,7 +609,7 @@</span><br><span> </span><br><span>    LOGPSGSN_CAT(sgsn, DOBJ, LOGL_INFO, "SGSN Destroying\n");</span><br><span>  llist_del(&sgsn->list);</span><br><span style="color: hsl(0, 100%, 40%);">-  // talloc will free ->name and ->pool.nri_ranges</span><br><span style="color: hsl(120, 100%, 40%);">+        /* talloc will free ->name and ->pool.nri_ranges */</span><br><span>    talloc_free(sgsn);</span><br><span> }</span><br><span> </span><br><span>@@ -728,23 +728,23 @@</span><br><span>          return sgsn;</span><br><span>         }</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-   // TODO: We should keep track of count in cfg</span><br><span style="color: hsl(120, 100%, 40%);">+ /* TODO: We should keep track of count in cfg */</span><br><span>     num_sgsns = llist_count(&cfg->sgsns);</span><br><span> </span><br><span>     if (num_sgsns == 0)</span><br><span>          return NULL;</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-        // FIXME: 256 SGSNs ought to be enough for everyone</span><br><span style="color: hsl(120, 100%, 40%);">+   /* FIXME: 256 SGSNs ought to be enough for everyone */</span><br><span>       index = hash_32(tlli, 8) % num_sgsns;</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-       // Get the first enabled SGSN after index</span><br><span style="color: hsl(120, 100%, 40%);">+     /* Get the first enabled SGSN after index */</span><br><span>         llist_for_each_entry(sgsn, &cfg->sgsns, list) {</span><br><span>               if (i >= index && sgsn->pool.allow_attach) {</span><br><span>                   return sgsn;</span><br><span>                 }</span><br><span>            i++;</span><br><span>         }</span><br><span style="color: hsl(0, 100%, 40%);">-       // Start again from the beginning</span><br><span style="color: hsl(120, 100%, 40%);">+     /* Start again from the beginning */</span><br><span>         i = 0;</span><br><span>       llist_for_each_entry(sgsn, &cfg->sgsns, list) {</span><br><span>               if (i >= index) {</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-sgsn/+/22284">change 22284</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-sgsn/+/22284"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-sgsn </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Ia3d27ef79a3370147395e7441149fd1231a760d5 </div>
<div style="display:none"> Gerrit-Change-Number: 22284 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: daniel <dwillmann@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>