<p>daniel <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/libosmocore/+/22255">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  Jenkins Builder: Verified
  lynxis lazus: Looks good to me, approved

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">ns2: Fix memory leak in IP-SNS<br><br>Don't allocate msg twice - it's not nice.<br><br>Change-Id: I3fa0076eb480a7bcadb74cc86760dc29b77ac600<br>Related: OS#4874<br>---<br>M src/gb/gprs_ns2_message.c<br>1 file changed, 2 insertions(+), 2 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/gb/gprs_ns2_message.c b/src/gb/gprs_ns2_message.c</span><br><span>index eb9a198..6c7f08f 100644</span><br><span>--- a/src/gb/gprs_ns2_message.c</span><br><span>+++ b/src/gb/gprs_ns2_message.c</span><br><span>@@ -498,7 +498,7 @@</span><br><span>                     const struct gprs_ns_ie_ip6_elem *ip6_elems,</span><br><span>                         unsigned int num_ip6_elems)</span><br><span> {</span><br><span style="color: hsl(0, 100%, 40%);">-        struct msgb *msg = gprs_ns2_msgb_alloc();</span><br><span style="color: hsl(120, 100%, 40%);">+     struct msgb *msg;</span><br><span>    struct gprs_ns_hdr *nsh;</span><br><span>     uint16_t nsei;</span><br><span> </span><br><span>@@ -652,7 +652,7 @@</span><br><span> int ns2_tx_sns_size(struct gprs_ns2_vc *nsvc, bool reset_flag, uint16_t max_nr_nsvc,</span><br><span>                      int ip4_ep_nr, int ip6_ep_nr)</span><br><span> {</span><br><span style="color: hsl(0, 100%, 40%);">-     struct msgb *msg = gprs_ns2_msgb_alloc();</span><br><span style="color: hsl(120, 100%, 40%);">+     struct msgb *msg;</span><br><span>    struct gprs_ns_hdr *nsh;</span><br><span>     uint16_t nsei;</span><br><span> </span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/libosmocore/+/22255">change 22255</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/libosmocore/+/22255"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: libosmocore </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I3fa0076eb480a7bcadb74cc86760dc29b77ac600 </div>
<div style="display:none"> Gerrit-Change-Number: 22255 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: daniel <dwillmann@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: daniel <dwillmann@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: lynxis lazus <lynxis@fe80.eu> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>