<p>laforge <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/22237">View Change</a></p><div style="white-space:pre-wrap">Approvals:
Jenkins Builder: Verified
daniel: Looks good to me, but someone else must approve
pespin: Looks good to me, approved
</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">gbproxy: Don't pass global (component) variables as function arguments<br><br>The point of global (component) variables is that we don't have to pass<br>them around as extra function arguments everywhere. So don't do it.<br><br>Change-Id: I0754d5db7e797a51be3a0b601b0533de80bc246d<br>---<br>M gbproxy/GBProxy_Tests.ttcn<br>1 file changed, 43 insertions(+), 44 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/gbproxy/GBProxy_Tests.ttcn b/gbproxy/GBProxy_Tests.ttcn</span><br><span>index f0175c2..caf4c66 100644</span><br><span>--- a/gbproxy/GBProxy_Tests.ttcn</span><br><span>+++ b/gbproxy/GBProxy_Tests.ttcn</span><br><span>@@ -601,7 +601,7 @@</span><br><span> type function void_fn(charstring id) runs on BSSGP_ConnHdlr;</span><br><span> </span><br><span> /* helper function to create, connect and start a BSSGP_ConnHdlr component */</span><br><span style="color: hsl(0, 100%, 40%);">-function f_start_handler(void_fn fn, charstring id, GbInstances pcu, GbInstances sgsn, integer imsi_suffix,</span><br><span style="color: hsl(120, 100%, 40%);">+function f_start_handler(void_fn fn, charstring id, integer imsi_suffix,</span><br><span> float t_guard := 30.0, integer sgsn_idx := 0, integer nri_idx := 0)</span><br><span> runs on test_CT return BSSGP_ConnHdlr {</span><br><span> var BSSGP_ConnHdlr vc_conn;</span><br><span>@@ -617,8 +617,8 @@</span><br><span> tlli := f_gprs_tlli_from_tmsi(p_tmsi, TLLI_LOCAL),</span><br><span> tlli_old := omit,</span><br><span> ra := omit,</span><br><span style="color: hsl(0, 100%, 40%);">- pcu := pcu,</span><br><span style="color: hsl(0, 100%, 40%);">- sgsn := sgsn,</span><br><span style="color: hsl(120, 100%, 40%);">+ pcu := g_pcu,</span><br><span style="color: hsl(120, 100%, 40%);">+ sgsn := g_sgsn,</span><br><span> sgsn_idx := sgsn_idx,</span><br><span> t_guard := t_guard</span><br><span> };</span><br><span>@@ -629,8 +629,7 @@</span><br><span> return vc_conn;</span><br><span> }</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-function f_start_handlers(void_fn fn, charstring id, GbInstances pcu, GbInstances sgsn,</span><br><span style="color: hsl(0, 100%, 40%);">- integer imsi_suffix, float t_guard := 30.0)</span><br><span style="color: hsl(120, 100%, 40%);">+function f_start_handlers(void_fn fn, charstring id, integer imsi_suffix, float t_guard := 30.0)</span><br><span> runs on test_CT</span><br><span> {</span><br><span> var integer sgsn_idx, nri_idx;</span><br><span>@@ -638,7 +637,7 @@</span><br><span> for (nri_idx := 0; nri_idx < lengthof(mp_sgsn_nri[sgsn_idx]); nri_idx:=nri_idx+1) {</span><br><span> var integer extd_imsi_suffix := 1000*sgsn_idx + 100*nri_idx;</span><br><span> var BSSGP_ConnHdlr vc_conn;</span><br><span style="color: hsl(0, 100%, 40%);">- vc_conn := f_start_handler(fn, id, pcu, sgsn, extd_imsi_suffix, t_guard,</span><br><span style="color: hsl(120, 100%, 40%);">+ vc_conn := f_start_handler(fn, id, extd_imsi_suffix, t_guard,</span><br><span> sgsn_idx, nri_idx);</span><br><span> /* Idea: we could also run them in parallel ? */</span><br><span> vc_conn.done;</span><br><span>@@ -901,7 +900,7 @@</span><br><span> </span><br><span> testcase TC_BVC_bringup() runs on test_CT {</span><br><span> f_init();</span><br><span style="color: hsl(0, 100%, 40%);">- f_start_handlers(refers(f_TC_BVC_bringup), testcasename(), g_pcu, g_sgsn, 51);</span><br><span style="color: hsl(120, 100%, 40%);">+ f_start_handlers(refers(f_TC_BVC_bringup), testcasename(), 51);</span><br><span> f_cleanup();</span><br><span> }</span><br><span> </span><br><span>@@ -967,7 +966,7 @@</span><br><span> testcase TC_ul_unitdata() runs on test_CT</span><br><span> {</span><br><span> f_init();</span><br><span style="color: hsl(0, 100%, 40%);">- f_start_handlers(refers(f_TC_ul_unitdata), testcasename(), g_pcu, g_sgsn, 1);</span><br><span style="color: hsl(120, 100%, 40%);">+ f_start_handlers(refers(f_TC_ul_unitdata), testcasename(), 1);</span><br><span> /* TODO: start multiple handlers (UEs) on various cells on same and other NSEs */</span><br><span> f_cleanup();</span><br><span> }</span><br><span>@@ -993,7 +992,7 @@</span><br><span> testcase TC_dl_unitdata() runs on test_CT</span><br><span> {</span><br><span> f_init();</span><br><span style="color: hsl(0, 100%, 40%);">- f_start_handlers(refers(f_TC_dl_unitdata), testcasename(), g_pcu, g_sgsn, 2);</span><br><span style="color: hsl(120, 100%, 40%);">+ f_start_handlers(refers(f_TC_dl_unitdata), testcasename(), 2);</span><br><span> /* TODO: start multiple handlers (UEs) on various cells on same and other NSEs */</span><br><span> f_cleanup();</span><br><span> }</span><br><span>@@ -1013,7 +1012,7 @@</span><br><span> testcase TC_ra_capability() runs on test_CT</span><br><span> {</span><br><span> f_init();</span><br><span style="color: hsl(0, 100%, 40%);">- f_start_handlers(refers(f_TC_ra_capability), testcasename(), g_pcu, g_sgsn, 3);</span><br><span style="color: hsl(120, 100%, 40%);">+ f_start_handlers(refers(f_TC_ra_capability), testcasename(), 3);</span><br><span> /* TODO: start multiple handlers (UEs) on various cells on same and other NSEs */</span><br><span> f_cleanup();</span><br><span> }</span><br><span>@@ -1040,7 +1039,7 @@</span><br><span> testcase TC_ra_capability_upd() runs on test_CT</span><br><span> {</span><br><span> f_init();</span><br><span style="color: hsl(0, 100%, 40%);">- f_start_handlers(refers(f_TC_ra_capability_upd), testcasename(), g_pcu, g_sgsn, 4);</span><br><span style="color: hsl(120, 100%, 40%);">+ f_start_handlers(refers(f_TC_ra_capability_upd), testcasename(), 4);</span><br><span> /* TODO: start multiple handlers (UEs) on various cells on same and other NSEs */</span><br><span> f_cleanup();</span><br><span> }</span><br><span>@@ -1060,7 +1059,7 @@</span><br><span> testcase TC_radio_status() runs on test_CT</span><br><span> {</span><br><span> f_init();</span><br><span style="color: hsl(0, 100%, 40%);">- f_start_handlers(refers(f_TC_radio_status), testcasename(), g_pcu, g_sgsn, 5);</span><br><span style="color: hsl(120, 100%, 40%);">+ f_start_handlers(refers(f_TC_radio_status), testcasename(), 5);</span><br><span> /* TODO: start multiple handlers (UEs) on various cells on same and other NSEs */</span><br><span> f_cleanup();</span><br><span> }</span><br><span>@@ -1198,7 +1197,7 @@</span><br><span> </span><br><span> /* start parallel components generating DL-UNITDATA from the SGSN side */</span><br><span> for (var integer i:= 0; i < num_ue; i := i+1) {</span><br><span style="color: hsl(0, 100%, 40%);">- vc_conn[i] := f_start_handler(refers(f_TC_dl_ud_unidir), testcasename(), g_pcu, g_sgsn,</span><br><span style="color: hsl(120, 100%, 40%);">+ vc_conn[i] := f_start_handler(refers(f_TC_dl_ud_unidir), testcasename(),</span><br><span> 5+i, 30.0, sgsn_idx);</span><br><span> }</span><br><span> </span><br><span>@@ -1366,7 +1365,7 @@</span><br><span> }</span><br><span> testcase TC_paging_ps_ptp_bss() runs on test_CT {</span><br><span> f_init();</span><br><span style="color: hsl(0, 100%, 40%);">- f_start_handlers(refers(f_TC_paging_ps_ptp_bss), testcasename(), g_pcu, g_sgsn, 9);</span><br><span style="color: hsl(120, 100%, 40%);">+ f_start_handlers(refers(f_TC_paging_ps_ptp_bss), testcasename(), 9);</span><br><span> f_cleanup();</span><br><span> }</span><br><span> </span><br><span>@@ -1380,7 +1379,7 @@</span><br><span> }</span><br><span> testcase TC_paging_ps_ptp_lac() runs on test_CT {</span><br><span> f_init();</span><br><span style="color: hsl(0, 100%, 40%);">- f_start_handlers(refers(f_TC_paging_ps_ptp_lac), testcasename(), g_pcu, g_sgsn, 10);</span><br><span style="color: hsl(120, 100%, 40%);">+ f_start_handlers(refers(f_TC_paging_ps_ptp_lac), testcasename(), 10);</span><br><span> f_cleanup();</span><br><span> }</span><br><span> </span><br><span>@@ -1396,7 +1395,7 @@</span><br><span> }</span><br><span> testcase TC_paging_ps_ptp_lac_unknown() runs on test_CT {</span><br><span> f_init();</span><br><span style="color: hsl(0, 100%, 40%);">- f_start_handlers(refers(f_TC_paging_ps_ptp_lac_unknown), testcasename(), g_pcu, g_sgsn, 11);</span><br><span style="color: hsl(120, 100%, 40%);">+ f_start_handlers(refers(f_TC_paging_ps_ptp_lac_unknown), testcasename(), 11);</span><br><span> f_cleanup();</span><br><span> }</span><br><span> </span><br><span>@@ -1409,7 +1408,7 @@</span><br><span> }</span><br><span> testcase TC_paging_ps_ptp_rac() runs on test_CT {</span><br><span> f_init();</span><br><span style="color: hsl(0, 100%, 40%);">- f_start_handlers(refers(f_TC_paging_ps_ptp_rac), testcasename(), g_pcu, g_sgsn, 11);</span><br><span style="color: hsl(120, 100%, 40%);">+ f_start_handlers(refers(f_TC_paging_ps_ptp_rac), testcasename(), 11);</span><br><span> f_cleanup();</span><br><span> }</span><br><span> </span><br><span>@@ -1428,7 +1427,7 @@</span><br><span> }</span><br><span> testcase TC_paging_ps_ptp_rac_unknown() runs on test_CT {</span><br><span> f_init();</span><br><span style="color: hsl(0, 100%, 40%);">- f_start_handlers(refers(f_TC_paging_ps_ptp_rac_unknown), testcasename(), g_pcu, g_sgsn, 11);</span><br><span style="color: hsl(120, 100%, 40%);">+ f_start_handlers(refers(f_TC_paging_ps_ptp_rac_unknown), testcasename(), 11);</span><br><span> f_cleanup();</span><br><span> }</span><br><span> </span><br><span>@@ -1440,7 +1439,7 @@</span><br><span> }</span><br><span> testcase TC_paging_ps_ptp_bvci() runs on test_CT {</span><br><span> f_init();</span><br><span style="color: hsl(0, 100%, 40%);">- f_start_handlers(refers(f_TC_paging_ps_ptp_bvci), testcasename(), g_pcu, g_sgsn, 12);</span><br><span style="color: hsl(120, 100%, 40%);">+ f_start_handlers(refers(f_TC_paging_ps_ptp_bvci), testcasename(), 12);</span><br><span> f_cleanup();</span><br><span> }</span><br><span> </span><br><span>@@ -1452,7 +1451,7 @@</span><br><span> }</span><br><span> testcase TC_paging_ps_ptp_bvci_unknown() runs on test_CT {</span><br><span> f_init();</span><br><span style="color: hsl(0, 100%, 40%);">- f_start_handlers(refers(f_TC_paging_ps_ptp_bvci_unknown), testcasename(), g_pcu, g_sgsn, 11);</span><br><span style="color: hsl(120, 100%, 40%);">+ f_start_handlers(refers(f_TC_paging_ps_ptp_bvci_unknown), testcasename(), 11);</span><br><span> f_cleanup();</span><br><span> }</span><br><span> </span><br><span>@@ -1519,7 +1518,7 @@</span><br><span> }</span><br><span> testcase TC_paging_ps_sig_bss() runs on test_CT {</span><br><span> f_init();</span><br><span style="color: hsl(0, 100%, 40%);">- f_start_handlers(refers(f_TC_paging_ps_sig_bss), testcasename(), g_pcu, g_sgsn, 13);</span><br><span style="color: hsl(120, 100%, 40%);">+ f_start_handlers(refers(f_TC_paging_ps_sig_bss), testcasename(), 13);</span><br><span> f_cleanup();</span><br><span> }</span><br><span> </span><br><span>@@ -1536,7 +1535,7 @@</span><br><span> }</span><br><span> testcase TC_paging_ps_sig_lac() runs on test_CT {</span><br><span> f_init();</span><br><span style="color: hsl(0, 100%, 40%);">- f_start_handlers(refers(f_TC_paging_ps_sig_lac), testcasename(), g_pcu, g_sgsn, 14);</span><br><span style="color: hsl(120, 100%, 40%);">+ f_start_handlers(refers(f_TC_paging_ps_sig_lac), testcasename(), 14);</span><br><span> f_cleanup();</span><br><span> }</span><br><span> </span><br><span>@@ -1551,7 +1550,7 @@</span><br><span> }</span><br><span> testcase TC_paging_ps_sig_lac_unknown() runs on test_CT {</span><br><span> f_init();</span><br><span style="color: hsl(0, 100%, 40%);">- f_start_handlers(refers(f_TC_paging_ps_sig_lac_unknown), testcasename(), g_pcu, g_sgsn, 11);</span><br><span style="color: hsl(120, 100%, 40%);">+ f_start_handlers(refers(f_TC_paging_ps_sig_lac_unknown), testcasename(), 11);</span><br><span> f_cleanup();</span><br><span> }</span><br><span> </span><br><span>@@ -1570,7 +1569,7 @@</span><br><span> }</span><br><span> testcase TC_paging_ps_sig_rac() runs on test_CT {</span><br><span> f_init();</span><br><span style="color: hsl(0, 100%, 40%);">- f_start_handlers(refers(f_TC_paging_ps_sig_rac), testcasename(), g_pcu, g_sgsn, 15);</span><br><span style="color: hsl(120, 100%, 40%);">+ f_start_handlers(refers(f_TC_paging_ps_sig_rac), testcasename(), 15);</span><br><span> f_cleanup();</span><br><span> }</span><br><span> </span><br><span>@@ -1588,7 +1587,7 @@</span><br><span> }</span><br><span> testcase TC_paging_ps_sig_rac_unknown() runs on test_CT {</span><br><span> f_init();</span><br><span style="color: hsl(0, 100%, 40%);">- f_start_handlers(refers(f_TC_paging_ps_sig_rac_unknown), testcasename(), g_pcu, g_sgsn, 11);</span><br><span style="color: hsl(120, 100%, 40%);">+ f_start_handlers(refers(f_TC_paging_ps_sig_rac_unknown), testcasename(), 11);</span><br><span> f_cleanup();</span><br><span> }</span><br><span> </span><br><span>@@ -1599,7 +1598,7 @@</span><br><span> }</span><br><span> testcase TC_paging_ps_sig_bvci() runs on test_CT {</span><br><span> f_init();</span><br><span style="color: hsl(0, 100%, 40%);">- f_start_handlers(refers(f_TC_paging_ps_sig_bvci), testcasename(), g_pcu, g_sgsn, 16);</span><br><span style="color: hsl(120, 100%, 40%);">+ f_start_handlers(refers(f_TC_paging_ps_sig_bvci), testcasename(), 16);</span><br><span> f_cleanup();</span><br><span> }</span><br><span> </span><br><span>@@ -1610,7 +1609,7 @@</span><br><span> }</span><br><span> testcase TC_paging_ps_sig_bvci_unknown() runs on test_CT {</span><br><span> f_init();</span><br><span style="color: hsl(0, 100%, 40%);">- f_start_handlers(refers(f_TC_paging_ps_sig_bvci_unknown), testcasename(), g_pcu, g_sgsn, 11);</span><br><span style="color: hsl(120, 100%, 40%);">+ f_start_handlers(refers(f_TC_paging_ps_sig_bvci_unknown), testcasename(), 11);</span><br><span> f_cleanup();</span><br><span> }</span><br><span> </span><br><span>@@ -1731,7 +1730,7 @@</span><br><span> }</span><br><span> testcase TC_paging_cs_ptp_bss() runs on test_CT {</span><br><span> f_init();</span><br><span style="color: hsl(0, 100%, 40%);">- f_start_handlers(refers(f_TC_paging_cs_ptp_bss), testcasename(), g_pcu, g_sgsn, 17);</span><br><span style="color: hsl(120, 100%, 40%);">+ f_start_handlers(refers(f_TC_paging_cs_ptp_bss), testcasename(), 17);</span><br><span> f_cleanup();</span><br><span> }</span><br><span> </span><br><span>@@ -1745,7 +1744,7 @@</span><br><span> }</span><br><span> testcase TC_paging_cs_ptp_lac() runs on test_CT {</span><br><span> f_init();</span><br><span style="color: hsl(0, 100%, 40%);">- f_start_handlers(refers(f_TC_paging_cs_ptp_lac), testcasename(), g_pcu, g_sgsn, 18);</span><br><span style="color: hsl(120, 100%, 40%);">+ f_start_handlers(refers(f_TC_paging_cs_ptp_lac), testcasename(), 18);</span><br><span> f_cleanup();</span><br><span> }</span><br><span> </span><br><span>@@ -1761,7 +1760,7 @@</span><br><span> }</span><br><span> testcase TC_paging_cs_ptp_lac_unknown() runs on test_CT {</span><br><span> f_init();</span><br><span style="color: hsl(0, 100%, 40%);">- f_start_handlers(refers(f_TC_paging_cs_ptp_lac_unknown), testcasename(), g_pcu, g_sgsn, 11);</span><br><span style="color: hsl(120, 100%, 40%);">+ f_start_handlers(refers(f_TC_paging_cs_ptp_lac_unknown), testcasename(), 11);</span><br><span> f_cleanup();</span><br><span> }</span><br><span> </span><br><span>@@ -1774,7 +1773,7 @@</span><br><span> }</span><br><span> testcase TC_paging_cs_ptp_rac() runs on test_CT {</span><br><span> f_init();</span><br><span style="color: hsl(0, 100%, 40%);">- f_start_handlers(refers(f_TC_paging_cs_ptp_rac), testcasename(), g_pcu, g_sgsn, 19);</span><br><span style="color: hsl(120, 100%, 40%);">+ f_start_handlers(refers(f_TC_paging_cs_ptp_rac), testcasename(), 19);</span><br><span> f_cleanup();</span><br><span> }</span><br><span> </span><br><span>@@ -1793,7 +1792,7 @@</span><br><span> }</span><br><span> testcase TC_paging_cs_ptp_rac_unknown() runs on test_CT {</span><br><span> f_init();</span><br><span style="color: hsl(0, 100%, 40%);">- f_start_handlers(refers(f_TC_paging_cs_ptp_rac_unknown), testcasename(), g_pcu, g_sgsn, 11);</span><br><span style="color: hsl(120, 100%, 40%);">+ f_start_handlers(refers(f_TC_paging_cs_ptp_rac_unknown), testcasename(), 11);</span><br><span> f_cleanup();</span><br><span> }</span><br><span> </span><br><span>@@ -1805,7 +1804,7 @@</span><br><span> }</span><br><span> testcase TC_paging_cs_ptp_bvci() runs on test_CT {</span><br><span> f_init();</span><br><span style="color: hsl(0, 100%, 40%);">- f_start_handlers(refers(f_TC_paging_cs_ptp_bvci), testcasename(), g_pcu, g_sgsn, 20);</span><br><span style="color: hsl(120, 100%, 40%);">+ f_start_handlers(refers(f_TC_paging_cs_ptp_bvci), testcasename(), 20);</span><br><span> f_cleanup();</span><br><span> }</span><br><span> </span><br><span>@@ -1817,7 +1816,7 @@</span><br><span> }</span><br><span> testcase TC_paging_cs_ptp_bvci_unknown() runs on test_CT {</span><br><span> f_init();</span><br><span style="color: hsl(0, 100%, 40%);">- f_start_handlers(refers(f_TC_paging_cs_ptp_bvci_unknown), testcasename(), g_pcu, g_sgsn, 11);</span><br><span style="color: hsl(120, 100%, 40%);">+ f_start_handlers(refers(f_TC_paging_cs_ptp_bvci_unknown), testcasename(), 11);</span><br><span> f_cleanup();</span><br><span> }</span><br><span> </span><br><span>@@ -1861,7 +1860,7 @@</span><br><span> }</span><br><span> testcase TC_paging_cs_sig_bss() runs on test_CT {</span><br><span> f_init();</span><br><span style="color: hsl(0, 100%, 40%);">- f_start_handlers(refers(f_TC_paging_cs_sig_bss), testcasename(), g_pcu, g_sgsn, 13);</span><br><span style="color: hsl(120, 100%, 40%);">+ f_start_handlers(refers(f_TC_paging_cs_sig_bss), testcasename(), 13);</span><br><span> f_cleanup();</span><br><span> }</span><br><span> </span><br><span>@@ -1878,7 +1877,7 @@</span><br><span> }</span><br><span> testcase TC_paging_cs_sig_lac() runs on test_CT {</span><br><span> f_init();</span><br><span style="color: hsl(0, 100%, 40%);">- f_start_handlers(refers(f_TC_paging_cs_sig_lac), testcasename(), g_pcu, g_sgsn, 14);</span><br><span style="color: hsl(120, 100%, 40%);">+ f_start_handlers(refers(f_TC_paging_cs_sig_lac), testcasename(), 14);</span><br><span> f_cleanup();</span><br><span> }</span><br><span> </span><br><span>@@ -1893,7 +1892,7 @@</span><br><span> }</span><br><span> testcase TC_paging_cs_sig_lac_unknown() runs on test_CT {</span><br><span> f_init();</span><br><span style="color: hsl(0, 100%, 40%);">- f_start_handlers(refers(f_TC_paging_cs_sig_lac_unknown), testcasename(), g_pcu, g_sgsn, 11);</span><br><span style="color: hsl(120, 100%, 40%);">+ f_start_handlers(refers(f_TC_paging_cs_sig_lac_unknown), testcasename(), 11);</span><br><span> f_cleanup();</span><br><span> }</span><br><span> </span><br><span>@@ -1912,7 +1911,7 @@</span><br><span> }</span><br><span> testcase TC_paging_cs_sig_rac() runs on test_CT {</span><br><span> f_init();</span><br><span style="color: hsl(0, 100%, 40%);">- f_start_handlers(refers(f_TC_paging_cs_sig_rac), testcasename(), g_pcu, g_sgsn, 15);</span><br><span style="color: hsl(120, 100%, 40%);">+ f_start_handlers(refers(f_TC_paging_cs_sig_rac), testcasename(), 15);</span><br><span> f_cleanup();</span><br><span> }</span><br><span> </span><br><span>@@ -1930,7 +1929,7 @@</span><br><span> }</span><br><span> testcase TC_paging_cs_sig_rac_unknown() runs on test_CT {</span><br><span> f_init();</span><br><span style="color: hsl(0, 100%, 40%);">- f_start_handlers(refers(f_TC_paging_cs_sig_rac_unknown), testcasename(), g_pcu, g_sgsn, 11);</span><br><span style="color: hsl(120, 100%, 40%);">+ f_start_handlers(refers(f_TC_paging_cs_sig_rac_unknown), testcasename(), 11);</span><br><span> f_cleanup();</span><br><span> }</span><br><span> </span><br><span>@@ -1941,7 +1940,7 @@</span><br><span> }</span><br><span> testcase TC_paging_cs_sig_bvci() runs on test_CT {</span><br><span> f_init();</span><br><span style="color: hsl(0, 100%, 40%);">- f_start_handlers(refers(f_TC_paging_cs_sig_bvci), testcasename(), g_pcu, g_sgsn, 16);</span><br><span style="color: hsl(120, 100%, 40%);">+ f_start_handlers(refers(f_TC_paging_cs_sig_bvci), testcasename(), 16);</span><br><span> f_cleanup();</span><br><span> }</span><br><span> </span><br><span>@@ -1952,7 +1951,7 @@</span><br><span> }</span><br><span> testcase TC_paging_cs_sig_bvci_unknown() runs on test_CT {</span><br><span> f_init();</span><br><span style="color: hsl(0, 100%, 40%);">- f_start_handlers(refers(f_TC_paging_cs_sig_bvci_unknown), testcasename(), g_pcu, g_sgsn, 11);</span><br><span style="color: hsl(120, 100%, 40%);">+ f_start_handlers(refers(f_TC_paging_cs_sig_bvci_unknown), testcasename(), 11);</span><br><span> f_cleanup();</span><br><span> }</span><br><span> </span><br><span>@@ -1981,7 +1980,7 @@</span><br><span> testcase TC_flush_ll() runs on test_CT</span><br><span> {</span><br><span> f_init();</span><br><span style="color: hsl(0, 100%, 40%);">- f_start_handlers(refers(f_TC_flush_ll), testcasename(), g_pcu, g_sgsn, 6);</span><br><span style="color: hsl(120, 100%, 40%);">+ f_start_handlers(refers(f_TC_flush_ll), testcasename(), 6);</span><br><span> /* TODO: start multiple handlers (UEs) on various cells on same and other NSEs */</span><br><span> f_cleanup();</span><br><span> }</span><br><span>@@ -2049,7 +2048,7 @@</span><br><span> testcase TC_llc_discarded() runs on test_CT</span><br><span> {</span><br><span> f_init();</span><br><span style="color: hsl(0, 100%, 40%);">- f_start_handlers(refers(f_TC_llc_discarded), testcasename(), g_pcu, g_sgsn, 6);</span><br><span style="color: hsl(120, 100%, 40%);">+ f_start_handlers(refers(f_TC_llc_discarded), testcasename(), 6);</span><br><span> /* TODO: start multiple handlers (UEs) on various cells on same and other NSEs */</span><br><span> f_cleanup();</span><br><span> }</span><br><span>@@ -2411,7 +2410,7 @@</span><br><span> testcase TC_fc_ms() runs on test_CT</span><br><span> {</span><br><span> f_init();</span><br><span style="color: hsl(0, 100%, 40%);">- f_start_handlers(refers(f_TC_fc_ms), testcasename(), g_pcu, g_sgsn, 21);</span><br><span style="color: hsl(120, 100%, 40%);">+ f_start_handlers(refers(f_TC_fc_ms), testcasename(), 21);</span><br><span> /* TODO: start multiple handlers (UEs) on various cells on same and other NSEs */</span><br><span> f_cleanup();</span><br><span> }</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/22237">change 22237</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/22237"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: osmo-ttcn3-hacks </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I0754d5db7e797a51be3a0b601b0533de80bc246d </div>
<div style="display:none"> Gerrit-Change-Number: 22237 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: daniel <dwillmann@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Reviewer: lynxis lazus <lynxis@fe80.eu> </div>
<div style="display:none"> Gerrit-Reviewer: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>