<p>laforge <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/22239">View Change</a></p><div style="white-space:pre-wrap">Approvals:
Jenkins Builder: Verified
daniel: Looks good to me, but someone else must approve
pespin: Looks good to me, approved
</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">gbproxy: Allow creating ConnHdlr without a P-TMSI<br><br>This will be useful for testing paging cases where no P-TMSI is allocated.<br><br>Change-Id: Icd780c750c77e723e545ed5a5b52ef26e442b4f2<br>---<br>M gbproxy/GBProxy_Tests.ttcn<br>1 file changed, 10 insertions(+), 5 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/gbproxy/GBProxy_Tests.ttcn b/gbproxy/GBProxy_Tests.ttcn</span><br><span>index 6141f6a..f1e8749 100644</span><br><span>--- a/gbproxy/GBProxy_Tests.ttcn</span><br><span>+++ b/gbproxy/GBProxy_Tests.ttcn</span><br><span>@@ -1,6 +1,7 @@</span><br><span> module GBProxy_Tests {</span><br><span> </span><br><span> /* Osmocom GBProxy test suite in TTCN-3</span><br><span style="color: hsl(120, 100%, 40%);">+ * (C) 2020-2021 Harald Welte <laforge@osmocom.org></span><br><span> * (C) 2020 sysmocom - s.f.m.c. GmbH</span><br><span> * All rights reserved.</span><br><span> *</span><br><span>@@ -601,8 +602,8 @@</span><br><span> type function void_fn(charstring id) runs on BSSGP_ConnHdlr;</span><br><span> </span><br><span> /* helper function to create, connect and start a BSSGP_ConnHdlr component */</span><br><span style="color: hsl(0, 100%, 40%);">-function f_start_handler(void_fn fn, charstring id, integer imsi_suffix,</span><br><span style="color: hsl(0, 100%, 40%);">- float t_guard := 30.0, integer sgsn_idx := 0, integer nri_idx := 0)</span><br><span style="color: hsl(120, 100%, 40%);">+function f_start_handler(void_fn fn, charstring id, integer imsi_suffix, float t_guard := 30.0,</span><br><span style="color: hsl(120, 100%, 40%);">+ integer sgsn_idx := 0, integer nri_idx := 0, boolean have_ptmsi := true)</span><br><span> runs on test_CT return BSSGP_ConnHdlr {</span><br><span> var BSSGP_ConnHdlr vc_conn;</span><br><span> var integer nri := mp_sgsn_nri[sgsn_idx][nri_idx];</span><br><span>@@ -622,6 +623,9 @@</span><br><span> sgsn_idx := sgsn_idx,</span><br><span> t_guard := t_guard</span><br><span> };</span><br><span style="color: hsl(120, 100%, 40%);">+ if (not have_ptmsi) {</span><br><span style="color: hsl(120, 100%, 40%);">+ pars.p_tmsi := omit;</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span> </span><br><span> vc_conn := BSSGP_ConnHdlr.create(id);</span><br><span> </span><br><span>@@ -629,7 +633,8 @@</span><br><span> return vc_conn;</span><br><span> }</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-function f_start_handlers(void_fn fn, charstring id, integer imsi_suffix, float t_guard := 30.0)</span><br><span style="color: hsl(120, 100%, 40%);">+function f_start_handlers(void_fn fn, charstring id, integer imsi_suffix, float t_guard := 30.0,</span><br><span style="color: hsl(120, 100%, 40%);">+ boolean have_ptmsi := true)</span><br><span> runs on test_CT</span><br><span> {</span><br><span> var integer sgsn_idx, nri_idx;</span><br><span>@@ -637,8 +642,8 @@</span><br><span> for (nri_idx := 0; nri_idx < lengthof(mp_sgsn_nri[sgsn_idx]); nri_idx:=nri_idx+1) {</span><br><span> var integer extd_imsi_suffix := 1000*sgsn_idx + 100*nri_idx;</span><br><span> var BSSGP_ConnHdlr vc_conn;</span><br><span style="color: hsl(0, 100%, 40%);">- vc_conn := f_start_handler(fn, id, extd_imsi_suffix, t_guard,</span><br><span style="color: hsl(0, 100%, 40%);">- sgsn_idx, nri_idx);</span><br><span style="color: hsl(120, 100%, 40%);">+ vc_conn := f_start_handler(fn, id, extd_imsi_suffix, t_guard, sgsn_idx, nri_idx,</span><br><span style="color: hsl(120, 100%, 40%);">+ have_ptmsi);</span><br><span> /* Idea: we could also run them in parallel ? */</span><br><span> vc_conn.done;</span><br><span> }</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/22239">change 22239</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/22239"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: osmo-ttcn3-hacks </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Icd780c750c77e723e545ed5a5b52ef26e442b4f2 </div>
<div style="display:none"> Gerrit-Change-Number: 22239 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: daniel <dwillmann@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Reviewer: lynxis lazus <lynxis@fe80.eu> </div>
<div style="display:none"> Gerrit-Reviewer: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>