<p>lynxis lazus has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/libosmocore/+/22206">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">gprs_ns2_sns: clear local and remote entries when SNS failed<br><br>The local and remote entries should be cleared on SNS Size.<br>Further it can be cleared when SNS failed (e.g. all NSVC become dead)<br>so VTY doesn't show old entries before entering SNS Size.<br><br>Related: OS#4949<br>Change-Id: Ie4db81acdd5f8ddf1a1f5dc7645d1144545d9c73<br>---<br>M src/gb/gprs_ns2_sns.c<br>1 file changed, 28 insertions(+), 0 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/06/22206/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/gb/gprs_ns2_sns.c b/src/gb/gprs_ns2_sns.c</span><br><span>index 1958477..dc40a26 100644</span><br><span>--- a/src/gb/gprs_ns2_sns.c</span><br><span>+++ b/src/gb/gprs_ns2_sns.c</span><br><span>@@ -255,6 +255,31 @@</span><br><span>    }</span><br><span> }</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+static void ns2_clear_ipv46_entries(struct ns2_sns_state *gss)</span><br><span style="color: hsl(120, 100%, 40%);">+{</span><br><span style="color: hsl(120, 100%, 40%);">+ if (gss->ip4_local) {</span><br><span style="color: hsl(120, 100%, 40%);">+              talloc_free(gss->ip4_local);</span><br><span style="color: hsl(120, 100%, 40%);">+               gss->ip4_local = NULL;</span><br><span style="color: hsl(120, 100%, 40%);">+     }</span><br><span style="color: hsl(120, 100%, 40%);">+     if (gss->ip4_remote) {</span><br><span style="color: hsl(120, 100%, 40%);">+             talloc_free(gss->ip4_remote);</span><br><span style="color: hsl(120, 100%, 40%);">+              gss->ip4_remote = NULL;</span><br><span style="color: hsl(120, 100%, 40%);">+    }</span><br><span style="color: hsl(120, 100%, 40%);">+     if (gss->ip6_local) {</span><br><span style="color: hsl(120, 100%, 40%);">+              talloc_free(gss->ip6_local);</span><br><span style="color: hsl(120, 100%, 40%);">+               gss->ip6_local = NULL;</span><br><span style="color: hsl(120, 100%, 40%);">+     }</span><br><span style="color: hsl(120, 100%, 40%);">+     if (gss->ip6_remote) {</span><br><span style="color: hsl(120, 100%, 40%);">+             talloc_free(gss->ip6_remote);</span><br><span style="color: hsl(120, 100%, 40%);">+              gss->ip6_remote = NULL;</span><br><span style="color: hsl(120, 100%, 40%);">+    }</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+   gss->num_ip4_local = 0;</span><br><span style="color: hsl(120, 100%, 40%);">+    gss->num_ip4_remote = 0;</span><br><span style="color: hsl(120, 100%, 40%);">+   gss->num_ip6_local = 0;</span><br><span style="color: hsl(120, 100%, 40%);">+    gss->num_ip6_remote = 0;</span><br><span style="color: hsl(120, 100%, 40%);">+}</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span> static void ns2_nsvc_create_ip4(struct osmo_fsm_inst *fi,</span><br><span>                                 struct gprs_ns2_nse *nse,</span><br><span>                            const struct gprs_ns_ie_ip4_elem *ip4)</span><br><span>@@ -713,6 +738,8 @@</span><br><span>        if (old_state != GPRS_SNS_ST_UNCONFIGURED)</span><br><span>           ns2_prim_status_ind(gss->nse, NULL, 0, NS_AFF_CAUSE_SNS_FAILURE);</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+      ns2_clear_ipv46_entries(gss);</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span>      /* no initial available */</span><br><span>   if (!gss->initial)</span><br><span>                return;</span><br><span>@@ -1360,6 +1387,7 @@</span><br><span>               * gprs_ns2_free_nsvcs() will trigger NO_NSVC, prevent this from triggering a reselection */</span><br><span>                 gss->reselection_running = true;</span><br><span>          gprs_ns2_free_nsvcs(nse);</span><br><span style="color: hsl(120, 100%, 40%);">+             ns2_clear_ipv46_entries(gss);</span><br><span> </span><br><span>            /* Choose the next sns endpoint. */</span><br><span>          if (llist_empty(&gss->sns_endpoints)) {</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/libosmocore/+/22206">change 22206</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/libosmocore/+/22206"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: libosmocore </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Ie4db81acdd5f8ddf1a1f5dc7645d1144545d9c73 </div>
<div style="display:none"> Gerrit-Change-Number: 22206 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: lynxis lazus <lynxis@fe80.eu> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>