<p>pespin has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/osmo-iuh/+/22174">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">tests/hnb-test: Fix uninitialized use of rc variable<br><br>Change-Id: I168e4f7cd48cbaa387e6b05868107250795a0f0c<br>---<br>M src/tests/hnb-test.c<br>1 file changed, 3 insertions(+), 4 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-iuh refs/changes/74/22174/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/tests/hnb-test.c b/src/tests/hnb-test.c</span><br><span>index 4696e80..4650a90 100644</span><br><span>--- a/src/tests/hnb-test.c</span><br><span>+++ b/src/tests/hnb-test.c</span><br><span>@@ -478,7 +478,7 @@</span><br><span>                            msg->data, msgb_length(msg), 0, 0);</span><br><span>         if (dec_ret.code != RC_OK) {</span><br><span>                 LOGP(DMAIN, LOGL_ERROR, "Error in ASN.1 decode\n");</span><br><span style="color: hsl(0, 100%, 40%);">-           return rc;</span><br><span style="color: hsl(120, 100%, 40%);">+            return -EINVAL;</span><br><span>      }</span><br><span> </span><br><span>        if (pdu->present != HNBAP_PDU_PR_successfulOutcome) {</span><br><span>@@ -506,14 +506,13 @@</span><br><span> {</span><br><span>        RUA_RUA_PDU_t _pdu, *pdu = &_pdu;</span><br><span>        asn_dec_rval_t dec_ret;</span><br><span style="color: hsl(0, 100%, 40%);">- int rc;</span><br><span> </span><br><span>  memset(pdu, 0, sizeof(*pdu));</span><br><span>        dec_ret = aper_decode(NULL, &asn_DEF_RUA_RUA_PDU, (void **) &pdu,</span><br><span>                          msg->data, msgb_length(msg), 0, 0);</span><br><span>         if (dec_ret.code != RC_OK) {</span><br><span>                 LOGP(DMAIN, LOGL_ERROR, "Error in ASN.1 decode\n");</span><br><span style="color: hsl(0, 100%, 40%);">-           return rc;</span><br><span style="color: hsl(120, 100%, 40%);">+            return -EINVAL;</span><br><span>      }</span><br><span> </span><br><span>        switch (pdu->present) {</span><br><span>@@ -560,7 +559,7 @@</span><br><span>             break;</span><br><span>       }</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-   return rc;</span><br><span style="color: hsl(120, 100%, 40%);">+    return 0;</span><br><span> }</span><br><span> </span><br><span> static int hnb_read_cb(struct osmo_fd *fd)</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-iuh/+/22174">change 22174</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-iuh/+/22174"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-iuh </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I168e4f7cd48cbaa387e6b05868107250795a0f0c </div>
<div style="display:none"> Gerrit-Change-Number: 22174 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>