<p>fixeria has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/osmo-bsc/+/22192">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">power_control: fix: properly initialize per-lchan BS power<br><br>My assumption that lchan_reset() is called on CHANnel ACTIVation<br>was wrong - it's actually called on CHANnel RELease.  Therefore<br>(re)setting per-lchan BS power value must be done in the other<br>function that is responsible for channel activation.<br><br>Change-Id: I056c448ce017458dc4a004374ddca86d44dc35b4<br>Related: SYS#4918<br>---<br>M src/osmo-bsc/lchan_fsm.c<br>1 file changed, 6 insertions(+), 6 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/92/22192/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/osmo-bsc/lchan_fsm.c b/src/osmo-bsc/lchan_fsm.c</span><br><span>index 5a42527..43916b4 100644</span><br><span>--- a/src/osmo-bsc/lchan_fsm.c</span><br><span>+++ b/src/osmo-bsc/lchan_fsm.c</span><br><span>@@ -411,12 +411,6 @@</span><br><span> </span><br><span>            .release.rr_cause = GSM48_RR_CAUSE_NORMAL,</span><br><span>   };</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">-      /* Default BS Power reduction value (in 2 dB steps) */</span><br><span style="color: hsl(0, 100%, 40%);">-  if (bts->bs_power_ctrl.mode == GSM_PWR_CTRL_MODE_DYN_BTS)</span><br><span style="color: hsl(0, 100%, 40%);">-            lchan->bs_power = bts->bs_power_ctrl.bs_power_max_db / 2;</span><br><span style="color: hsl(0, 100%, 40%);">- else</span><br><span style="color: hsl(0, 100%, 40%);">-            lchan->bs_power = bts->bs_power_ctrl.bs_power_val_db / 2;</span><br><span> }</span><br><span> </span><br><span> static void lchan_fsm_unused_onenter(struct osmo_fsm_inst *fi, uint32_t prev_state)</span><br><span>@@ -595,6 +589,12 @@</span><br><span>               /* Upon last entering the UNUSED state, from lchan_reset():</span><br><span>           * - bs_power is still zero, 0dB reduction, output power = Pn.</span><br><span>                * - TA is still zero, to be determined by RACH. */</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+         /* Default BS Power reduction value (in 2 dB steps) */</span><br><span style="color: hsl(120, 100%, 40%);">+                if (bts->bs_power_ctrl.mode == GSM_PWR_CTRL_MODE_DYN_BTS)</span><br><span style="color: hsl(120, 100%, 40%);">+                  lchan->bs_power = bts->bs_power_ctrl.bs_power_max_db / 2;</span><br><span style="color: hsl(120, 100%, 40%);">+               else</span><br><span style="color: hsl(120, 100%, 40%);">+                  lchan->bs_power = bts->bs_power_ctrl.bs_power_val_db / 2;</span><br><span>      }</span><br><span> </span><br><span>        if (info->chan_mode == GSM48_CMODE_SPEECH_AMR) {</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-bsc/+/22192">change 22192</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-bsc/+/22192"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-bsc </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I056c448ce017458dc4a004374ddca86d44dc35b4 </div>
<div style="display:none"> Gerrit-Change-Number: 22192 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: fixeria <vyanitskiy@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>