<p>daniel has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/libosmocore/+/22193">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">NS2: Fix bind selection of SNS NSVCs<br><br>The SNS code ignored the link type of the bind and just bound to every<br>bind it could find. This resulted in a segfault when an SNS NSVC tries<br>to send its UDP messages though frame relay.<br><br>Fixes: OS#4948<br>Change-Id: Ibb832a39876362d094cce635192f7b4f84dc2b10<br>---<br>M src/gb/gprs_ns2_sns.c<br>1 file changed, 8 insertions(+), 0 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/93/22193/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/gb/gprs_ns2_sns.c b/src/gb/gprs_ns2_sns.c</span><br><span>index 2cb4293..1958477 100644</span><br><span>--- a/src/gb/gprs_ns2_sns.c</span><br><span>+++ b/src/gb/gprs_ns2_sns.c</span><br><span>@@ -270,6 +270,8 @@</span><br><span> </span><br><span>       /* for every bind, create a connection if bind type == IP */</span><br><span>         llist_for_each_entry(bind, &nsi->binding, list) {</span><br><span style="color: hsl(120, 100%, 40%);">+              if (bind->ll != GPRS_NS2_LL_UDP)</span><br><span style="color: hsl(120, 100%, 40%);">+                   continue;</span><br><span>            /* ignore failed connection */</span><br><span>               nsvc = gprs_ns2_ip_connect_inactive(bind,</span><br><span>                                       &remote,</span><br><span>@@ -299,6 +301,8 @@</span><br><span> </span><br><span>    /* for every bind, create a connection if bind type == IP */</span><br><span>         llist_for_each_entry(bind, &nsi->binding, list) {</span><br><span style="color: hsl(120, 100%, 40%);">+              if (bind->ll != GPRS_NS2_LL_UDP)</span><br><span style="color: hsl(120, 100%, 40%);">+                   continue;</span><br><span>            /* ignore failed connection */</span><br><span>               nsvc = gprs_ns2_ip_connect_inactive(bind,</span><br><span>                                       &remote,</span><br><span>@@ -332,6 +336,8 @@</span><br><span> </span><br><span>            llist_for_each_entry(bind, &nse->nsi->binding, list) {</span><br><span>                     bool found = false;</span><br><span style="color: hsl(120, 100%, 40%);">+                   if (bind->ll != GPRS_NS2_LL_UDP)</span><br><span style="color: hsl(120, 100%, 40%);">+                           continue;</span><br><span> </span><br><span>                        llist_for_each_entry(nsvc, &nse->nsvc, list) {</span><br><span>                                if (nsvc->bind != bind)</span><br><span>@@ -367,6 +373,8 @@</span><br><span> </span><br><span>                 llist_for_each_entry(bind, &nse->nsi->binding, list) {</span><br><span>                     bool found = false;</span><br><span style="color: hsl(120, 100%, 40%);">+                   if (bind->ll != GPRS_NS2_LL_UDP)</span><br><span style="color: hsl(120, 100%, 40%);">+                           continue;</span><br><span> </span><br><span>                        llist_for_each_entry(nsvc, &nse->nsvc, list) {</span><br><span>                                if (nsvc->bind != bind)</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/libosmocore/+/22193">change 22193</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/libosmocore/+/22193"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: libosmocore </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Ibb832a39876362d094cce635192f7b4f84dc2b10 </div>
<div style="display:none"> Gerrit-Change-Number: 22193 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: daniel <dwillmann@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>