<p>fixeria has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/osmo-bsc/+/22165">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">power_control: do not send BS Power IEs for channels on C0/TRX0<br><br>Reducing transmit power on C0/TRX0 is not permitted in GSM (there<br>are some energy saving enhancements though), so the BSC shall not<br>be sending any BS Power IEs when allocating channels there.<br><br>Change-Id: If8507992dfd90ade1edda99b72bf2420a702ccd5<br>Related: SYS#4918<br>---<br>M src/osmo-bsc/abis_rsl.c<br>1 file changed, 4 insertions(+), 2 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/65/22165/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/osmo-bsc/abis_rsl.c b/src/osmo-bsc/abis_rsl.c</span><br><span>index 2142219..e3270a7 100644</span><br><span>--- a/src/osmo-bsc/abis_rsl.c</span><br><span>+++ b/src/osmo-bsc/abis_rsl.c</span><br><span>@@ -597,14 +597,16 @@</span><br><span>         }</span><br><span> </span><br><span>        if (bts->bs_power_ctrl.mode != GSM_PWR_CTRL_MODE_NONE)</span><br><span style="color: hsl(0, 100%, 40%);">-               msgb_tv_put(msg, RSL_IE_BS_POWER, lchan->bs_power);</span><br><span style="color: hsl(120, 100%, 40%);">+                if (trx != bts->c0) /* BS power control is not allowed on C0/TRX0 */</span><br><span style="color: hsl(120, 100%, 40%);">+                       msgb_tv_put(msg, RSL_IE_BS_POWER, lchan->bs_power);</span><br><span>       if (bts->ms_power_ctrl.mode != GSM_PWR_CTRL_MODE_NONE)</span><br><span>            msgb_tv_put(msg, RSL_IE_MS_POWER, lchan->ms_power);</span><br><span> </span><br><span>   msgb_tv_put(msg, RSL_IE_TIMING_ADVANCE, ta);</span><br><span> </span><br><span>     /* BS/MS Power Control Parameters (if supported by BTS model) */</span><br><span style="color: hsl(0, 100%, 40%);">-        add_power_control_params(msg, RSL_IE_BS_POWER_PARAM, lchan);</span><br><span style="color: hsl(120, 100%, 40%);">+  if (trx != bts->c0) /* BS power control is not allowed on C0/TRX0 */</span><br><span style="color: hsl(120, 100%, 40%);">+               add_power_control_params(msg, RSL_IE_BS_POWER_PARAM, lchan);</span><br><span>         add_power_control_params(msg, RSL_IE_MS_POWER_PARAM, lchan);</span><br><span> </span><br><span>     mr_config_for_bts(lchan, msg);</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-bsc/+/22165">change 22165</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-bsc/+/22165"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-bsc </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: If8507992dfd90ade1edda99b72bf2420a702ccd5 </div>
<div style="display:none"> Gerrit-Change-Number: 22165 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: fixeria <vyanitskiy@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>