<p>laforge <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/osmo-bts/+/22123">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  Jenkins Builder: Verified
  laforge: Looks good to me, approved

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">l1sap: use rxlev_full when no DTX was used<br><br>At the moment only rxlev_sub is used to decide when the facch repetition<br>should be activated, regardless if DTX is used. Lets check if DTX is<br>actually used and use rxlev_full when DTX is not applied.<br><br>Change-Id: I01ba57cf661f0e41b8df209c905f8d135013e472<br>Related: SYS#5114<br>---<br>M src/common/l1sap.c<br>1 file changed, 11 insertions(+), 1 deletion(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/common/l1sap.c b/src/common/l1sap.c</span><br><span>index 2757d70..3f601fd 100644</span><br><span>--- a/src/common/l1sap.c</span><br><span>+++ b/src/common/l1sap.c</span><br><span>@@ -972,6 +972,7 @@</span><br><span>   const struct gsm48_meas_res *meas_res;</span><br><span>       uint8_t upper;</span><br><span>       uint8_t lower;</span><br><span style="color: hsl(120, 100%, 40%);">+        uint8_t rxqual;</span><br><span> </span><br><span>  if (!lchan->repeated_acch_capability.dl_facch_cmd</span><br><span>             && !lchan->repeated_acch_capability.dl_facch_all)</span><br><span>@@ -1008,10 +1009,19 @@</span><br><span>           lower = lchan->repeated_acch_capability.rxqual - 2;</span><br><span>       else</span><br><span>                 lower = 0;</span><br><span style="color: hsl(0, 100%, 40%);">-      if (meas_res->rxqual_sub >= upper)</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+    /* When downlink DTX is applied, use RXQUAL-SUB, otherwise use</span><br><span style="color: hsl(120, 100%, 40%);">+         * RXQUAL-FULL. */</span><br><span style="color: hsl(120, 100%, 40%);">+    if (meas_res->dtx_used)</span><br><span style="color: hsl(120, 100%, 40%);">+            rxqual = meas_res->rxqual_sub;</span><br><span style="color: hsl(120, 100%, 40%);">+     else</span><br><span style="color: hsl(120, 100%, 40%);">+          rxqual = meas_res->rxqual_full;</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+  if (rxqual >= upper)</span><br><span>              lchan->repeated_dl_facch_active = true;</span><br><span>   else if (meas_res->rxqual_sub <= lower)</span><br><span>                lchan->repeated_dl_facch_active = false;</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span> }</span><br><span> </span><br><span> /* Special dequeueing function with SACCH repetition (3GPP TS 44.006, section 11) */</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-bts/+/22123">change 22123</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-bts/+/22123"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-bts </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I01ba57cf661f0e41b8df209c905f8d135013e472 </div>
<div style="display:none"> Gerrit-Change-Number: 22123 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: dexter <pmaier@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>