<p>laforge <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/osmo-bsc/+/22083">View Change</a></p><div style="white-space:pre-wrap">Approvals:
Jenkins Builder: Verified
laforge: Looks good to me, approved
pespin: Looks good to me, but someone else must approve
</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">handover_test: show bug: add test_balance_congestion_tchf_tchh.ho_vty<br><br>Change-Id: I78fd146fb9b9f9e5d61234065abecbedb9f30a3a<br>---<br>M tests/handover/handover_tests.ok<br>A tests/handover/test_balance_congestion_tchf_tchh.ho_vty<br>2 files changed, 54 insertions(+), 0 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/tests/handover/handover_tests.ok b/tests/handover/handover_tests.ok</span><br><span>index 521a0fe..95442a3 100644</span><br><span>--- a/tests/handover/handover_tests.ok</span><br><span>+++ b/tests/handover/handover_tests.ok</span><br><span>@@ -8,6 +8,7 @@</span><br><span> pass test_amr_tch_h_to_f_congestion_two_cells.ho_vty</span><br><span> pass test_balance_congestion.ho_vty</span><br><span> pass test_balance_congestion_2.ho_vty</span><br><span style="color: hsl(120, 100%, 40%);">+pass test_balance_congestion_tchf_tchh.ho_vty</span><br><span> pass test_congestion.ho_vty</span><br><span> pass test_congestion_favor_best_target_rxlev.ho_vty</span><br><span> pass test_congestion_intra_vs_inter_cell.ho_vty</span><br><span>diff --git a/tests/handover/test_balance_congestion_tchf_tchh.ho_vty b/tests/handover/test_balance_congestion_tchf_tchh.ho_vty</span><br><span>new file mode 100644</span><br><span>index 0000000..d7b3cf5</span><br><span>--- /dev/null</span><br><span>+++ b/tests/handover/test_balance_congestion_tchf_tchh.ho_vty</span><br><span>@@ -0,0 +1,53 @@</span><br><span style="color: hsl(120, 100%, 40%);">+# Balance congestion across cells and across TCH/F and TCH/H.</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+network</span><br><span style="color: hsl(120, 100%, 40%);">+ handover2 min-free-slots tch/f 3</span><br><span style="color: hsl(120, 100%, 40%);">+ handover2 min-free-slots tch/h 3</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+create-bts trx-count 1 timeslots c+s4 TCH/F TCH/F TCH/F TCH/F TCH/H TCH/H TCH/H</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+# both TCH/H and TCH/F have one lchan above congestion, nothing happens</span><br><span style="color: hsl(120, 100%, 40%);">+set-ts-use trx 0 0 states * TCH/F TCH/F - - TCH/HH TCH/HH -</span><br><span style="color: hsl(120, 100%, 40%);">+meas-rep lchan * * * * rxlev 10 rxqual 0 ta 0</span><br><span style="color: hsl(120, 100%, 40%);">+congestion-check</span><br><span style="color: hsl(120, 100%, 40%);">+expect-no-chan</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+# TCH/F = +1, TCH/H = +2 above congestion. Moving a TCH/H to TCH/F would just reverse the situation to F=+2 H=+1. Nothing happens.</span><br><span style="color: hsl(120, 100%, 40%);">+set-ts-use trx 0 0 states * TCH/F TCH/F - - TCH/HH TCH/HH TCH/H-</span><br><span style="color: hsl(120, 100%, 40%);">+meas-rep lchan * * * * rxlev 10 rxqual 0 ta 0</span><br><span style="color: hsl(120, 100%, 40%);">+congestion-check</span><br><span style="color: hsl(120, 100%, 40%);">+expect-no-chan</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+# F=+1 H=+3. Balance to F=+2 H=+2</span><br><span style="color: hsl(120, 100%, 40%);">+set-ts-use trx 0 0 states * TCH/F TCH/F - - TCH/HH TCH/HH TCH/HH</span><br><span style="color: hsl(120, 100%, 40%);">+meas-rep lchan * * * * rxlev 10 rxqual 0 ta 0</span><br><span style="color: hsl(120, 100%, 40%);">+congestion-check</span><br><span style="color: hsl(120, 100%, 40%);">+expect-ho from lchan 0 0 5 0 to lchan 0 0 3 0</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+# Now the exact same thing, just with different min-free-slots settings for</span><br><span style="color: hsl(120, 100%, 40%);">+# tch/f vs tch/h</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+network</span><br><span style="color: hsl(120, 100%, 40%);">+ handover2 min-free-slots tch/f 3</span><br><span style="color: hsl(120, 100%, 40%);">+ handover2 min-free-slots tch/h 5</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+# both TCH/H and TCH/F have one lchan above congestion, nothing happens</span><br><span style="color: hsl(120, 100%, 40%);">+set-ts-use trx 0 0 states * TCH/F TCH/F - - TCH/HH - -</span><br><span style="color: hsl(120, 100%, 40%);">+meas-rep lchan * * * * rxlev 20 rxqual 0 ta 0</span><br><span style="color: hsl(120, 100%, 40%);">+congestion-check</span><br><span style="color: hsl(120, 100%, 40%);">+# FAIL: should be the same as above, but seeing a handover from F to H</span><br><span style="color: hsl(120, 100%, 40%);">+expect-ho from lchan 0 0 1 0 to lchan 0 0 6 0</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+# TCH/F = +1, TCH/H = +2 above congestion. Moving a TCH/H to TCH/F would just</span><br><span style="color: hsl(120, 100%, 40%);">+# reverse the situation to F=+2 H=+1. Nothing happens.</span><br><span style="color: hsl(120, 100%, 40%);">+set-ts-use trx 0 0 states * TCH/F TCH/F - - TCH/HH TCH/H- -</span><br><span style="color: hsl(120, 100%, 40%);">+meas-rep lchan * * * * rxlev 20 rxqual 0 ta 0</span><br><span style="color: hsl(120, 100%, 40%);">+congestion-check</span><br><span style="color: hsl(120, 100%, 40%);">+expect-no-chan</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+# F=+1 H=+3. Balance to F=+2 H=+2</span><br><span style="color: hsl(120, 100%, 40%);">+set-ts-use trx 0 0 states * TCH/F TCH/F - - TCH/HH TCH/HH -</span><br><span style="color: hsl(120, 100%, 40%);">+meas-rep lchan * * * * rxlev 20 rxqual 0 ta 0</span><br><span style="color: hsl(120, 100%, 40%);">+congestion-check</span><br><span style="color: hsl(120, 100%, 40%);">+# FAIL: should be the same as above, from lchan 0 0 5 0 to lchan 0 0 3 0, but no handover happens</span><br><span style="color: hsl(120, 100%, 40%);">+expect-no-chan</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-bsc/+/22083">change 22083</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-bsc/+/22083"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: osmo-bsc </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I78fd146fb9b9f9e5d61234065abecbedb9f30a3a </div>
<div style="display:none"> Gerrit-Change-Number: 22083 </div>
<div style="display:none"> Gerrit-PatchSet: 3 </div>
<div style="display:none"> Gerrit-Owner: neels <nhofmeyr@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Reviewer: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>